From: Marc Dietrich <marvin24@gmx.de>
To: Wei Yongjun <weiyj.lk@gmail.com>, linux-tegra@vger.kernel.org
Cc: devel@driverdev.osuosl.org, swarren@wwwdotorg.org,
gregkh@linuxfoundation.org, devicetree-discuss@lists.ozlabs.org,
rob.herring@calxeda.com, grant.likely@secretlab.ca,
yongjun_wei@trendmicro.com.cn
Subject: Re: [PATCH] staging: nvec: fix the '&&' vs '&' typo in nvec_toggle_global_events()
Date: Sat, 16 Mar 2013 22:33:24 +0100 [thread overview]
Message-ID: <10181113.13atlJeaaa@ax5200p> (raw)
In-Reply-To: <CAPgLHd8rhMVb_cpVR6tiYsYTrOgk3m1PyR=Eo9L2_8bOGwwbag@mail.gmail.com>
Hi Yongjun,
On Saturday 16 March 2013 22:51:25 Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix the '&&' vs '&' typo.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/staging/nvec/nvec.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index cf15936..a88959f 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -352,10 +352,10 @@ static void nvec_toggle_global_events(struct nvec_chip *nvec, bool state)
> */
> static void nvec_event_mask(char *ev, u32 mask)
> {
> - ev[3] = mask >> 16 && 0xff;
> - ev[4] = mask >> 24 && 0xff;
> - ev[5] = mask >> 0 && 0xff;
> - ev[6] = mask >> 8 && 0xff;
> + ev[3] = mask >> 16 & 0xff;
> + ev[4] = mask >> 24 & 0xff;
> + ev[5] = mask >> 0 & 0xff;
> + ev[6] = mask >> 8 & 0xff;
> }
>
> /**
yes, this was obviously wrong. Thanks for fixing!
Acked-By: Marc Dietrich <marvin24@gmx.de>
prev parent reply other threads:[~2013-03-16 21:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-16 14:51 [PATCH] staging: nvec: fix the '&&' vs '&' typo in nvec_toggle_global_events() Wei Yongjun
2013-03-16 21:33 ` Marc Dietrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10181113.13atlJeaaa@ax5200p \
--to=marvin24@gmx.de \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).