* [PATCH] staging: nvec: fix the '&&' vs '&' typo in nvec_toggle_global_events()
@ 2013-03-16 14:51 Wei Yongjun
2013-03-16 21:33 ` Marc Dietrich
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-03-16 14:51 UTC (permalink / raw)
To: jak-4HMq4SXA452hPH1hqNUYSQ, marvin24-Mmb7MZpHnFY,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r,
grant.likely-s3s/WqlpOiPyB63q8FvJNQ,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ,
swarren-3lzwWm7+Weoh9ZMKESR00Q
Cc: yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY,
ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
Fix the '&&' vs '&' typo.
Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
---
drivers/staging/nvec/nvec.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index cf15936..a88959f 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -352,10 +352,10 @@ static void nvec_toggle_global_events(struct nvec_chip *nvec, bool state)
*/
static void nvec_event_mask(char *ev, u32 mask)
{
- ev[3] = mask >> 16 && 0xff;
- ev[4] = mask >> 24 && 0xff;
- ev[5] = mask >> 0 && 0xff;
- ev[6] = mask >> 8 && 0xff;
+ ev[3] = mask >> 16 & 0xff;
+ ev[4] = mask >> 24 & 0xff;
+ ev[5] = mask >> 0 & 0xff;
+ ev[6] = mask >> 8 & 0xff;
}
/**
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: nvec: fix the '&&' vs '&' typo in nvec_toggle_global_events()
2013-03-16 14:51 [PATCH] staging: nvec: fix the '&&' vs '&' typo in nvec_toggle_global_events() Wei Yongjun
@ 2013-03-16 21:33 ` Marc Dietrich
0 siblings, 0 replies; 2+ messages in thread
From: Marc Dietrich @ 2013-03-16 21:33 UTC (permalink / raw)
To: Wei Yongjun, linux-tegra
Cc: devel, swarren, gregkh, devicetree-discuss, rob.herring,
grant.likely, yongjun_wei
Hi Yongjun,
On Saturday 16 March 2013 22:51:25 Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix the '&&' vs '&' typo.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/staging/nvec/nvec.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index cf15936..a88959f 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -352,10 +352,10 @@ static void nvec_toggle_global_events(struct nvec_chip *nvec, bool state)
> */
> static void nvec_event_mask(char *ev, u32 mask)
> {
> - ev[3] = mask >> 16 && 0xff;
> - ev[4] = mask >> 24 && 0xff;
> - ev[5] = mask >> 0 && 0xff;
> - ev[6] = mask >> 8 && 0xff;
> + ev[3] = mask >> 16 & 0xff;
> + ev[4] = mask >> 24 & 0xff;
> + ev[5] = mask >> 0 & 0xff;
> + ev[6] = mask >> 8 & 0xff;
> }
>
> /**
yes, this was obviously wrong. Thanks for fixing!
Acked-By: Marc Dietrich <marvin24@gmx.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-16 21:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-16 14:51 [PATCH] staging: nvec: fix the '&&' vs '&' typo in nvec_toggle_global_events() Wei Yongjun
2013-03-16 21:33 ` Marc Dietrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).