From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCHv6 2/4] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC Date: Fri, 18 Jul 2014 18:31:40 +0200 Message-ID: <10264770.8SXiIS8qhq@wuerfel> References: <1405663186-26464-1-git-send-email-cw00.choi@samsung.com> <32226622.5gSmvBRKvZ@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: Chanwoo Choi Cc: linux-arm-kernel , Mark Rutland , devicetree , Kukjin Kim , pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, linux-iio@vger.kernel.org, Tomasz Figa , rdunlap@infradead.org, linux-doc@vger.kernel.org, linux-kernel , Rob Herring , Chanwoo Choi , Kyungmin Park , linux-samsung-soc , galak@codeaurora.org, naveen krishna , jic23@kernel.org List-Id: devicetree@vger.kernel.org On Saturday 19 July 2014 01:11:53 Chanwoo Choi wrote: > > Exynos3250/Exynos4/Exynos5 has 'adc' clock as following: > - 'adc' clock: bus clock for ADC > > Exynos3250 has additional 'sclk_adc' clock as following: > - 'sclk_adc' clock: special clock for ADC which provide clock to internal ADC The bus clock is often named "apb_pclk", but it's too late to change that now, and it's not clear if the device is actually on APB. The problem with "sclk_adc" is that it's very close to the name used in the clock provider, with is CLK_SCLK_TSADC. Please try to avoid the ambiguity here and make it clear that they are not referring to the same thing. "internal" or "special" might be good if you want to avoid "sclk". Arnd