Re: [PATCH] arm64: dts: rockchip: add missing tx/rx-fifo-depth

[Heiko Stuebner <heiko@sntech.de>]

Hi,

Am Mittwoch, 15. November 2023, 22:04:17 CET schrieb shironeko:

just if you need to resend, the patch subject could please
mention both the gmac and rk3328 :-)

> Without fifo depths attempting to change the MTU will fail. These values
> are from the RK3328 Technical Reference Manual, briefly tested with Rock64.
> 
> Signed-off-by: shironeko <shironeko@tesaguri.club>
> ---
>  arch/arm64/boot/dts/rockchip/rk3328.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> index e729e7a22b23..1573250ac24e 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> @@ -916,6 +916,8 @@ gmac2io: ethernet@ff540000 {
>  		resets = <&cru SRST_GMAC2IO_A>;
>  		reset-names = "stmmaceth";
>  		rockchip,grf = <&grf>;
> +		tx-fifo-depth = <2048>;
> +		rx-fifo-depth = <4096>;
>  		snps,txpbl = <0x4>;
>  		status = "disabled";
>  	};
> 

hmm, what about the other gmac-interface (gmac2phy).
Does the TRM provide depth information for that too?


Thanks
Heiko