* [PATCH] arm64: dts: rockchip: add missing tx/rx-fifo-depth
@ 2023-11-15 21:04 shironeko
2023-11-16 20:12 ` Heiko Stuebner
0 siblings, 1 reply; 3+ messages in thread
From: shironeko @ 2023-11-15 21:04 UTC (permalink / raw)
To: devicetree; +Cc: heiko, conor+dt, krzysztof.kozlowski+dt, robh+dt, shironeko
Without fifo depths attempting to change the MTU will fail. These values
are from the RK3328 Technical Reference Manual, briefly tested with Rock64.
Signed-off-by: shironeko <shironeko@tesaguri.club>
---
arch/arm64/boot/dts/rockchip/rk3328.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index e729e7a22b23..1573250ac24e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -916,6 +916,8 @@ gmac2io: ethernet@ff540000 {
resets = <&cru SRST_GMAC2IO_A>;
reset-names = "stmmaceth";
rockchip,grf = <&grf>;
+ tx-fifo-depth = <2048>;
+ rx-fifo-depth = <4096>;
snps,txpbl = <0x4>;
status = "disabled";
};
--
2.42.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: add missing tx/rx-fifo-depth
2023-11-15 21:04 [PATCH] arm64: dts: rockchip: add missing tx/rx-fifo-depth shironeko
@ 2023-11-16 20:12 ` Heiko Stuebner
2023-11-16 21:46 ` shironeko
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Stuebner @ 2023-11-16 20:12 UTC (permalink / raw)
To: devicetree, shironeko
Cc: conor+dt, krzysztof.kozlowski+dt, robh+dt, shironeko
Hi,
Am Mittwoch, 15. November 2023, 22:04:17 CET schrieb shironeko:
just if you need to resend, the patch subject could please
mention both the gmac and rk3328 :-)
> Without fifo depths attempting to change the MTU will fail. These values
> are from the RK3328 Technical Reference Manual, briefly tested with Rock64.
>
> Signed-off-by: shironeko <shironeko@tesaguri.club>
> ---
> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> index e729e7a22b23..1573250ac24e 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> @@ -916,6 +916,8 @@ gmac2io: ethernet@ff540000 {
> resets = <&cru SRST_GMAC2IO_A>;
> reset-names = "stmmaceth";
> rockchip,grf = <&grf>;
> + tx-fifo-depth = <2048>;
> + rx-fifo-depth = <4096>;
> snps,txpbl = <0x4>;
> status = "disabled";
> };
>
hmm, what about the other gmac-interface (gmac2phy).
Does the TRM provide depth information for that too?
Thanks
Heiko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: add missing tx/rx-fifo-depth
2023-11-16 20:12 ` Heiko Stuebner
@ 2023-11-16 21:46 ` shironeko
0 siblings, 0 replies; 3+ messages in thread
From: shironeko @ 2023-11-16 21:46 UTC (permalink / raw)
To: Heiko Stuebner, devicetree
>just if you need to resend, the patch subject could please
>mention both the gmac and rk3328 :-)
will do
>hmm, what about the other gmac-interface (gmac2phy).
>Does the TRM provide depth information for that too?
the manual doesn't say it's specific to gmac2io, I just don't have a board to test gmac2phy. Will include it in v2
shironeko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-16 21:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-15 21:04 [PATCH] arm64: dts: rockchip: add missing tx/rx-fifo-depth shironeko
2023-11-16 20:12 ` Heiko Stuebner
2023-11-16 21:46 ` shironeko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox