From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E808C4338F for ; Sat, 21 Aug 2021 15:28:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12E906115A for ; Sat, 21 Aug 2021 15:28:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231732AbhHUP3X (ORCPT ); Sat, 21 Aug 2021 11:29:23 -0400 Received: from gloria.sntech.de ([185.11.138.130]:38616 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231491AbhHUP3X (ORCPT ); Sat, 21 Aug 2021 11:29:23 -0400 Received: from p5b3b3c9d.dip0.t-ipconnect.de ([91.59.60.157] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mHSvK-0000I5-5o; Sat, 21 Aug 2021 17:28:42 +0200 From: Heiko Stuebner To: Doug Anderson , Brian Norris Cc: Linux ARM , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:ARM/Rockchip SoC..." Subject: Re: [PATCH] arm64: dts: rockchip: add RK3399 Gru gpio-line-names Date: Sat, 21 Aug 2021 17:28:40 +0200 Message-ID: <10392569.T7Z3S40VBb@phil> In-Reply-To: References: <20210820133829.1.Ica46f428de8c3beb600760dbcd63cf879ec24baf@changeid> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Freitag, 20. August 2021, 23:16:23 CEST schrieb Brian Norris: > On Fri, Aug 20, 2021 at 2:05 PM Doug Anderson wrote: > > I guess one minor nit (now that I look back on the veyron patch where > > I mentioned it explicitly in the commit message) is that on the veyron > > ones we sorted this down at the bottom with the other pinctrl stuff > > instead of sorting it alphabetically with everything else. I'll let > > Heiko say which he likes better. > > Huh, didn't notice that semi-convention. I can sort it however Heiko prefers. Hmm, I wouldn't call it a semi-convention ... it was more an idea of getting all the longer pages of "stuff" out of the way. I don't think I have a real hard preference for the gpioX nodes and I guess in the long run it might be helpful to try to limit the number of "semi-conventions" . I still like "pinctrl at the bottom", but I guess it might be easier to with alphabetical for nodes with the rest :-) . Heiko > > I also notice for veyron that we had a second "ABI" exception for the > > recovery mode pin, but I believe that goes through a different > > mechanism now so we're good there. > > I believe the recovery mode pin is dropped from recent designs (don't > quote me in general on that), and there's a different mechanism used > just to get the at-boot-time "recovery mode" state directly from the > firmware. > > > Even though I didn't do a line-by-line review, I'll still give: > > > > Reviewed-by: Douglas Anderson > > > > ...though it's possible an "Acked-by" would be more in the spirit of > > that? Not sure... > > Thanks! > > Brian >