From: Fidelio LAWSON <lawson.fidelio@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Marek Vasut <marex@denx.de>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Fidelio Lawson <fidelio.lawson@exotec.com>
Subject: Re: [PATCH v2] net: dsa: microchip: implement KSZ87xx Module 3 low-loss cable errata
Date: Wed, 8 Apr 2026 17:25:41 +0200 [thread overview]
Message-ID: <1040e6be-6223-4cfc-b603-e2dd90713bb7@gmail.com> (raw)
In-Reply-To: <a350c4b7-d816-455b-83c0-f4d98299c637@lunn.ch>
On 4/8/26 14:43, Andrew Lunn wrote:
>> The control register defines the following modes:
>> bits [1:0]:
>> 00 = workaround disabled
>> 01 = workaround 1 (DSP EQ training adjustment, LinkMD reg 0x3c)
>> 10 = workaround 2 (receiver LPF bandwidth, LinkMD reg 0x4c)
>
> There was a comment, which i only read after making the suggestion to
> use two bits, of exposing the different low pass filter bandwidths,
> rather than just picking one value. How useful is that?
>
> Andrew
Initially I limited the LPF setting to the single bandwidth explicitly
recommended by the errata (62MHz).
But I’ll extend the implementation to expose all documented LPF
bandwidth options so the interface is more flexible for users.
Best regards,
Fidelio
next prev parent reply other threads:[~2026-04-08 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 11:57 [PATCH v2] net: dsa: microchip: implement KSZ87xx Module 3 low-loss cable errata Fidelio Lawson
2026-04-08 12:43 ` Andrew Lunn
2026-04-08 15:25 ` Fidelio LAWSON [this message]
2026-04-08 12:49 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1040e6be-6223-4cfc-b603-e2dd90713bb7@gmail.com \
--to=lawson.fidelio@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=fidelio.lawson@exotec.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox