From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10DA4134CE for ; Tue, 6 Feb 2024 18:23:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707243821; cv=none; b=ZJ+AB19bB+xYvIMWzqnEPmKpRqgkbzXQRHHBCsDPTNTJokGYdji+Kj8iY2AN26we5OWSubxakcB7e/BOQCcg5sb7lh8k5QV7BfAC+FTFwL124weK9OvIgTj8zKk/Bf4zSMYnNe7dAHAdAmMDdk7hAdcQ5A4soor6LPcW4DQc6eg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707243821; c=relaxed/simple; bh=5pahx9/bm3BCJU9qQeKO3WrSmKD0996qQTJ4fGrNv0M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Jz9xfyoYDyMI8lZDLKkhZKlQbJ5TZTd+oA2vhcex+AeC+EQQCmltKhLxZfM7M+Izg20jkvgDwkS0TMW5qayN5SXqbxhf62Hbu1x16JK4Su40XzVq3MA7EqxYja0bHjiO4GfSX/Vh7p5Kqe4qYRduFbxYU6+cM021HcXOiFHdQr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MS5Sfqps; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MS5Sfqps" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-40ff812442aso3252605e9.2 for ; Tue, 06 Feb 2024 10:23:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707243817; x=1707848617; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fT2/5bSThF1sdilh5dLwSL8VIlDOPbmWMbkWzRPr6u4=; b=MS5Sfqps49VL+yK2wpca6AZHrRty1oud+4uEvN53guVX/STL4qSnkxETX87fFrwxuH AhX5Ln6OfBu2p4Sfow/m7+5wriFSlmqSk467NqeQRWuL6k8pHVU1zrH5Re0PUm6dkkU5 nxYtJIlQ/y1lFdrmldxvH5lzY7fE5wWmaO5F1ct25qZ7VEBfuC599vG7hHpLwPN6aMwk DS4Bv2RpcOOLJDg7ZxI6keHg/wN2ZRdQ8W6o64iFxcEd+Bko9BL1AXlE1M4S14sMf/HW iDwcakAY3hfVMVgcn1bN8Frvo/zz8BUHz9NsTUltiEK3wFSJiwE0ydd61vBN9iO2YtoT JmPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707243817; x=1707848617; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fT2/5bSThF1sdilh5dLwSL8VIlDOPbmWMbkWzRPr6u4=; b=lrNOzhFRBe8KBzf0ZJV0Ur7VidEbENazZl4V4mb+nkEQMKhNg2sExAfDRbVftnf6YC eb4deaov3/G2eAWSgqUf3PIfUNDD+pCvxGRKlAoPyDxOm2377hLf+ncDqNnInzgaWYl6 b1wTTPU9srMcPTHXVW3oyyBexOcg8N3WODC+9sJRD7ZLH2MH0nWsV/n/IJJgshDeY04q QYWJqv5zZSDotR+vJTvBov7RjPfhfROcgIKYTcCjhVhoQ2oWsCTSrxrdL3g6ulT2skeG KkBeHAs4/QllcIvVhvvagpZ5EO6mMO5K9l/NBDDfb/PCl34CTKz1QVKry32Z7OI7JvAI dX/A== X-Gm-Message-State: AOJu0Yx7U3VuxsF8Nt9D/vk6cY6+MIWHjNRDLoL0Ax7p5oavI+1PgRMa o1PRbH8d0Y3CYoldMg97bQoWd3izRQ0s+P6flTU4S+i+6wtaL1Yg X-Google-Smtp-Source: AGHT+IGPDnAD/SgN5L60MCWjY4H7ibpMHuIw0zQJOUN+I5tFtaJVLkOmBo8KNPrsjPFi02SA08PPsg== X-Received: by 2002:a05:600c:3543:b0:40f:c1fc:e5b6 with SMTP id i3-20020a05600c354300b0040fc1fce5b6mr2391704wmq.38.1707243817004; Tue, 06 Feb 2024 10:23:37 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVrRsA3bPDA0jZwBF29aJAGE6DlNUJNfPs+W3OwBQhL4GpGU5Fwnthd6OJaLUGTQlUPS36T3M+WS2XNiKmDEaEOuqSBPaTBzZ7GTDJMj4DIAq5Yj9M3A74ZAzaeV9jzRCe6o87837Nu1CvYSiOfXHVdBpPgdCHdUSksan+EYwxetk/g/E0l6BtbBUBmfR3JILQxlJ+WcQDPkARy1Fviy9lIKY1Et5+AkYndm7ZAqI3+VT+bJZdInIXAeWIhhYsods00DBWh4jsNEMZv5El7aTnBpAt64DA7BkZ0nCO8Z7271EWTh9xh/br6SqkQEikCvK97Hf5jOr5CXBY1Bv+vE1gT1Q== Received: from jernej-laptop.localnet (86-58-6-171.dynamic.telemach.net. [86.58.6.171]) by smtp.gmail.com with ESMTPSA id s13-20020a5d4ecd000000b0033b444a39a9sm2627755wrv.54.2024.02.06.10.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:23:36 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Samuel Holland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andre Przywara Cc: linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nick Alilovic Subject: Re: [PATCH 3/3] arm64: dts: allwinner: Add Jide Remix Mini PC support Date: Tue, 06 Feb 2024 19:23:35 +0100 Message-ID: <10413667.nUPlyArG6x@jernej-laptop> In-Reply-To: <8d9d1d7c-8066-4400-8fe4-68aa0e28023d@arm.com> References: <20240204094404.149776-1-andre.przywara@arm.com> <4867577.GXAFRqVoOG@jernej-laptop> <8d9d1d7c-8066-4400-8fe4-68aa0e28023d@arm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dne torek, 06. februar 2024 ob 19:13:46 CET je Andre Przywara napisal(a): > Hi Jernej, >=20 > On 06/02/2024 18:32, Jernej =C5=A0krabec wrote: > > Dne torek, 06. februar 2024 ob 01:47:05 CET je Andre Przywara napisal(a= ): > >> Hi Jernej, > >> > >> thanks for having a look! > >> > >> On 05/02/2024 19:20, Jernej =C5=A0krabec wrote: > >>> Dne ponedeljek, 05. februar 2024 ob 19:12:45 CET je Jernej =C5=A0krab= ec napisal(a): > >>>> Hi Andre! > >>>> > >>>> Dne nedelja, 04. februar 2024 ob 10:44:04 CET je Andre Przywara napi= sal(a): > >>>>> The Remix Mini PC is a "mini computer" using the Allwinner H64 SoC, > >>>>> which appears to be just a relabelled A64. It was launched in 2015 = by > >>>>> the now defunct company Jide, and shipped with a desktop optimised > >>>>> version of Android. It features > >>>>> - Allwinner H64 Soc (4 * Arm Cortex-A53 cores) > >>>>> - 1 or 2 GB DRAM > >>>>> - 8 or 16 GB eMMC flash > >>>>> - 100 MBit Ethernet port (using an X-Powers AC200 PHY) > >>>>> - RTL8723BS WiFi & Bluetooth chip > >>>>> - HDMI port > >>>>> - two USB 2.0 ports > >>>>> - 3.5mm AV port > >>>>> - microSD card slot > >>>>> > >>>>> The devicetree covers most peripherals, though there is no agreed > >>>>> binding for the PHY chip yet, so this is left out. > >>>>> > >>>>> Signed-off-by: Andre Przywara > >>>>> --- > >>>>> arch/arm64/boot/dts/allwinner/Makefile | 1 + > >>>>> .../allwinner/sun50i-h64-remix-mini-pc.dts | 357 ++++++++++++= ++++++ > >>>>> 2 files changed, 358 insertions(+) > >>>>> create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h64-remi= x-mini-pc.dts > >>>>> > >>>>> diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/bo= ot/dts/allwinner/Makefile > >>>>> index 91d505b385de..2db3b15ad09f 100644 > >>>>> --- a/arch/arm64/boot/dts/allwinner/Makefile > >>>>> +++ b/arch/arm64/boot/dts/allwinner/Makefile > >>>>> @@ -16,6 +16,7 @@ dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-pinetab.= dtb > >>>>> dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-pinetab-early-adopter.d= tb > >>>>> dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-sopine-baseboard.dtb > >>>>> dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-teres-i.dtb > >>>>> +dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-h64-remix-mini-pc.dtb > >>>>> dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a100-allwinner-perf1.dtb > >>>>> dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-h5-bananapi-m2-plus.dtb > >>>>> dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-h5-bananapi-m2-plus-v1.2.dtb > >>>>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h64-remix-mini-pc= =2Edts b/arch/arm64/boot/dts/allwinner/sun50i-h64-remix-mini-pc.dts > >>>>> new file mode 100644 > >>>>> index 000000000000..537923a541a8 > >>>>> --- /dev/null > >>>>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h64-remix-mini-pc.dts > >>>>> @@ -0,0 +1,357 @@ > >>>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > >>>>> +// Copyright (c) 2018 ARM Ltd. > >>>> > >>>> Shouldn't be 2024? > >> > >> Well, that just documents that sad fact that I indeed created this file > >> 6 years ago, but just managed now to actually send this. Is there a > >> requirement for this being "recent"? > >=20 > > Not really, but it's strange looking. Some might incorrectly assume tha= t it's > > present in the kernel longer than it really is. >=20 > OK, I will put in 2023, as this is when I touched this again. >=20 > >>>> > >>>>> + > >>>>> +/dts-v1/; > >>>>> + > >>>>> +#include "sun50i-a64.dtsi" > >>>>> +#include "sun50i-a64-cpu-opp.dtsi" > >>>>> + > >>>>> +#include > >>>>> + > >>>>> +/ { > >>>>> + model =3D "Remix Mini PC"; > >>>>> + compatible =3D "jide,remix-mini-pc", "allwinner,sun50i-h64", > >>>>> + "allwinner,sun50i-a64"; > >>>>> + > >>>>> + aliases { > >>>>> + ethernet1 =3D &rtl8723bs; > >>>>> + serial0 =3D &uart0; > >>>>> + }; > >>>>> + > >>>>> + chosen { > >>>>> + stdout-path =3D "serial0:115200n8"; > >>>>> + }; > >>>>> + > >>>>> + hdmi-connector { > >>>>> + compatible =3D "hdmi-connector"; > >>>>> + type =3D "a"; > >>>>> + > >>>>> + port { > >>>>> + hdmi_con_in: endpoint { > >>>>> + remote-endpoint =3D <&hdmi_out_con>; > >>>>> + }; > >>>>> + }; > >>>>> + }; > >>>>> + > >>>>> + reg_vcc5v: regulator-5v { > >>>>> + /* board wide 5V supply directly from the DC input */ > >>>>> + compatible =3D "regulator-fixed"; > >>>>> + regulator-name =3D "vcc-5v"; > >>>>> + regulator-min-microvolt =3D <5000000>; > >>>>> + regulator-max-microvolt =3D <5000000>; > >>>>> + regulator-always-on; > >>>>> + }; > >>>>> + > >>>>> + wifi_pwrseq: wifi_pwrseq { > >>>>> + compatible =3D "mmc-pwrseq-simple"; > >>>>> + pinctrl-names =3D "default"; > >>>>> + reset-gpios =3D <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */ > >>>>> + post-power-on-delay-ms =3D <200>; > >>>>> + }; > >>>>> +}; > >>>>> + > >>>>> +&codec { > >>>>> + status =3D "okay"; > >>>>> +}; > >>>>> + > >>>>> +&codec_analog { > >>>>> + cpvdd-supply =3D <®_eldo1>; > >>>>> + status =3D "okay"; > >>>>> +}; > >>>>> + > >>>>> +&cpu0 { > >>>>> + cpu-supply =3D <®_dcdc2>; > >>>>> +}; > >>>>> + > >>>>> +&cpu1 { > >>>>> + cpu-supply =3D <®_dcdc2>; > >>>>> +}; > >>>>> + > >>>>> +&cpu2 { > >>>>> + cpu-supply =3D <®_dcdc2>; > >>>>> +}; > >>>>> + > >>>>> +&cpu3 { > >>>>> + cpu-supply =3D <®_dcdc2>; > >>>>> +}; > >>>>> + > >>>>> +&dai { > >>>>> + status =3D "okay"; > >>>>> +}; > >>>>> + > >>>>> +&de { > >>>>> + status =3D "okay"; > >>>>> +}; > >>>>> + > >>>>> +&ehci0 { > >>>>> + status =3D "okay"; > >>>>> +}; > >>>>> + > >>>>> +&ehci1 { > >>>>> + status =3D "okay"; > >>>>> +}; > >>>>> + > >>>>> +&hdmi { > >>>>> + hvcc-supply =3D <®_dldo1>; > >>>>> + status =3D "okay"; > >>>>> +}; > >>>>> + > >>>>> +&hdmi_out { > >>>>> + hdmi_out_con: endpoint { > >>>>> + remote-endpoint =3D <&hdmi_con_in>; > >>>>> + }; > >>>>> +}; > >>>>> + > >>>>> +/* Connects to the AC200 chip */ > >>>>> +&i2c0 { > >>>>> + pinctrl-names =3D "default"; > >>>>> + pinctrl-0 =3D <&i2c0_pins>; > >>>>> + status =3D "okay"; > >>>>> +}; > >>>>> + > >>>>> +&i2c0_pins { > >>>>> + bias-pull-up; > >>>>> +}; > >>>>> + > >>>>> +&mmc0 { > >>>>> + pinctrl-names =3D "default"; > >>>>> + pinctrl-0 =3D <&mmc0_pins>; > >>>>> + vmmc-supply =3D <®_dcdc1>; > >>>>> + cd-gpios =3D <&pio 5 6 GPIO_ACTIVE_LOW>; > >>>>> + disable-wp; > >>>>> + bus-width =3D <4>; > >>>>> + status =3D "okay"; > >>>>> +}; > >>>>> + > >>>>> +&mmc1 { > >>>>> + pinctrl-names =3D "default"; > >>>>> + pinctrl-0 =3D <&mmc1_pins>; > >>>>> + vmmc-supply =3D <®_aldo1>; > >>>>> + vqmmc-supply =3D <®_dldo4>; > >>>>> + mmc-pwrseq =3D <&wifi_pwrseq>; > >>>>> + bus-width =3D <4>; > >>>>> + non-removable; > >>>>> + status =3D "okay"; > >>>>> + > >>>>> + rtl8723bs: wifi@1 { > >>>>> + reg =3D <1>; > >>>>> + interrupt-parent =3D <&r_pio>; > >>>>> + interrupts =3D <0 3 IRQ_TYPE_LEVEL_LOW>; /* PL3 */ > >>>>> + interrupt-names =3D "host-wake"; > >>>>> + }; > >>>> > >>>> Node without compatible doesn't help. Please remove it. > >> > >> Huh, but where do I put the the IRQ line then? And every other RTL8723= BS > >> user seems to do the same? > >=20 > > It's good, sorry for the noise. >=20 > Just for the records, and for my own reference: > Since there is no "ranges" property in the MMC node, the Linux platform=20 > bus driver is not automatically traversing any child nodes. So we don't=20 > need a compatible string. Instead it's a new addressing scheme (this=20 > obsolete MMC "bus" address, like SPI or I2C), so it's up to the driver=20 > to do the child iteration. And it will match device #1 to reg <1>, and=20 > use that node, as Chen-Yu mentioned. >=20 > >>>> > >>>>> +}; > >>>>> + > >>>>> +&mmc2 { > >>>>> + pinctrl-names =3D "default"; > >>>>> + pinctrl-0 =3D <&mmc2_pins>, <&mmc2_ds_pin>; > >>>>> + vmmc-supply =3D <®_dcdc1>; > >>>>> + vqmmc-supply =3D <®_eldo1>; > >>>>> + bus-width =3D <8>; > >>>>> + non-removable; > >>>>> + mmc-ddr-1_8v; > >>>>> + mmc-hs200-1_8v; > >>>> > >>>> Aren't these speed modes enabled by default? > >> > >> Enabled by who? Our current sunxi-mmc driver? I cannot find anything in > >> the binding that suggests that there would be some default settings. > >=20 > > Looking at Linux sunxi mmc driver, mmc-ddr-1_8v is enabled by default f= or > > "new timings" variants except for H5. Anyway... >=20 > But this is a Linux implementation detail, which we should not rely on=20 > in a DT? And if I remember Maxime correctly back then, the plan was to=20 > avoid those driver hacks and just say what we support in the DT, going=20 > forward. This might be needed for other OSes, which might not support=20 > HS-200? > >>> Sorry, mmc-hs200-1_8v is ok, but mmc-ddr-1_8v should be > >>> removed. > >> > >> Mmh, I am confused: I thought after the H5 eMMC mishap we figured that > >> all speed modes supported by the eMMC chip should be listed in the DT? > >=20 > > I think H5 just has (had?) driver issue. From what I can see, only high= est > > supported mode by kernel and chip is specified in all Allwinner DTs. > > mmc-ddr-1_8v is only specified by two recent board addition, where I mi= ssed > > it while reviewing. > >=20 > >> So any driver wouldn't need to make assumptions, and if a particular > >> mode shows problems on a board, we just remove that mode from the DT. > >> Actually, thinking about that, I guess I should list HS-400 as well? T= he > >> BSP kernel uses that mode. > >=20 > > Sure, but it also calibrates timing for it. If you'll specify HS400, ke= rnel > > will try to use it, but it won't work. >=20 > But this is also a limitation of the current Linux kernel driver. And=20 > since we indeed don't support HS-400, we explicitly remove it from the=20 > capability list, *after* the call to mmc_of_parse(): >=20 > drivers/mmc/host/sunxi-mmc.c:1460 > /* TODO: This driver doesn't support HS400 mode yet */ > mmc->caps2 &=3D ~MMC_CAP2_HS400; >=20 > So I think this should be safe? Right. Can you test it? Best regards, Jernej >=20 > Cheers, > Andre >=20 > >=20 > >> Or do you mean to say that in particular DDR (@1.8V) is problematic? I > >> cannot test at the moment, but could try later to force that mode. > >=20 > > No, no need. > >=20 > > Best regards, > > Jernej > >=20 > >> > >> Cheers, > >> Andre > >> > >> > >>>>> + cap-mmc-hw-reset; > >>>>> + status =3D "okay"; > >>>>> +}; > >>>>> + > >>>>> +&ohci0 { > >>>>> + status =3D "okay"; > >>>>> +}; > >>>>> + > >>>>> +&ohci1 { > >>>>> + status =3D "okay"; > >>>>> +}; > >>>>> + > >>>>> +&pio { > >>>>> + vcc-pb-supply =3D <®_dcdc1>; > >>>>> + vcc-pc-supply =3D <®_dcdc1>; > >>>>> + vcc-pd-supply =3D <®_dcdc1>; > >>>>> + vcc-pe-supply =3D <®_dcdc1>; > >>>>> + vcc-pf-supply =3D <®_dcdc1>; > >>>>> + vcc-pg-supply =3D <®_dldo4>; > >>>>> + vcc-ph-supply =3D <®_dcdc1>; > >>>>> +}; > >>>>> + > >>>>> +&r_ir { > >>>>> + status =3D "okay"; > >>>>> +}; > >>>>> + > >>>>> +&r_pio { > >>>>> + /* > >>>>> + * We cannot add that supply for now since it would create a circ= ular > >>>>> + * dependency between pinctrl, the regulator and the RSB Bus. > >>>>> + * > >>>>> + * vcc-pl-supply =3D <®_aldo2>; > >>>>> + */ > >>>>> +}; > >>>>> + > >>>>> +&r_rsb { > >>>>> + status =3D "okay"; > >>>>> + > >>>>> + axp803: pmic@3a3 { > >>>>> + compatible =3D "x-powers,axp803"; > >>>>> + reg =3D <0x3a3>; > >>>>> + interrupt-parent =3D <&r_intc>; > >>>>> + interrupts =3D ; > >>>>> + x-powers,drive-vbus-en; > >>>>> + > >>>>> + vin1-supply =3D <®_vcc5v>; > >>>>> + vin2-supply =3D <®_vcc5v>; > >>>>> + vin3-supply =3D <®_vcc5v>; > >>>>> + vin5-supply =3D <®_vcc5v>; > >>>>> + vin6-supply =3D <®_vcc5v>; > >>>>> + aldoin-supply =3D <®_vcc5v>; > >>>>> + dldoin-supply =3D <®_vcc5v>; > >>>>> + eldoin-supply =3D <®_vcc5v>; > >>>>> + fldoin-supply =3D <®_vcc5v>; > >>>>> + drivevbus-supply =3D <®_vcc5v>; > >>>>> + ips-supply =3D <®_vcc5v>; > >>>>> + > >>>>> + status =3D "okay"; > >>>>> + }; > >>>>> +}; > >>>>> + > >>>>> +#include "axp803.dtsi" > >>>>> + > >>>>> +&ac_power_supply { > >>>>> + status =3D "okay"; > >>>>> +}; > >>>>> + > >>>>> +®_dcdc1 { > >>>>> + regulator-always-on; > >>>>> + regulator-min-microvolt =3D <3300000>; > >>>>> + regulator-max-microvolt =3D <3300000>; > >>>>> + regulator-name =3D "vcc-3v3"; > >>>>> +}; > >>>>> + > >>>>> +®_dcdc2 { > >>>>> + regulator-always-on; > >>>>> + regulator-min-microvolt =3D <1040000>; > >>>>> + regulator-max-microvolt =3D <1300000>; > >>>>> + regulator-name =3D "vdd-cpux"; > >>>>> +}; > >>>>> + > >>>>> +/* DCDC3 is polyphased with DCDC2 */ > >>>>> + > >>>>> +®_dcdc5 { > >>>>> + regulator-always-on; > >>>>> + regulator-min-microvolt =3D <1500000>; > >>>>> + regulator-max-microvolt =3D <1500000>; > >>>>> + regulator-name =3D "vcc-dram"; > >>>>> +}; > >>>>> + > >>>>> +/* Deviates from the reset default of 1.1V. */ > >>>>> +®_dcdc6 { > >>>>> + regulator-always-on; > >>>>> + regulator-min-microvolt =3D <1200000>; > >>>>> + regulator-max-microvolt =3D <1200000>; > >>>>> + regulator-name =3D "vdd-sys"; > >>>>> +}; > >>>>> + > >>>>> +®_aldo1 { > >>>>> + regulator-min-microvolt =3D <3300000>; > >>>>> + regulator-max-microvolt =3D <3300000>; > >>>>> + regulator-name =3D "vcc-wifi"; > >>>>> +}; > >>>>> + > >>>>> +®_aldo2 { > >>>>> + /* Specifying R_PIO consumer would create circular dependency. */ > >>>>> + regulator-always-on; > >>>>> + regulator-min-microvolt =3D <3300000>; > >>>>> + regulator-max-microvolt =3D <3300000>; > >>>>> + regulator-name =3D "vcc-pl"; > >>>>> +}; > >>>>> + > >>>>> +®_aldo3 { > >>>>> + regulator-always-on; > >>>>> + regulator-min-microvolt =3D <3000000>; > >>>>> + regulator-max-microvolt =3D <3000000>; > >>>>> + regulator-name =3D "vcc-pll-avcc"; > >>>>> +}; > >>>>> + > >>>>> +/* AC200 power supply */ > >>>>> +®_dldo1 { > >>>>> + regulator-always-on; > >>>>> + regulator-min-microvolt =3D <3300000>; > >>>>> + regulator-max-microvolt =3D <3300000>; > >>>>> + regulator-name =3D "vcc-ave-33"; > >>>>> +}; > >>>>> + > >>>>> +®_dldo4 { > >>>>> + regulator-min-microvolt =3D <3300000>; > >>>>> + regulator-max-microvolt =3D <3300000>; > >>>>> + regulator-name =3D "vcc-wifi-io"; > >>>>> +}; > >>>>> + > >>>>> +®_drivevbus { > >>>>> + regulator-name =3D "usb0-vbus"; > >>>>> + status =3D "okay"; > >>>>> +}; > >>>>> + > >>>>> +®_eldo1 { > >>>>> + regulator-always-on; > >>>>> + regulator-min-microvolt =3D <1800000>; > >>>>> + regulator-max-microvolt =3D <1800000>; > >>>>> + regulator-name =3D "vcc-cpvdd-dram-emmc"; > >>>>> +}; > >>>>> + > >>>>> +/* Supplies the arisc management core, needed by TF-A to power off= cores. */ > >>>>> +®_fldo2 { > >>>>> + regulator-always-on; > >>>>> + regulator-min-microvolt =3D <1100000>; > >>>>> + regulator-max-microvolt =3D <1100000>; > >>>>> + regulator-name =3D "vdd-cpus"; > >>>>> +}; > >>>>> + > >>>>> +®_rtc_ldo { > >>>>> + regulator-name =3D "vcc-rtc"; > >>>>> +}; > >>>>> + > >>>>> +&simplefb_hdmi { > >>>>> + vcc-hdmi-supply =3D <®_dcdc1>; > >>>>> +}; > >>>>> + > >>>>> +&sound { > >>>>> + simple-audio-card,aux-devs =3D <&codec_analog>; > >>>>> + simple-audio-card,widgets =3D "Microphone", "Microphone Jack", > >>>>> + "Headphone", "Headphone Jack"; > >>>>> + simple-audio-card,routing =3D > >>>>> + "Left DAC", "DACL", > >>>>> + "Right DAC", "DACR", > >>>>> + "Headphone Jack", "HP", > >>>>> + "ADCL", "Left ADC", > >>>>> + "ADCR", "Right ADC", > >>>>> + "MIC2", "Microphone Jack"; > >>>>> + status =3D "okay"; > >>>>> +}; > >>>>> + > >>>>> +/* On the (unpopulated) UART pads. */ > >>>>> +&uart0 { > >>>>> + pinctrl-names =3D "default"; > >>>>> + pinctrl-0 =3D <&uart0_pb_pins>; > >>>>> + status =3D "okay"; > >>>>> +}; > >>>>> + > >>>>> +&uart1 { > >>>>> + pinctrl-names =3D "default"; > >>>>> + pinctrl-0 =3D <&uart1_pins>, <&uart1_rts_cts_pins>; > >>>>> + uart-has-rtscts; > >>>>> + status =3D "okay"; > >>>>> + > >>>>> + bluetooth { > >>>>> + compatible =3D "realtek,rtl8723bs-bt"; > >>>>> + enable-gpios =3D <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */ > >>>>> + max-speed =3D <1500000>; > >>>>> + }; > >>>>> +}; > >>>>> + > >>>>> +&usb_otg { > >>>>> + dr_mode =3D "host"; > >>>>> + status =3D "okay"; > >>>>> +}; > >>>>> + > >>>>> +&usbphy { > >>>>> + usb0_vbus-supply =3D <®_drivevbus>; > >>>>> + usb1_vbus-supply =3D <®_drivevbus>; > >>>>> + status =3D "okay"; > >>>>> +}; > >>>>> > >>>> > >>>> > >>>> > >>>> > >>>> > >>> > >>> > >>> > >>> > >> > >=20 > >=20 > >=20 > >=20 >=20