From: Krzysztof Kozlowski <krzk@kernel.org>
To: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
Cc: ath12k@lists.infradead.org, linux-wireless@vger.kernel.org,
Kalle Valo <kvalo@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jeff Johnson <jjohnson@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 01/13] dt-bindings: net: wireless: describe the ath12k AHB module
Date: Thu, 30 Jan 2025 09:40:44 +0100 [thread overview]
Message-ID: <104e6b6f-3c1e-4a00-8822-aa6fb4562411@kernel.org> (raw)
In-Reply-To: <20250130-cunning-quail-of-opportunity-76d0ad@krzk-bin>
On 30/01/2025 09:28, Krzysztof Kozlowski wrote:
> On Thu, Jan 30, 2025 at 10:04:56AM +0530, Raj Kumar Bhagat wrote:
>> Add device-tree bindings for the ATH12K module found in the IPQ5332
>> device.
>>
>> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
>> ---
>> .../net/wireless/qcom,ath12k-ahb.yaml | 319 ++++++++++++++++++
>> 1 file changed, 319 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-ahb.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-ahb.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-ahb.yaml
>> new file mode 100644
>> index 000000000000..bd953a028dc3
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-ahb.yaml
>
> Filename should match compatible. This binding does not look like
> supporting more devices, so there is no much benefit calling it by generic name.
I saw now your other patchset, so you have here two devices, but I still
do not understand why this cannot follow standard naming practice like
most bindings supporting one or more devices. Like every review we give.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-30 8:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 4:34 [PATCH v5 00/13] wifi: ath12k: add Ath12k AHB driver support for IPQ5332 Raj Kumar Bhagat
2025-01-30 4:34 ` [PATCH v5 01/13] dt-bindings: net: wireless: describe the ath12k AHB module Raj Kumar Bhagat
2025-01-30 8:28 ` Krzysztof Kozlowski
2025-01-30 8:40 ` Krzysztof Kozlowski [this message]
2025-02-03 8:43 ` Raj Kumar Bhagat
2025-02-03 10:05 ` Krzysztof Kozlowski
2025-02-03 10:27 ` Raj Kumar Bhagat
2025-02-03 9:05 ` Raj Kumar Bhagat
2025-02-03 10:09 ` Krzysztof Kozlowski
2025-02-04 5:57 ` Raj Kumar Bhagat
2025-02-04 7:30 ` Krzysztof Kozlowski
2025-01-30 19:07 ` Jeff Johnson
2025-02-03 9:07 ` Raj Kumar Bhagat
2025-01-30 4:34 ` [PATCH v5 02/13] wifi: ath12k: fix incorrect CE addresses Raj Kumar Bhagat
2025-01-30 4:34 ` [PATCH v5 03/13] wifi: ath12k: refactor ath12k_hw_regs structure Raj Kumar Bhagat
2025-01-30 4:34 ` [PATCH v5 04/13] wifi: ath12k: add ath12k_hw_params for IPQ5332 Raj Kumar Bhagat
2025-01-30 4:35 ` [PATCH v5 05/13] wifi: ath12k: avoid m3 firmware download in AHB device IPQ5332 Raj Kumar Bhagat
2025-01-30 4:35 ` [PATCH v5 06/13] wifi: ath12k: Add hw_params to remap CE register space for IPQ5332 Raj Kumar Bhagat
2025-01-30 4:35 ` [PATCH v5 07/13] wifi: ath12k: add support for fixed QMI firmware memory Raj Kumar Bhagat
2025-01-30 7:46 ` Krzysztof Kozlowski
2025-02-03 9:44 ` Raj Kumar Bhagat
2025-02-03 10:12 ` Krzysztof Kozlowski
2025-02-04 9:06 ` Raj Kumar Bhagat
2025-02-05 9:07 ` Krzysztof Kozlowski
2025-02-05 9:59 ` Raj Kumar Bhagat
2025-01-30 4:35 ` [PATCH v5 08/13] wifi: ath12k: add AHB driver support for IPQ5332 Raj Kumar Bhagat
2025-01-30 7:57 ` Krzysztof Kozlowski
2025-02-04 15:45 ` Raj Kumar Bhagat
2025-01-30 4:35 ` [PATCH v5 09/13] wifi: ath12k: Power up root PD Raj Kumar Bhagat
2025-01-30 7:58 ` Krzysztof Kozlowski
2025-02-04 16:16 ` Raj Kumar Bhagat
2025-01-30 4:35 ` [PATCH v5 10/13] wifi: ath12k: Register various userPD interrupts and save SMEM entries Raj Kumar Bhagat
2025-01-30 4:35 ` [PATCH v5 11/13] wifi: ath12k: Power up userPD Raj Kumar Bhagat
2025-01-30 4:35 ` [PATCH v5 12/13] wifi: ath12k: Power down userPD Raj Kumar Bhagat
2025-01-30 4:35 ` [PATCH v5 13/13] wifi: ath12k: enable ath12k AHB support Raj Kumar Bhagat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=104e6b6f-3c1e-4a00-8822-aa6fb4562411@kernel.org \
--to=krzk@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jjohnson@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_rajkbhag@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).