From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Vinod Koul <vinod.koul@intel.com>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
device-tree <devicetree-discuss@lists.ozlabs.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
zhangfei gao <zhangfei.gao@gmail.com>
Subject: Re: [PATCH] dmaengine: Add hisilicon k3 DMA engine driver
Date: Mon, 24 Jun 2013 18:15:57 +0200 [thread overview]
Message-ID: <10541174.SUr9yD0veu@wuerfel> (raw)
In-Reply-To: <CAMj5Bkg_4G9n9BaQjA-Xj2p8jGO8PZxNW7E7jOeWMMZa5sH6yQ@mail.gmail.com>
On Monday 24 June 2013 16:49:08 zhangfei gao wrote:
>
> Dear Arnd & Vinod
>
> The suggestion of using dma_get_slave_channel instead of filter works here.
> Dma driver should modify accordingly.
The changes all look good to me, thanks a lot for following up!
However, you should really follow the procedure for posting patches even
if it's just for the sake of discussion:
* always provide a signed-off-by and a patch description
* use an email client that doesn't break whitespace
* I would have split this up into two separate patches, one for the
subsystem and one for the new driver.
Arnd
next prev parent reply other threads:[~2013-06-24 16:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 4:54 [PATCH] dmaengine: Add hisilicon k3 DMA engine driver Zhangfei Gao
[not found] ` <1371444872-26994-1-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-06-17 20:58 ` Arnd Bergmann
2013-06-18 2:33 ` zhangfei gao
2013-06-18 14:09 ` Arnd Bergmann
2013-06-18 14:22 ` zhangfei
[not found] ` <51C06D19.3020304-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-06-18 15:08 ` Arnd Bergmann
2013-06-21 10:49 ` Vinod Koul
[not found] ` <201306181609.14966.arnd-r2nGTMty4D4@public.gmane.org>
2013-06-21 10:45 ` Vinod Koul
[not found] ` <201306172258.08185.arnd-r2nGTMty4D4@public.gmane.org>
2013-06-21 10:43 ` Vinod Koul
[not found] ` <20130621104355.GG23141-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-06-21 11:41 ` Arnd Bergmann
2013-06-24 8:49 ` zhangfei gao
2013-06-24 16:15 ` Arnd Bergmann [this message]
2013-06-25 5:34 ` zhangfei gao
2013-06-21 10:40 ` Vinod Koul
2013-06-25 5:34 ` zhangfei gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10541174.SUr9yD0veu@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=vinod.koul@intel.com \
--cc=zhangfei.gao@gmail.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).