devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Vikash Garodia <quic_vgarodia@quicinc.com>,
	Dmitry Baryshkov <lumag@kernel.org>
Cc: Dikshita Agarwal <quic_dikshita@quicinc.com>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: media: qcom,sm8550-iris: update power domain name
Date: Tue, 11 Mar 2025 17:24:16 +0100	[thread overview]
Message-ID: <10564e08-f8fb-4db6-b613-d01bc2a62899@oss.qualcomm.com> (raw)
In-Reply-To: <c0430086-675d-b58c-4ef9-1bd9ee51d3db@quicinc.com>

On 3/11/25 4:11 PM, Vikash Garodia wrote:
> 
> On 3/11/2025 8:37 PM, Dmitry Baryshkov wrote:
>> On Tue, Mar 11, 2025 at 05:33:53PM +0530, Vikash Garodia wrote:
>>> Not all platforms has a collapsible mx, so use the more generic naming
>>> of mx in the binding.
>>
>> I guess, it wasn't even tested...
> Not sure what made you guess so, let me check why my binding checker did not
> catch the bot reported warning.

You probably checked the compiled DTBs (make dtbs_check / CHECK_DTBS=1), but you
also need to test the YAML (make dt_binding_check)

This change can't be accepted as-is, because there are already expectations
about the naming (and order) of the entries.

Because there's a difference, you would normally be expected to add a whole new
list, but maybe the dt-bindings maintainers will agree to Dmitry's solution of
adding a sneaky enum inside the list

Konrad

  parent reply	other threads:[~2025-03-11 16:24 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-11 12:03 [PATCH 0/4] media: qcom: iris: add support for SA8775P Vikash Garodia
2025-03-11 12:03 ` [PATCH 1/4] dt-bindings: media: qcom,sm8550-iris: update power domain name Vikash Garodia
2025-03-11 14:52   ` Rob Herring (Arm)
2025-03-11 15:07   ` Dmitry Baryshkov
2025-03-11 15:11     ` Vikash Garodia
2025-03-11 15:35       ` Dmitry Baryshkov
2025-03-11 19:19         ` Vikash Garodia
2025-03-11 22:13           ` Dmitry Baryshkov
2025-03-11 16:24       ` Konrad Dybcio [this message]
2025-03-11 17:33   ` Krzysztof Kozlowski
2025-03-11 17:47     ` Vikash Garodia
2025-03-12  8:44       ` Krzysztof Kozlowski
2025-03-12 12:55         ` Vikash Garodia
2025-03-11 12:03 ` [PATCH 2/4] dt-bindings: media: qcom,sm8550-iris: document SA8775p IRIS accelerator Vikash Garodia
2025-03-11 15:31   ` Dmitry Baryshkov
2025-03-12  8:07     ` Vikash Garodia
2025-03-12  8:51       ` Dmitry Baryshkov
2025-03-11 17:35   ` Krzysztof Kozlowski
2025-03-11 17:57     ` Vikash Garodia
2025-03-12  8:42       ` Krzysztof Kozlowski
2025-03-11 12:03 ` [PATCH 3/4] arm64: dts: qcom: sa8775p: add support for video node Vikash Garodia
2025-03-15 13:43   ` Konrad Dybcio
2025-03-15 14:04     ` Konrad Dybcio
2025-03-15 18:32     ` Dmitry Baryshkov
2025-03-17  6:00       ` Vikash Garodia
2025-03-17 11:29         ` Dmitry Baryshkov
2025-03-18 14:24     ` Vikash Garodia
2025-03-18 14:33       ` Konrad Dybcio
2025-03-18 15:38         ` Vikash Garodia
2025-03-17 11:31   ` Dmitry Baryshkov
2025-03-18 12:22     ` Konrad Dybcio
2025-03-18 13:43       ` Vikash Garodia
2025-03-11 12:03 ` [PATCH 4/4] media: iris: add compatible string for sa8775p Vikash Garodia
2025-03-11 15:32   ` Dmitry Baryshkov
2025-03-11 17:34   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10564e08-f8fb-4db6-b613-d01bc2a62899@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_dikshita@quicinc.com \
    --cc=quic_vgarodia@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).