From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63CE114B06C; Thu, 18 Sep 2025 17:31:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758216680; cv=none; b=kI99klyZJhIkIiyZ8bLjNkAJx4yJe2XC7cjVkfkOvvc+ECfVHNtI8vRqOeL3dHYknTQWR5NyDFvITEu0/UZn7eCu78DIr9tMXK8z5FxP548RhRfBWFEyd8MUHaLrt6qLMtF5eemM7ysylVpy9SElt+F426YByZ1NzyTAdAsvcjc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758216680; c=relaxed/simple; bh=MJyrprIjQP976NNdfWnB194ny7T1wyJGkK9xEmH6yY8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TibBK1nAVYLLNwzUcnEUhJxxI+EL27L0p84esa2UnbueAgeryimOSBrht+yv/MyAyPeLmq27qM0tQjHjW3hqlMxDo74ryYIApzNaV3bsG9CRRXwxYl+sM9nhn5x+Ox2b2Rp3W/CT4lQ2qayQrgp2RF5co2fmIbaPCdz9MW8cyGY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=eO6eaCxD; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="eO6eaCxD" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=yReL3BW5cNgeOoU+ct6Z0+QfxkhYi0zLxLWspzmRmBU=; b=eO6eaCxDj6t7fnCop9QAYLYJgH 59X7aMuS9JsaTAGxG7jM2PogXRFDOxYTBU0EHDKvoxfG31wmQDx/aTI2pKuqulDdPEgJthfghaKeb oDk9ZUzmBfJYRnAZ2iuE9+OyJnJHuYDS+SpstpkdeDwvln/C++hD6c3udYOu9/aWsagBPM0eotUl/ sTVL4naZ5rlJdwaRQEixAQe5kFO9OuK/NLeKJIlOaDAxs3XV6HpgalP3DAoHVuLQpVEAxG/howhYn QH8jxLp+Etb+s3/d8+ccO+yTWQ1aXZrxGFmwFBznxC8TWo4wQPQBmTbsIuYMomj7Dxirrmpn9tOCY HYolQ8hg==; Received: from i53875b0a.versanet.de ([83.135.91.10] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uzITJ-0002Pr-Qb; Thu, 18 Sep 2025 19:31:05 +0200 From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Chukun Pan Cc: Chukun Pan , FUKAUMI Naoki , Conor Dooley , Krzysztof Kozlowski , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 1/3] arm64: dts: rockchip: disable display subsystem for Radxa E52C Date: Thu, 18 Sep 2025 19:31:05 +0200 Message-ID: <10594621.0AQdONaE2F@diego> In-Reply-To: <20250901100027.164594-2-amadeus@jmu.edu.cn> References: <20250901100027.164594-1-amadeus@jmu.edu.cn> <20250901100027.164594-2-amadeus@jmu.edu.cn> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Am Montag, 1. September 2025, 12:00:25 Mitteleurop=C3=A4ische Sommerzeit sc= hrieb Chukun Pan: > The Radxa E52C SBC do not have HDMI output, so disable > the display subsystem to avoid the following error log: >=20 > *ERROR* No available vop found for display-subsystem. >=20 > Fixes: 9be4171219b6 ("arm64: dts: rockchip: Add Radxa E52C") > Signed-off-by: Chukun Pan I'm torn on the approach vs. just removing the error line in the driver. Returning -ENODEV from rockchip_drm_platform_of_probe() is correct, but the error log could just be a debug one instead. Because running a system without active vops is obviously fine. Heiko > --- > arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/ar= m64/boot/dts/rockchip/rk3582-radxa-e52c.dts > index 48ddc43e2ab5..1883bd183396 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts > @@ -207,6 +207,10 @@ &cpu_l3 { > cpu-supply =3D <&vdd_cpu_lit_s0>; > }; > =20 > +&display_subsystem { > + status =3D "disabled"; > +}; > + > &i2c0 { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&i2c0m2_xfer>; >=20