From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Stanley Chang[昌育德]" <stanley_chang@realtek.com>,
"kernel test robot" <lkp@intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "oe-kbuild-all@lists.linux.dev" <oe-kbuild-all@lists.linux.dev>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Matthias Kaehlcke <mka@chromium.org>, Ray Chi <raychi@google.com>,
Flavio Suligoi <f.suligoi@asem.it>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v3 2/5] phy: realtek: usb: Add driver for the Realtek SoC USB 2.0 PHY
Date: Thu, 8 Jun 2023 08:55:28 +0200 [thread overview]
Message-ID: <1069d6fa-7b17-00de-ad0b-e91794fae9f2@kernel.org> (raw)
In-Reply-To: <2444f4875f484cc4bf2ff9c52815fa0c@realtek.com>
On 08/06/2023 04:18, Stanley Chang[昌育德] wrote:
>> ERROR: modpost: "devm_usb_get_phy_by_phandle"
>> [drivers/power/supply/wm831x_power.ko] undefined!
>>>> ERROR: modpost: "devm_usb_get_phy"
>> [drivers/power/supply/da9150-charger.ko] undefined!
>>
>> Kconfig warnings: (for reference only)
>> WARNING: unmet direct dependencies detected for USB_PHY
>> Depends on [n]: USB_SUPPORT [=n]
>> Selected by [y]:
>> - PHY_RTK_RTD_USB2PHY [=y]
>>
>
> I will add USB_SUUPRT dependency to Kconfig.
Why? Do you see other phy drivers needing it? Few have it but many
don't, so you should really investigate the root cause, not just add
some dependencies.
Build test your patches locally before sending and investigate the issues.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-08 6:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 6:24 [PATCH v3 1/5] usb: phy: add usb phy notify port status API Stanley Chang
2023-06-07 6:24 ` [PATCH v3 2/5] phy: realtek: usb: Add driver for the Realtek SoC USB 2.0 PHY Stanley Chang
2023-06-07 11:26 ` kernel test robot
2023-06-07 11:54 ` Krzysztof Kozlowski
2023-06-08 6:59 ` Stanley Chang[昌育德]
2023-06-08 7:00 ` Krzysztof Kozlowski
2023-06-08 7:15 ` Krzysztof Kozlowski
2023-06-07 17:31 ` kernel test robot
2023-06-08 2:18 ` Stanley Chang[昌育德]
2023-06-08 6:55 ` Krzysztof Kozlowski [this message]
2023-06-08 7:07 ` Stanley Chang[昌育德]
2023-06-07 6:24 ` [PATCH v3 3/5] phy: realtek: usb: Add driver for the Realtek SoC USB 3.0 PHY Stanley Chang
2023-06-07 11:52 ` Krzysztof Kozlowski
2023-06-08 6:59 ` Stanley Chang[昌育德]
2023-06-08 7:21 ` Krzysztof Kozlowski
2023-06-08 7:40 ` Stanley Chang[昌育德]
2023-06-08 1:35 ` kernel test robot
2023-06-08 2:18 ` Stanley Chang[昌育德]
2023-06-07 6:24 ` [PATCH v3 4/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 2.0 PHY Stanley Chang
2023-06-07 12:04 ` Krzysztof Kozlowski
2023-06-08 7:24 ` Stanley Chang[昌育德]
2023-06-08 7:49 ` Krzysztof Kozlowski
2023-06-08 8:21 ` Stanley Chang[昌育德]
2023-06-08 8:28 ` Krzysztof Kozlowski
2023-06-08 9:27 ` Stanley Chang[昌育德]
2023-06-08 7:47 ` Stanley Chang[昌育德]
2023-06-08 7:51 ` Krzysztof Kozlowski
2023-06-08 8:01 ` Stanley Chang[昌育德]
2023-06-07 6:24 ` [PATCH v3 5/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 3.0 PHY Stanley Chang
2023-06-07 12:08 ` Krzysztof Kozlowski
2023-06-08 7:32 ` Stanley Chang[昌育德]
2023-06-08 7:50 ` Krzysztof Kozlowski
2023-06-08 8:00 ` Stanley Chang[昌育德]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1069d6fa-7b17-00de-ad0b-e91794fae9f2@kernel.org \
--to=krzk@kernel.org \
--cc=bagasdotme@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=f.suligoi@asem.it \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=m.grzeschik@pengutronix.de \
--cc=mathias.nyman@linux.intel.com \
--cc=mka@chromium.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=raychi@google.com \
--cc=robh+dt@kernel.org \
--cc=stanley_chang@realtek.com \
--cc=stern@rowland.harvard.edu \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).