From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15809C4332F for ; Fri, 23 Dec 2022 11:07:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236095AbiLWLHF (ORCPT ); Fri, 23 Dec 2022 06:07:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229506AbiLWLHD (ORCPT ); Fri, 23 Dec 2022 06:07:03 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CAFF3B40C for ; Fri, 23 Dec 2022 03:07:01 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id g13so6681072lfv.7 for ; Fri, 23 Dec 2022 03:07:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/hMsumwP6KT2UUsGNA6AWGptXKAy5xS1cl3T0zVPx0k=; b=HJDOnXZy6oV7VlYeiWa5i593GbfluXa8NJ9ZMW0y3hQjI3oD/hX3sWxM5VylTJ7NrW K5+EBpnqltpOFjqy7Q7+LqOQ3VqZ/w7MWTSWrtXKoWUq/cDpHnARxs8Uv1wrAggY5fZW 0wd/9wHzMU7sba7o45yGLFFCk169BUU153qyrM2CwuYn3GVFI6Us2CVnJ06v1hEHMb5z n5Wxc5lOfoEdMmtuN/FWh33xFSI0oAk2i8jN21x55VOH3v3rjw4I95dnkJAMliXvTm5d tKYcul2403olv7t1rK/bx2e8pgJzy95YzexHV0nmXNDM6CBHRiCUrCLY1vzLeiz9MQWe UlpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/hMsumwP6KT2UUsGNA6AWGptXKAy5xS1cl3T0zVPx0k=; b=ln0j3Y1C4w/Fze+xudP1/TSGyZTSkAGI+Byr09XdEEoPLES+eqwkHj9BkpuhDW7GMZ 3dNqlt/X8ml6QxSnYAI8BIN3/SGox/HcQCU99Z3rvWZSCekb0toLv9jp7Rtmo7FwKIvP yERpD3IluSOCYnnP+c9C2AlB0jo3QV6KNJ9svVCOdhiWOtefVT6GN6Vn7MF5RM7QpNKA tjBN9AeEBGKnqF7lrIe3hEAqGgYTHGHlCeJRqxaiM/pUbIZbMgbhbGMxs5uorzTN9iHA 4vMw5ULnjGhFN7THQYOIoFFAgFfwdYKKhbX7Ip0XCfgsmxmgmbsDhwg0HrCt+jW4asnG y1iA== X-Gm-Message-State: AFqh2kqLI4JM+REDu2NLkt9kdFzlkOJhvPkYN81qB2igIa3RTp0NeAve djM3x9z85GM4av6whRo763y1kQ== X-Google-Smtp-Source: AMrXdXuiXxUqsVNqsObnU18wuXFBsbf9EZVBefCEZpE/VJxhS6U9Xl25fzkp53euOGSKLfCyH3rPfg== X-Received: by 2002:a05:6512:602:b0:4c4:6a8e:30 with SMTP id b2-20020a056512060200b004c46a8e0030mr2558660lfe.30.1671793619322; Fri, 23 Dec 2022 03:06:59 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id y11-20020a19750b000000b004b4b0a68f67sm478401lfe.185.2022.12.23.03.06.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Dec 2022 03:06:58 -0800 (PST) Message-ID: <10750c3f-016d-905d-9c04-e41cd9248dd4@linaro.org> Date: Fri, 23 Dec 2022 12:06:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 1/2] dt-bindings: usb: snps,dwc3: Allow power-domains property To: Felipe Balbi , Rob Herring Cc: Heiko Stuebner , Greg Kroah-Hartman , Krzysztof Kozlowski , Thinh Nguyen , linux-rockchip@lists.infradead.org, Johan Jonker , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221219191038.1973807-1-robh@kernel.org> <87edsua5q4.fsf@balbi.sh> <878riy9ztm.fsf@balbi.sh> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <878riy9ztm.fsf@balbi.sh> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/12/2022 11:31, Felipe Balbi wrote: > > Hi, > > Rob Herring writes: >>>> The Rockchip RK3399 DWC3 node has 'power-domain' property which isn't >>>> allowed by the schema: >>>> >>>> usb@fe900000: Unevaluated properties are not allowed ('power-domains' was unexpected) >>>> >>>> Allow DWC3 nodes to have a single power-domains entry. We could instead >>>> move the power-domains property to the parent wrapper node, but the >>>> could be an ABI break (Linux shouldn't care). Also, we don't want to >>>> encourage the pattern of wrapper nodes just to define resources such as >>>> clocks, resets, power-domains, etc. when not necessary. >>>> >>>> Signed-off-by: Rob Herring >>>> --- >>>> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >>>> index 6d78048c4613..bcefd1c2410a 100644 >>>> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >>>> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >>>> @@ -91,6 +91,9 @@ properties: >>>> - usb2-phy >>>> - usb3-phy >>>> >>>> + power-domains: >>>> + maxItems: 1 >>> >>> AFAICT this can be incorrect. Also, you could have Cc the dwc3 >>> maintainer to get comments. >> >> When we have a user with more and know what each one is, then we can >> extend it. All the other users (upstream), put 'power-domains' in the > > Won't that be an ABI break at that point? You'll change the maximum > number of power-domains. Usually extending properties (in flexible way) is not an ABI break. What would be broken here if it becomes three at some point? Does Linux or other SW depends now on this being equal to 1? Best regards, Krzysztof