From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Alexander Dahl <ada@thorsis.com>, linux-leds@vger.kernel.org
Cc: Alexander Dahl <post@lespocky.de>,
devicetree@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
Dan Murphy <dmurphy@ti.com>, Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] leds: pwm: Make automatic labels work
Date: Fri, 4 Sep 2020 23:19:50 +0200 [thread overview]
Message-ID: <107cc1b1-501c-4946-facf-a437c1dfbf7a@gmail.com> (raw)
In-Reply-To: <2019500.FJf2EgCAKA@ada>
Hi Alexander,
On 9/4/20 9:53 AM, Alexander Dahl wrote:
> Hi Jacek,
>
> Am Dienstag, 1. September 2020, 23:08:09 CEST schrieb Jacek Anaszewski:
>> Hi Alexander,
>>
>> Thanks for the v2.
>>
>> On 8/31/20 11:02 PM, Alexander Dahl wrote:
>>> Hei hei,
>>>
>>> for leds-gpio you can use the properties 'function' and 'color' in the
>>> devicetree node and omit 'label', the label is constructed
>>> automatically. This is a common feature supposed to be working for all
>>> LED drivers. However it did not yet work for the 'leds-pwm' driver.
>>> This series fixes the driver and takes the opportunity to update the
>>> dt-bindings accordingly.
>>>
>>> v1: based on v5.9-rc2, backport on v5.4.59 tested and working
>>>
>>> v2: based on v5.9-rc3, added the dt-bindings update patch
>>>
>>> Greets
>>> Alex
>>>
>>> Alexander Dahl (2):
>>> leds: pwm: Allow automatic labels for DT based devices
>>> dt-bindings: leds: Convert pwm to yaml
>>>
>>> .../devicetree/bindings/leds/leds-pwm.txt | 50 -----------
>>> .../devicetree/bindings/leds/leds-pwm.yaml | 85 +++++++++++++++++++
>>> drivers/leds/leds-pwm.c | 9 +-
>>> 3 files changed, 93 insertions(+), 51 deletions(-)
>>> delete mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.txt
>>> create mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.yaml
>>
>> For both patches:
>>
>> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>
> I'd like to make a v3 and change the license of the .yaml file to "(GPL-2.0-
> only OR BSD-2-Clause)" as suggested by checkpatch and [1]. Can I keep your
> Acked-by for that?
Go ahead.
> Besides: those suggestions are obviously valid for new bindings. What about
> old bindings (.txt), which had no explicit SPDX tag or license note before?
> What license would apply there? Is the .yaml file technically new, when it
> was mostly just converted from .txt?
I don't know what was the rationale behind adding license to
DT bindings, probably Rob will be able to share some details.
Possibly the fact that DT examples can be now compile-tested
makes some difference here.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2020-09-04 21:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 21:02 [PATCH v2 0/2] leds: pwm: Make automatic labels work Alexander Dahl
2020-08-31 21:02 ` [PATCH v2 1/2] leds: pwm: Allow automatic labels for DT based devices Alexander Dahl
2020-08-31 21:02 ` [PATCH v2 2/2] dt-bindings: leds: Convert pwm to yaml Alexander Dahl
2020-08-31 21:31 ` Alexander Dahl
2020-09-01 21:08 ` [PATCH v2 0/2] leds: pwm: Make automatic labels work Jacek Anaszewski
2020-09-04 7:53 ` Alexander Dahl
2020-09-04 21:19 ` Jacek Anaszewski [this message]
2020-09-09 9:00 ` Pavel Machek
2020-09-09 9:22 ` Alexander Dahl
2020-09-09 9:27 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=107cc1b1-501c-4946-facf-a437c1dfbf7a@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=ada@thorsis.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=post@lespocky.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).