From: Heiko Stuebner <heiko@sntech.de>
To: MidG971 <midgy971@gmail.com>, Jonas Karlman <jonas@kwiboo.xyz>
Cc: linux-rockchip@lists.infradead.org, shawn.lin@rock-chips.com,
jonas@kwiboo.se, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v5] arm64: dts: rockchip: rock-3b: Model PI6C20100 as gated-fixed-clock
Date: Tue, 24 Mar 2026 23:27:47 +0100 [thread overview]
Message-ID: <10821700.nUPlyArG6x@phil> (raw)
In-Reply-To: <533f27c9-e970-449b-a431-4ba41a566aaf@kwiboo.xyz>
Hi Jonas,
Am Dienstag, 24. März 2026, 18:15:38 Mitteleuropäische Normalzeit schrieb Jonas Karlman:
> Hi Heiko,
>
> On 3/24/2026 6:04 PM, Heiko Stuebner wrote:
> >
> > On Fri, 20 Mar 2026 10:44:41 +0100, MidG971 wrote:
> >> The Radxa ROCK 3B uses a PI6C20100 PCIe reference clock buffer to
> >> provide a 100MHz reference clock to the PCIe 3.0 PHY and controllers.
> >> This chip is currently modeled only as a fixed regulator
> >> (vcc3v3_pi6c_03), with no clock output representation.
> >>
> >> The PI6C20100 is a clock generator, not a power supply. Model it
> >> properly as a gated-fixed-clock, following the pattern established
> >> for the Rock 5 ITX and other boards with similar PCIe clock buffer
> >> chips.
> >>
> >> [...]
> >
> > Applied, thanks!
>
> My comments from v3 [1] was not addressed in v4 och v5. E.g.
> regulator-always-on/boot-on not being removed and redundant comments.
>
> [1] https://lore.kernel.org/all/fec0f25d-733a-4b6c-aef1-2ac51bd15798@kwiboo.se/
thank you so much for noticing. Looks like that AI thing is
working "well" ;-) .
I've droped the patch and recreated the for-next branch now.
@Midgy, please honor feedback in future revisions.
Thanks
Heiko
next prev parent reply other threads:[~2026-03-24 22:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 15:14 [PATCH] arm64: dts: rockchip: rock-3b: Add phy-supply to pcie30phy MidG971
2026-02-13 16:10 ` Shawn Lin
2026-02-13 17:19 ` Jonas Karlman
2026-03-04 13:29 ` [PATCH v2] arm64: dts: rockchip: rock-3b: Model PI6C20100 as gated-fixed-clock MidG971
2026-03-04 13:57 ` Shawn Lin
[not found] ` <shawn-reply-message-id>
2026-03-19 10:19 ` MidG971
2026-03-19 12:27 ` Shawn Lin
2026-03-19 14:51 ` [PATCH v4] " MidG971
2026-03-20 8:48 ` Heiko Stuebner
2026-03-20 9:44 ` [PATCH v5] " MidG971
2026-03-24 17:04 ` Heiko Stuebner
2026-03-24 17:15 ` Jonas Karlman
2026-03-24 22:27 ` Heiko Stuebner [this message]
2026-03-27 9:07 ` Midgy Balon
2026-03-20 10:28 ` [PATCH v4] " Midgy Balon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10821700.nUPlyArG6x@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=jonas@kwiboo.se \
--cc=jonas@kwiboo.xyz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=midgy971@gmail.com \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox