* [PATCH 1/3] dt-bindings: usb: dwc2: add description for px30
2018-08-02 13:01 [PATCH 0/3] add dwc2 support for px30 Heiko Stuebner
@ 2018-08-02 13:01 ` Heiko Stuebner
2018-09-10 12:36 ` Heiko Stuebner
2018-08-02 13:01 ` [PATCH 2/3] arm64: dts: rockchip: add dwc2 otg controller on px30 Heiko Stuebner
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Heiko Stuebner @ 2018-08-02 13:01 UTC (permalink / raw)
To: linux-usb
Cc: mark.rutland, devicetree, Heiko Stuebner, balbi, gregkh,
linux-rockchip, robh+dt, cl, hminas, linux-arm-kernel
From: Liang Chen <cl@rock-chips.com>
This patch adds the compatible of dwc2 for PX30 SoCs.
Signed-off-by: Liang Chen <cl@rock-chips.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
unchanged from it being part of the general px30 series
Documentation/devicetree/bindings/usb/dwc2.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt b/Documentation/devicetree/bindings/usb/dwc2.txt
index 46da5f184460..6dc3c4a34483 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.txt
+++ b/Documentation/devicetree/bindings/usb/dwc2.txt
@@ -6,6 +6,7 @@ Required properties:
- brcm,bcm2835-usb: The DWC2 USB controller instance in the BCM2835 SoC.
- hisilicon,hi6220-usb: The DWC2 USB controller instance in the hi6220 SoC.
- rockchip,rk3066-usb: The DWC2 USB controller instance in the rk3066 Soc;
+ - "rockchip,px30-usb", "rockchip,rk3066-usb", "snps,dwc2": for px30 Soc;
- "rockchip,rk3188-usb", "rockchip,rk3066-usb", "snps,dwc2": for rk3188 Soc;
- "rockchip,rk3288-usb", "rockchip,rk3066-usb", "snps,dwc2": for rk3288 Soc;
- "lantiq,arx100-usb": The DWC2 USB controller instance in Lantiq ARX SoCs;
--
2.17.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] dt-bindings: usb: dwc2: add description for px30
2018-08-02 13:01 ` [PATCH 1/3] dt-bindings: usb: dwc2: add description " Heiko Stuebner
@ 2018-09-10 12:36 ` Heiko Stuebner
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2018-09-10 12:36 UTC (permalink / raw)
To: linux-usb, gregkh, balbi
Cc: mark.rutland, devicetree, linux-rockchip, robh+dt, cl, hminas,
linux-arm-kernel
Hi Greg, Felipe,
Am Donnerstag, 2. August 2018, 15:01:31 CEST schrieb Heiko Stuebner:
> From: Liang Chen <cl@rock-chips.com>
>
> This patch adds the compatible of dwc2 for PX30 SoCs.
>
> Signed-off-by: Liang Chen <cl@rock-chips.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Do you want to pick that patch through one of the usb trees, or should
I just apply it with the arm64 devicetree-patches?
Thanks
Heiko
> unchanged from it being part of the general px30 series
>
> Documentation/devicetree/bindings/usb/dwc2.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt b/Documentation/devicetree/bindings/usb/dwc2.txt
> index 46da5f184460..6dc3c4a34483 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc2.txt
> @@ -6,6 +6,7 @@ Required properties:
> - brcm,bcm2835-usb: The DWC2 USB controller instance in the BCM2835 SoC.
> - hisilicon,hi6220-usb: The DWC2 USB controller instance in the hi6220 SoC.
> - rockchip,rk3066-usb: The DWC2 USB controller instance in the rk3066 Soc;
> + - "rockchip,px30-usb", "rockchip,rk3066-usb", "snps,dwc2": for px30 Soc;
> - "rockchip,rk3188-usb", "rockchip,rk3066-usb", "snps,dwc2": for rk3188 Soc;
> - "rockchip,rk3288-usb", "rockchip,rk3066-usb", "snps,dwc2": for rk3288 Soc;
> - "lantiq,arx100-usb": The DWC2 USB controller instance in Lantiq ARX SoCs;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/3] arm64: dts: rockchip: add dwc2 otg controller on px30
2018-08-02 13:01 [PATCH 0/3] add dwc2 support for px30 Heiko Stuebner
2018-08-02 13:01 ` [PATCH 1/3] dt-bindings: usb: dwc2: add description " Heiko Stuebner
@ 2018-08-02 13:01 ` Heiko Stuebner
2018-08-02 13:01 ` [PATCH 3/3] arm64: dts: rockchip: enable dwc2-based otg controller on px30-evb Heiko Stuebner
2018-09-24 13:47 ` [PATCH 0/3] add dwc2 support for px30 Heiko Stuebner
3 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2018-08-02 13:01 UTC (permalink / raw)
To: linux-usb
Cc: mark.rutland, devicetree, Heiko Stuebner, balbi, gregkh,
linux-rockchip, robh+dt, cl, hminas, linux-arm-kernel
Add the node for the dwc2-based otg controller on the px30 soc.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
arch/arm64/boot/dts/rockchip/px30.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi
index dc3b22ca9a0e..fed782194a94 100644
--- a/arch/arm64/boot/dts/rockchip/px30.dtsi
+++ b/arch/arm64/boot/dts/rockchip/px30.dtsi
@@ -702,6 +702,22 @@
<100000000>, <200000000>;
};
+ usb20_otg: usb@ff300000 {
+ compatible = "rockchip,px30-usb", "rockchip,rk3066-usb",
+ "snps,dwc2";
+ reg = <0x0 0xff300000 0x0 0x40000>;
+ interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cru HCLK_OTG>;
+ clock-names = "otg";
+ dr_mode = "otg";
+ g-np-tx-fifo-size = <16>;
+ g-rx-fifo-size = <280>;
+ g-tx-fifo-size = <256 128 128 64 32 16>;
+ g-use-dma;
+ power-domains = <&power PX30_PD_USB>;
+ status = "disabled";
+ };
+
usb_host0_ehci: usb@ff340000 {
compatible = "generic-ehci";
reg = <0x0 0xff340000 0x0 0x10000>;
--
2.17.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] arm64: dts: rockchip: enable dwc2-based otg controller on px30-evb
2018-08-02 13:01 [PATCH 0/3] add dwc2 support for px30 Heiko Stuebner
2018-08-02 13:01 ` [PATCH 1/3] dt-bindings: usb: dwc2: add description " Heiko Stuebner
2018-08-02 13:01 ` [PATCH 2/3] arm64: dts: rockchip: add dwc2 otg controller on px30 Heiko Stuebner
@ 2018-08-02 13:01 ` Heiko Stuebner
2018-09-24 13:47 ` [PATCH 0/3] add dwc2 support for px30 Heiko Stuebner
3 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2018-08-02 13:01 UTC (permalink / raw)
To: linux-usb
Cc: mark.rutland, devicetree, Heiko Stuebner, balbi, gregkh,
linux-rockchip, robh+dt, cl, hminas, linux-arm-kernel
Enable the newly added controller on the px30 evaluation board.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
arch/arm64/boot/dts/rockchip/px30-evb.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/px30-evb.dts b/arch/arm64/boot/dts/rockchip/px30-evb.dts
index c74aa910a631..263d7f3dbc44 100644
--- a/arch/arm64/boot/dts/rockchip/px30-evb.dts
+++ b/arch/arm64/boot/dts/rockchip/px30-evb.dts
@@ -206,6 +206,10 @@
status = "okay";
};
+&usb20_otg {
+ status = "okay";
+};
+
&usb_host0_ehci {
status = "okay";
};
--
2.17.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 0/3] add dwc2 support for px30
2018-08-02 13:01 [PATCH 0/3] add dwc2 support for px30 Heiko Stuebner
` (2 preceding siblings ...)
2018-08-02 13:01 ` [PATCH 3/3] arm64: dts: rockchip: enable dwc2-based otg controller on px30-evb Heiko Stuebner
@ 2018-09-24 13:47 ` Heiko Stuebner
3 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2018-09-24 13:47 UTC (permalink / raw)
To: linux-usb
Cc: mark.rutland, devicetree, balbi, gregkh, linux-rockchip, robh+dt,
cl, hminas, linux-arm-kernel
Am Donnerstag, 2. August 2018, 15:01:30 CEST schrieb Heiko Stuebner:
> This is split out from the series adding the px30 support, due to
> the dwc2 binding change not having landed yet in a maintainer tree.
>
> The Acked binding change should go through some usb tree, while
> I'll pick up the dts changes once that has happened.
>
> The binding itself is unchanged.
>
>
> Heiko Stuebner (2):
> arm64: dts: rockchip: add dwc2 otg controller on px30
> arm64: dts: rockchip: enable dwc2-based otg controller on px30-evb
>
> Liang Chen (1):
> dt-bindings: usb: dwc2: add description for px30
applied all 3 patches for 4.20 now.
^ permalink raw reply [flat|nested] 6+ messages in thread