From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30E8EC07E99 for ; Mon, 12 Jul 2021 20:46:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A5C061245 for ; Mon, 12 Jul 2021 20:46:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231542AbhGLUtX (ORCPT ); Mon, 12 Jul 2021 16:49:23 -0400 Received: from gloria.sntech.de ([185.11.138.130]:59744 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230058AbhGLUtW (ORCPT ); Mon, 12 Jul 2021 16:49:22 -0400 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m32ot-0005pE-5E; Mon, 12 Jul 2021 22:46:27 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Laurent Pinchart Cc: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, ezequiel@collabora.com, dafna.hirschfeld@collabora.com, helen.koike@collabora.com, linux-rockchip@lists.infradead.org, linux-media@vger.kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 0/7] rkisp1 support for px30 Date: Mon, 12 Jul 2021 22:46:26 +0200 Message-ID: <10918018.2OtUDhi4od@diego> In-Reply-To: References: <20210618130238.4171196-1-heiko@sntech.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Laurent, Am Montag, 12. Juli 2021, 22:40:19 CEST schrieb Laurent Pinchart: > Hi Heiko, > > On Fri, Jun 18, 2021 at 03:02:28PM +0200, Heiko Stuebner wrote: > > This series adds support for the slightly different v12 > > variant of the ISP used for example in the px30 soc. > > Nice :-) > > How have you tested this ? I have this running on a px30-evb with the integrated camera. With libcamera's tools/rkisp1 script it works out of the box, but there is also my still pending little libcamera patch to add actual support for the changed values [0] which then even makes qcam work nicely ;-) . Heiko [0] https://patchwork.libcamera.org/patch/12668/ > > > changes in v6: > > - camera compatible in px30 binding example (Rob's bot) > > - move a last wrong positionen constant define (a v12 addition > > should not be added in the v10-prefix change) (Dafna) > > - rename size to clk_size in match-data struct (Dafna) > > > > changes in v5: > > - handle interrupt-names as conditional required property (Dafna) > > - add second example for showing interrupt-names (Dafna) > > > > changes in v4: > > - clean up multi-irq case (Dafna) > > Now each variant can have a list of interrupts > > and their respective handlers, with or without > > interrupt-names > > > > changes in v3: > > - add necessary binding additions > > - fix pclk naming in binding > > - move v12 clk_ctrl register bits to v12 addition patch > > - fix rebase artefact with hst_enable > > > > changes in v2 (from rfc): > > - split out phy patch into a separate series > > - drop dts patches for now > > - split v12 addition and v10 prefixes into separate patches > > to enable easier review (Dafna) > > - remove {stats,params}_config structs, we can just use the > > correct constant (Dafna) > > - adapt to styling comments from Dafna and Helen > > - add patch to remove the unused irq variable in struct rkisp > > > > Heiko Stuebner (10): > > media: rockchip: rkisp1: remove unused irq variable > > dt-bindings: media: rkisp1: fix pclk clock-name > > dt-bindings: media: rkisp1: document different irq possibilities > > media: rockchip: rkisp1: allow separate interrupts > > media: rockchip: rkisp1: make some isp-param functions variable > > media: rockchip: rkisp1: make some isp-stats functions variable > > media: rockchip: rkisp1: add prefixes for v10 specific parts > > media: rockchip: rkisp1: add support for v12 isp variants > > dt-bindings: media: rkisp1: document px30 isp compatible > > media: rockchip: rkisp1: add support for px30 isp version > > > > .../bindings/media/rockchip-isp1.yaml | 114 +++- > > .../platform/rockchip/rkisp1/rkisp1-capture.c | 9 +- > > .../platform/rockchip/rkisp1/rkisp1-common.h | 44 +- > > .../platform/rockchip/rkisp1/rkisp1-dev.c | 81 ++- > > .../platform/rockchip/rkisp1/rkisp1-isp.c | 29 +- > > .../platform/rockchip/rkisp1/rkisp1-params.c | 557 ++++++++++++++---- > > .../platform/rockchip/rkisp1/rkisp1-regs.h | 406 ++++++++----- > > .../platform/rockchip/rkisp1/rkisp1-stats.c | 107 +++- > > 8 files changed, 1050 insertions(+), 297 deletions(-) > >