From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0CCFC6FD1C for ; Sun, 26 Mar 2023 09:37:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231877AbjCZJhX (ORCPT ); Sun, 26 Mar 2023 05:37:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232168AbjCZJhV (ORCPT ); Sun, 26 Mar 2023 05:37:21 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C68CF5 for ; Sun, 26 Mar 2023 02:37:19 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id h8so24301055ede.8 for ; Sun, 26 Mar 2023 02:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679823438; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=womt1sTjj98HBWC12qs0rQLizgn/XM7va5jl8pNY4ac=; b=GHkGxIaUDHD9EVehc6ie2OQuCwM40c0Sa/sF8VYs8OH+m5MpI3q68BwrNW2YOW+ipo cr8ES+JlIAq13MyMuLYnUBFfN4xtMwH0x+BZO/eD5KI//izd5SSS38fr7Qx44Q47Osf2 wx3toJdDGo5LVoFftdIU24vVQIn8RpVXMhDydizeu2K+WBADhg4BQNQWFubeMA6aaztF KbNI93cdJebCDYh1WgyGa0VIw1YzUdWOeGLBlbOmv6u+uf3zDtGkgxXqcjiT/BdkBipL R5X8U6f7aLAJxgX0s6M2UAxge20lJpE3eyn0H9NF1XHvtJV0pqA9jASBh5tFolIMR0nF Qh0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679823438; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=womt1sTjj98HBWC12qs0rQLizgn/XM7va5jl8pNY4ac=; b=fkQ3ylR/37NXgaw4mULf86A6IZRN3E5l845bzzIEDno1bBOAndBXsk+yAFkOt4D8PI JMl5w9C/Xg+Txg+1qTMNosfsKG47hW+YBll0xbt2QkFLBUe48aYA8TgUVeOQu5a3WYoD ZBNWbcI14fl5F7MzSeFpx8lIb5yedfMisO5ouXs/d+Qo+f9n8WObj/Uy2XzJMh60zQ/u FZkyji8zZoCuw7vuuflVceRCShslHw7ekzoVofZfcp9E+K1usxQnFO808hVtklELxhs0 XDIti7E2FaiJ7S77LEvEIvMlLEaJRf7fOXCaxVGENyoUqvd4bhHaFm8arhmVGW5HPDrZ 7++Q== X-Gm-Message-State: AAQBX9cqrkmU7WNMccDYGClbWDf7CWmqRSqIYRPN1G+0QxuaFEIYj/mq G5ppVCzAepNiXi5BG84I5492Dg== X-Google-Smtp-Source: AKy350aR88wKTInMhM2+4A7tNI6V5uRWI3jQ2Pt0sIPnZuOvt7Cl/gcLtj4c8VsNeo0rbho+lF/46A== X-Received: by 2002:a05:6402:8d6:b0:502:2953:8ecb with SMTP id d22-20020a05640208d600b0050229538ecbmr5138565edz.13.1679823438181; Sun, 26 Mar 2023 02:37:18 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:6cac:926d:a4f2:aa09? ([2a02:810d:15c0:828:6cac:926d:a4f2:aa09]) by smtp.gmail.com with ESMTPSA id k12-20020a50ce4c000000b004af70c546dasm13284309edj.87.2023.03.26.02.37.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Mar 2023 02:37:17 -0700 (PDT) Message-ID: <10930783-e1dd-5e75-a2cc-a09af862d949@linaro.org> Date: Sun, 26 Mar 2023 11:37:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 2/2] dt-bindings: clock: update rk3588 clock definitions Content-Language: en-US To: Shane Francis Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230326001535.149539-1-bigbeeshane@gmail.com> <20230326001535.149539-2-bigbeeshane@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230326001535.149539-2-bigbeeshane@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/03/2023 01:15, Shane Francis wrote: > Some vendor uboot bootloaders use the target kernels > DTB image to determine the target clock speeds for > some PLLs, currently this can cause uboot to set the > clock rate for gpll incorrectly on to cpll (breaking) Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > RGMII. > > This change starts the PLL clock definitions from 1 > to correct this miss-match Unfortunately the reason is not good enough for ABI break. Replace vendor boot uboots with open-source one or just correct them (it's still U-Boot so even for vendor one you have the source). > > Signed-off-by: Shane Francis > --- > .../dt-bindings/clock/rockchip,rk3588-cru.h | 1442 ++++++++--------- > 1 file changed, 721 insertions(+), 721 deletions(-) > > diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h > index b5616bca7b44..d63b07d054b7 100644 > --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h > +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h > @@ -12,727 +12,727 @@ > > /* cru-clocks indices */ > > -#define PLL_B0PLL 0 Best regards, Krzysztof