From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
devicetree@vger.kernel.org
Cc: Hartley Sweeten <hsweeten@visionengravers.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: sound: ep93xx: Add I2S and AC'97 descriptions
Date: Tue, 14 Feb 2023 14:02:27 +0100 [thread overview]
Message-ID: <109868b9492aecaca0a7170cba9fb51e62de7116.camel@gmail.com> (raw)
In-Reply-To: <46d5b6af-23e1-4178-83bc-b4a435b1426e@linaro.org>
Hello Krzysztof,
thank you for the quick review!
On Tue, 2023-02-14 at 11:58 +0100, Krzysztof Kozlowski wrote:
> > +properties:
> > + compatible:
> > + const: cirrus,ep9301-i2s
> > +
> > + '#sound-dai-cells':
> > + const: 0
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + minItems: 3
>
> maxItems instead
reg and clocks are required, I suppose I should include both minItems
and maxItems for both of them?
> > +
> > + clock-names:
> > + items:
> > + - const: mclk
> > + - const: sclk
> > + - const: lrclk
>
>
> The clk suffixes are quite redundant. Don't these inputs have some
> meaningful name?
They are actually meaningful, as they are usually named in I2S, please
refer to the EP93xx User's Guide:
https://cdn.embeddedts.com/resource-attachments/ts-7000_ep9301-ug.pdf
page 71, for instance.
--
Alexander Sverdlin.
next prev parent reply other threads:[~2023-02-14 13:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-12 23:21 [PATCH 1/2] dt-bindings: sound: ep93xx: Add I2S and AC'97 descriptions Alexander Sverdlin
2023-02-12 23:21 ` [PATCH 2/2] ASoC: ep93xx: Add OF support Alexander Sverdlin
2023-02-14 10:58 ` [PATCH 1/2] dt-bindings: sound: ep93xx: Add I2S and AC'97 descriptions Krzysztof Kozlowski
2023-02-14 13:02 ` Alexander Sverdlin [this message]
2023-02-14 14:11 ` Krzysztof Kozlowski
2023-02-14 14:26 ` Alexander Sverdlin
2023-02-14 15:02 ` Mark Brown
2023-02-15 19:16 ` Rob Herring
2023-02-15 19:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=109868b9492aecaca0a7170cba9fb51e62de7116.camel@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hsweeten@visionengravers.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).