From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E109EC04AA5 for ; Thu, 25 Aug 2022 12:35:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241895AbiHYMfT (ORCPT ); Thu, 25 Aug 2022 08:35:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241856AbiHYMfO (ORCPT ); Thu, 25 Aug 2022 08:35:14 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DFDF11141 for ; Thu, 25 Aug 2022 05:35:10 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id bt10so15062358lfb.1 for ; Thu, 25 Aug 2022 05:35:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=qm1VFnM17ulLUrYUN8fcZvzp7VH3d31REMQB+ckUr3Q=; b=SpA2HYm9DLnU/EXciLfX4A051CrgLyim57EoHljXjxMDOJzuIuHsTIfyLNawHMMfpq 4hUhutxecfAcXgQAaJvmAQ2GK+I3zIrSiM/8Nn069NgUfZtRgLn2R1dXmnCt0rTRjsJt KBKevfnQo/bqs0PShPn3ofhrbTR+Va8ZS2ptv+anFlFJsqq/E7U6tfThUdIKt1oKfSdj 1PE/YTa9umNdULjsEwOdN1YdUHarRcufEzwVRj4rlBlKUWgWpWQsVHjXYzYlIRN1HN5T eYn/IJzQmWb1a6vpVt+TbCkAM6ltU8Ym3Y76pST3SZgYHoqDUZbl2bMTVyZO1sqooAp1 Vu7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=qm1VFnM17ulLUrYUN8fcZvzp7VH3d31REMQB+ckUr3Q=; b=xfrjl9eFJrC7E8fHYRgDgP7KrwYNvqor91aWuy3CvUFQ7myyxheKUd5BbgNmrfXRMV NeGE1NRLg9t6CLP8sfrd7GgCIzV/C69vsBC1jKjJYIswsUCT0Ku8w5+X1tp+PP+oYtAH 6EdB8SO7mznYufyO5Z0KZh345WTEGjz+OcDUxu/hT0tsDlUD98OnMOFuSXgVSdvLGUa2 iZ3sdCGeCst53TJR4FUIBWBSgZqlmCwbmDUkd1hzugqamJnEPEKKbZGsUG4rVids5Keb ro8AjsTsJ23BRKXllZrZsJKahoEayKAatI/aHLXKXUVaVvoMojtmAf93op7ez2D3tlQq oUHw== X-Gm-Message-State: ACgBeo3E1j6EFeA5sPmFfm3ehzpN5tG1GXG9GzghEtGvs3rS6YopneSI 6LwJVQYs5+PHsVRRtOFk/7UyXQ== X-Google-Smtp-Source: AA6agR7wYAyBxPj4P3PZ4zX1SnUixQzufvZLeLxinIuBXty/IhtA6LoAayUEHcXGZdGsFDQ5Gmp7Rg== X-Received: by 2002:a05:6512:39cf:b0:492:dbf8:990 with SMTP id k15-20020a05651239cf00b00492dbf80990mr1191416lfu.39.1661430908704; Thu, 25 Aug 2022 05:35:08 -0700 (PDT) Received: from [192.168.0.71] (82.131.98.15.cable.starman.ee. [82.131.98.15]) by smtp.gmail.com with ESMTPSA id p11-20020a05651211eb00b0047f647414efsm473024lfs.190.2022.08.25.05.35.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Aug 2022 05:35:08 -0700 (PDT) Message-ID: <109c37f0-8b1a-40d0-7b86-dde80fb77081@linaro.org> Date: Thu, 25 Aug 2022 15:35:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] dt-bindings: gpio: mpfs-gpio: allow parsing of hog child nodes. Content-Language: en-US To: Conor.Dooley@microchip.com, mail@conchuod.ie, linus.walleij@linaro.org, brgl@bgdev.pl, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220820204130.1380270-1-mail@conchuod.ie> <0ecf1664-03a2-71ac-b967-6905b96c7ce0@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/08/2022 15:30, Conor.Dooley@microchip.com wrote: > On 25/08/2022 13:10, Krzysztof Kozlowski wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 20/08/2022 23:41, Conor Dooley wrote: >>> From: Conor Dooley >>> >>> The SD card and eMMC on PolarFire SoC based dev boards are sometimes >>> statically muxed using a GPIO. To facilitate this, enable gpio-hog >>> child node properties. >>> >>> Signed-off-by: Conor Dooley >>> --- >>> .../bindings/gpio/microchip,mpfs-gpio.yaml | 18 ++++++++++++++++++ >>> 1 file changed, 18 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml b/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml >>> index 110651eafa70..6704a7a52cd0 100644 >>> --- a/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml >>> +++ b/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml >>> @@ -44,6 +44,24 @@ properties: >>> >>> gpio-controller: true >>> >>> +patternProperties: >>> + "^.+-hog(?:-[0-9]+)?$": >> >> What is this pattern about: "(?:" ? > > Me being a pedant I suppose. "()" is a capture while "(?:)" is a match. > However, it does seem like json-schema suggests using "()": > https://json-schema.org/understanding-json-schema/reference/regular_expressions.html > > I don't mind & neither does the schema checker. Use what existing sources are doing, so "^.+-hog(-[0-9]+)?$" Best regards, Krzysztof