devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	gregkh@linuxfoundation.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
	s.hauer@pengutronix.de, xu.yang_2@nxp.com
Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, jun.li@nxp.com,
	Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V4 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema
Date: Sun, 19 Mar 2023 13:19:47 +0100	[thread overview]
Message-ID: <10a850be-b04e-90db-cacb-127ac7698d97@linaro.org> (raw)
In-Reply-To: <20230317123708.337286-2-peng.fan@oss.nxp.com>

On 17/03/2023 13:37, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 


> +  '#index-cells':
> +    const: 1
> +    description: Cells used to describe usb controller index.
> +    deprecated: true
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    usbmisc@2184800 {
> +        #index-cells = <1>;
> +        compatible = "fsl,imx6q-usbmisc";
> +        reg = <0x02184800 0x200>;

If there is going to be resend, put compatible first, reg second. Then rest.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


  reply	other threads:[~2023-03-19 12:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-17 12:37 [PATCH V4 0/6] dt-bindings: usb: covert ci-hdrc-usb2/usbmisc-imx to yaml Peng Fan (OSS)
2023-03-17 12:37 ` [PATCH V4 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema Peng Fan (OSS)
2023-03-19 12:19   ` Krzysztof Kozlowski [this message]
2023-03-17 12:37 ` [PATCH V4 2/6] dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format Peng Fan (OSS)
2023-03-17 14:55   ` Rob Herring
2023-03-17 12:37 ` [PATCH V4 3/6] ARM64: dts: imx8mn: update usb compatible Peng Fan (OSS)
2023-03-17 12:37 ` [PATCH V4 4/6] arm64: dts: imx8mm: " Peng Fan (OSS)
2023-03-17 12:37 ` [PATCH V4 5/6] arm64: dts: imx8: " Peng Fan (OSS)
2023-03-17 12:37 ` [PATCH V4 6/6] arm64: dts: imx8dxl: " Peng Fan (OSS)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10a850be-b04e-90db-cacb-127ac7698d97@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jun.li@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=xu.yang_2@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).