From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: sc7280: align RPMh regulator nodes with bindings
Date: Fri, 17 Feb 2023 17:45:42 +0100 [thread overview]
Message-ID: <10c022fa-6400-bc15-12b7-11453bc3eb43@linaro.org> (raw)
In-Reply-To: <20230217155838.848403-3-krzysztof.kozlowski@linaro.org>
On 17.02.2023 16:58, Krzysztof Kozlowski wrote:
> Device node names should be generic and bindings expect certain pattern
> for RPMh regulator nodes.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
>
> I was fixing these in other boards, but missed SC7280. Previous
> (applied) set:
> https://lore.kernel.org/r/20230127114347.235963-4-krzysztof.kozlowski@linaro.org
> ---
> arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 2 +-
> arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts | 2 +-
> arch/arm64/boot/dts/qcom/sc7280-idp.dts | 2 +-
> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 4 ++--
> arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 4 ++--
> 5 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
> index 1185141f348e..afae7f46b050 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
> @@ -27,7 +27,7 @@ chosen {
> };
>
> &apps_rsc {
> - pmg1110-regulators {
> + regulators-2 {
> compatible = "qcom,pmg1110-rpmh-regulators";
> qcom,pmic-id = "k";
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts
> index 4e0b013e25f4..df39a64da923 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts
> @@ -40,7 +40,7 @@ vreg_edp_bl_crd: vreg-edp-bl-crd-regulator {
> /* ADDITIONS TO NODES DEFINED IN PARENT DEVICE TREE FILES */
>
> &apps_rsc {
> - pmg1110-regulators {
> + regulators-2 {
> compatible = "qcom,pmg1110-rpmh-regulators";
> qcom,pmic-id = "k";
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> index ba64316b4427..15222e92e3f5 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> @@ -25,7 +25,7 @@ chosen {
> };
>
> &apps_rsc {
> - pmr735a-regulators {
> + regulators-2 {
> compatible = "qcom,pmr735a-rpmh-regulators";
> qcom,pmic-id = "e";
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> index 8b5293e7fd2a..8ebcf763b3c7 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> @@ -184,7 +184,7 @@ codec {
> };
>
> &apps_rsc {
> - pm7325-regulators {
> + regulators-0 {
> compatible = "qcom,pm7325-rpmh-regulators";
> qcom,pmic-id = "b";
>
> @@ -279,7 +279,7 @@ vreg_l19b_1p8: ldo19 {
> };
> };
>
> - pm8350c-regulators {
> + regulators-1 {
> compatible = "qcom,pm8350c-rpmh-regulators";
> qcom,pmic-id = "c";
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> index 88204f794ccb..cb0cc2ba2fa3 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> @@ -87,7 +87,7 @@ &apps_rsc {
> * are left out of here since they are managed elsewhere.
> */
>
> - pm7325-regulators {
> + regulators-0 {
> compatible = "qcom,pm7325-rpmh-regulators";
> qcom,pmic-id = "b";
>
> @@ -188,7 +188,7 @@ vreg_l19b_1p8: ldo19 {
> };
> };
>
> - pm8350c-regulators {
> + regulators-1 {
> compatible = "qcom,pm8350c-rpmh-regulators";
> qcom,pmic-id = "c";
>
next prev parent reply other threads:[~2023-02-17 16:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 15:58 [PATCH 1/3] arm64: dts: qcom: sc7180-trogdor-pazquel360: drop incorrect RT5682S VBAT-supply Krzysztof Kozlowski
2023-02-17 15:58 ` [PATCH 2/3] arm64: dts: qcom: sc7280-herobrine-audio-rt5682: add missing supplies Krzysztof Kozlowski
2023-03-22 18:14 ` Doug Anderson
2023-02-17 15:58 ` [PATCH 3/3] arm64: dts: qcom: sc7280: align RPMh regulator nodes with bindings Krzysztof Kozlowski
2023-02-17 16:45 ` Konrad Dybcio [this message]
2023-03-22 18:15 ` Doug Anderson
2023-03-22 18:14 ` [PATCH 1/3] arm64: dts: qcom: sc7180-trogdor-pazquel360: drop incorrect RT5682S VBAT-supply Doug Anderson
2023-03-24 18:34 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10c022fa-6400-bc15-12b7-11453bc3eb43@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).