From: Wesley Cheng <wcheng@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org, balbi@kernel.org,
gregkh@linuxfoundation.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, jackp@codeaurora.org
Subject: Re: [RFC 3/3] dt-bindings: usb: dwc3: Add entry for tx-fifo-resize
Date: Fri, 15 May 2020 11:39:46 -0700 [thread overview]
Message-ID: <10d2109d-cfb7-73d0-a186-4fa5f17feffe@codeaurora.org> (raw)
In-Reply-To: <20200515031042.GA25107@bogus>
On 5/14/2020 8:10 PM, Rob Herring wrote:
> On Thu, May 07, 2020 at 02:59:28PM -0700, Wesley Cheng wrote:
>> Re-introduce the comment for the tx-fifo-resize setting for the DWC3
>> controller.
>
> Why?
>
Hi Rob,
Initially, the reasoning behind bringing back the DTSI parameter, was to
address situations where vendors don't require the resizing logic. I
was assuming that each vendor has their own HW configuration for the TX
FIFO size, and some may already have sufficient space to account for
their endpoint requirements. However, if Felipe doesn't believe we need
to have a DTSI parameter for this, then we don't need to re-add this
back in.
>>
>> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/usb/dwc3.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
>> index 9946ff9..489f5da 100644
>> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
>> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
>> @@ -105,7 +105,7 @@ Optional properties:
>> 1-16 (DWC_usb31 programming guide section 1.2.3) to
>> enable periodic ESS TX threshold.
>>
>> - - <DEPRECATED> tx-fifo-resize: determines if the FIFO *has* to be reallocated.
>> + - tx-fifo-resize: determines if the FIFO *has* to be reallocated.
>> - snps,incr-burst-type-adjustment: Value for INCR burst type of GSBUSCFG0
>> register, undefined length INCR burst type enable and INCRx type.
>> When just one value, which means INCRX burst mode enabled. When
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> a Linux Foundation Collaborative Project
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2020-05-15 18:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 21:59 [RFC 0/3] Re-introduce TX FIFO resize for larger EP bursting Wesley Cheng
2020-05-07 21:59 ` [RFC 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements Wesley Cheng
2020-05-08 12:45 ` Felipe Balbi
2020-05-09 8:42 ` Wesley Cheng
2020-05-07 21:59 ` [RFC 2/3] arm64: boot: dts: qcom: sm8150: Enable dynamic TX FIFO resize logic Wesley Cheng
2020-05-07 21:59 ` [RFC 3/3] dt-bindings: usb: dwc3: Add entry for tx-fifo-resize Wesley Cheng
2020-05-15 3:10 ` Rob Herring
2020-05-15 18:39 ` Wesley Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10d2109d-cfb7-73d0-a186-4fa5f17feffe@codeaurora.org \
--to=wcheng@codeaurora.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jackp@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).