From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Wolfram Sang" <wsa@kernel.org>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"Matti Vaittinen" <Matti.Vaittinen@fi.rohmeurope.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Peter Rosin" <peda@axentia.se>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Michael Tretter" <m.tretter@pengutronix.de>,
"Shawn Tu" <shawnx.tu@intel.com>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Mike Pagano" <mpagano@gentoo.org>,
"Krzysztof Hałasa" <khalasa@piap.pl>,
"Marek Vasut" <marex@denx.de>
Subject: Re: [PATCH v6 7/8] media: i2c: add DS90UB913 driver
Date: Mon, 9 Jan 2023 16:01:43 +0200 [thread overview]
Message-ID: <10d369c1-4aaf-f59d-dbdc-48f04424a030@ideasonboard.com> (raw)
In-Reply-To: <Y7wdePnmFx1XDGvB@smile.fi.intel.com>
On 09/01/2023 15:58, Andy Shevchenko wrote:
> On Mon, Jan 09, 2023 at 03:55:39PM +0200, Andy Shevchenko wrote:
>> On Mon, Jan 09, 2023 at 02:59:01PM +0200, Tomi Valkeinen wrote:
>>> On 09/01/2023 13:07, Andy Shevchenko wrote:
>>>> On Sun, Jan 08, 2023 at 06:06:34AM +0200, Laurent Pinchart wrote:
>>>>> On Thu, Jan 05, 2023 at 04:03:06PM +0200, Tomi Valkeinen wrote:
>
> ...
>
>>>>>> + gc->of_node = priv->client->dev.of_node;
>>>>
>>>> We don't have of_node anymore in gc. And if the parent device is set, you can
>>>> drop this line (it will work with older and newer kernels. Otherwise, use
>>>> fwnode.
>>>
>>> What do you mean "we don't have of_node anymore"?
>
> Just to add that you missed "gc" in the quote which is crucial to get
> what I meant.
Well, the original text was just above...
>> There is no of_node member of struct gpio_chip anymore. This will fail
>> to compile.
It's in Linus' tree, but yes, now that I fetched linux-next I see it's gone.
Tomi
next prev parent reply other threads:[~2023-01-09 14:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 14:02 [PATCH v6 0/8] i2c-atr and FPDLink Tomi Valkeinen
2023-01-05 14:03 ` [PATCH v6 1/8] i2c: core: let adapters be notified of client attach/detach Tomi Valkeinen
2023-01-08 3:13 ` Laurent Pinchart
2023-01-08 9:24 ` Tomi Valkeinen
2023-01-05 14:03 ` [PATCH v6 2/8] i2c: add I2C Address Translator (ATR) support Tomi Valkeinen
2023-01-05 14:03 ` [PATCH v6 3/8] dt-bindings: media: add TI DS90UB913 FPD-Link III Serializer Tomi Valkeinen
2023-01-08 3:15 ` Laurent Pinchart
2023-01-08 22:01 ` Rob Herring
2023-01-05 14:03 ` [PATCH v6 4/8] dt-bindings: media: add TI DS90UB953 " Tomi Valkeinen
2023-01-08 3:17 ` Laurent Pinchart
2023-01-08 22:04 ` Rob Herring
2023-01-05 14:03 ` [PATCH v6 5/8] dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer Tomi Valkeinen
2023-01-08 3:23 ` Laurent Pinchart
2023-01-09 8:30 ` Tomi Valkeinen
2023-01-09 9:09 ` Laurent Pinchart
2023-01-09 9:53 ` Tomi Valkeinen
2023-01-09 10:07 ` Laurent Pinchart
2023-01-05 14:03 ` [PATCH v6 6/8] media: i2c: add DS90UB960 driver Tomi Valkeinen
2023-01-05 14:03 ` [PATCH v6 7/8] media: i2c: add DS90UB913 driver Tomi Valkeinen
2023-01-08 4:06 ` Laurent Pinchart
2023-01-09 9:40 ` Tomi Valkeinen
2023-01-09 9:56 ` Laurent Pinchart
2023-01-09 11:07 ` Andy Shevchenko
2023-01-09 12:59 ` Tomi Valkeinen
2023-01-09 13:55 ` Andy Shevchenko
2023-01-09 13:58 ` Andy Shevchenko
2023-01-09 14:01 ` Tomi Valkeinen [this message]
2023-01-09 14:11 ` Andy Shevchenko
2023-01-09 15:08 ` Tomi Valkeinen
2023-01-05 14:03 ` [PATCH v6 8/8] media: i2c: add DS90UB953 driver Tomi Valkeinen
2023-01-08 4:23 ` Laurent Pinchart
2023-01-09 14:19 ` Tomi Valkeinen
2023-01-05 14:05 ` [PATCH v6 0/8] i2c-atr and FPDLink Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10d369c1-4aaf-f59d-dbdc-48f04424a030@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=Matti.Vaittinen@fi.rohmeurope.com \
--cc=andriy.shevchenko@intel.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=khalasa@piap.pl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=m.tretter@pengutronix.de \
--cc=marex@denx.de \
--cc=mchehab@kernel.org \
--cc=mpagano@gentoo.org \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnx.tu@intel.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).