From: Krzysztof Kozlowski <krzk@kernel.org>
To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>,
"patrick@stwcx.xyz" <patrick@stwcx.xyz>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>
Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: Enable interrupt setting for pca9555
Date: Mon, 16 Sep 2024 10:51:29 +0200 [thread overview]
Message-ID: <10de03e4-db98-4b5c-9cf6-3f98a5cc0537@kernel.org> (raw)
In-Reply-To: <TYZPR04MB5853795FDC6497F7E0114E43D69A2@TYZPR04MB5853.apcprd04.prod.outlook.com>
On 10/09/2024 10:20, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
> I will revise in v2. Thanks!
>>> + interrupt-parent = <&gpio0>;
>>> + interrupts = <98 IRQ_TYPE_LEVEL_LOW>;
>>> + gpio-line-names =
>>> + "P48V_OCP_GPIO1","P48V_OCP_GPIO2",
>>
>> Nothing improved here. I already commented about above and this.
>> Implement feedback for all your patches, not only one.
>>
>> Best regards,
>> Krzysztof
> Sorry about that.
> I saw you say "Broken alignment" in v15 patch.
> Would like to ask if the following format meets your expectations?
> + gpio-line-names =
> + "P48V_OCP_GPIO1", "P48V_OCP_GPIO2",
> + "P48V_OCP_GPIO3", "FAN_BOARD_0_REVISION_0_R",
Please read DTS coding style before posting next version of the patch
(or any patch for DTS). This is still not aligned. There is (almost)
never a blank line after '='.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-16 8:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 6:39 [PATCH v1] ARM: dts: aspeed: yosemite4: Enable interrupt setting for pca9555 Delphine CC Chiu
2024-09-10 7:30 ` Krzysztof Kozlowski
2024-09-10 8:20 ` Delphine_CC_Chiu/WYHQ/Wiwynn
2024-09-16 8:51 ` Krzysztof Kozlowski [this message]
2024-09-18 3:12 ` Delphine_CC_Chiu/WYHQ/Wiwynn
2024-09-18 8:16 ` Krzysztof Kozlowski
2024-09-18 8:59 ` Delphine_CC_Chiu/WYHQ/Wiwynn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10de03e4-db98-4b5c-9cf6-3f98a5cc0537@kernel.org \
--to=krzk@kernel.org \
--cc=Delphine_CC_Chiu@wiwynn.com \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@stwcx.xyz \
--cc=ricky.cx.wu.wiwynn@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).