* [PATCH v2 01/29] dt-bindings: soc: Add Realtek RTD1195 chip info binding
2020-06-23 2:50 [PATCH v2 00/29] ARM: Realtek DHC SoC info Andreas Färber
@ 2020-06-23 2:50 ` Andreas Färber
2020-07-14 2:13 ` Rob Herring
2020-06-23 2:50 ` [PATCH v2 03/29] arm64: dts: realtek: rtd129x: Add chip info node Andreas Färber
` (14 subsequent siblings)
15 siblings, 1 reply; 27+ messages in thread
From: Andreas Färber @ 2020-06-23 2:50 UTC (permalink / raw)
To: linux-realtek-soc
Cc: linux-arm-kernel, linux-kernel,
James Tai [戴志峰],
Stanley Chang [昌育德], Edgar Lee,
Andreas Färber, Rob Herring, devicetree
Define a binding for RTD1195 and later DHC SoCs' chip info registers.
Add the new directory to MAINTAINERS.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
Note: The binding gets extended compatibly twice with additional properties.
Could be squashed later if approved.
v1 -> v2:
* Dropped quotes for compatible (Rob)
* Added additionalProperties: false (Rob)
.../soc/realtek/realtek,rtd1195-chip.yaml | 34 +++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 35 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
diff --git a/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml b/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
new file mode 100644
index 000000000000..86a1de214782
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
@@ -0,0 +1,34 @@
+# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/realtek/realtek,rtd1195-chip.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Realtek Digital Home Center chip identification
+
+maintainers:
+ - Andreas Färber <afaerber@suse.de>
+
+description: |
+ The Realtek DHC SoCs have some registers to identify the chip and revision.
+
+properties:
+ compatible:
+ const: realtek,rtd1195-chip
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ chip-info@1801a200 {
+ compatible = "realtek,rtd1195-chip";
+ reg = <0x1801a200 0x8>;
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index d282ee3492e0..78adbc3cc101 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2307,6 +2307,7 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
L: linux-realtek-soc@lists.infradead.org (moderated for non-subscribers)
S: Maintained
F: Documentation/devicetree/bindings/arm/realtek.yaml
+F: Documentation/devicetree/bindings/soc/realtek/
F: arch/arm/boot/dts/rtd*
F: arch/arm/mach-realtek/
F: arch/arm64/boot/dts/realtek/
--
2.26.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH v2 01/29] dt-bindings: soc: Add Realtek RTD1195 chip info binding
2020-06-23 2:50 ` [PATCH v2 01/29] dt-bindings: soc: Add Realtek RTD1195 chip info binding Andreas Färber
@ 2020-07-14 2:13 ` Rob Herring
0 siblings, 0 replies; 27+ messages in thread
From: Rob Herring @ 2020-07-14 2:13 UTC (permalink / raw)
To: Andreas Färber
Cc: linux-arm-kernel, linux-kernel,
Stanley Chang [昌育德], linux-realtek-soc,
James Tai [戴志峰], devicetree, Edgar Lee,
Rob Herring
On Tue, 23 Jun 2020 04:50:38 +0200, Andreas Färber wrote:
> Define a binding for RTD1195 and later DHC SoCs' chip info registers.
> Add the new directory to MAINTAINERS.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> Note: The binding gets extended compatibly twice with additional properties.
> Could be squashed later if approved.
>
> v1 -> v2:
> * Dropped quotes for compatible (Rob)
> * Added additionalProperties: false (Rob)
>
> .../soc/realtek/realtek,rtd1195-chip.yaml | 34 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 03/29] arm64: dts: realtek: rtd129x: Add chip info node
2020-06-23 2:50 [PATCH v2 00/29] ARM: Realtek DHC SoC info Andreas Färber
2020-06-23 2:50 ` [PATCH v2 01/29] dt-bindings: soc: Add Realtek RTD1195 chip info binding Andreas Färber
@ 2020-06-23 2:50 ` Andreas Färber
2020-07-10 7:56 ` Stanley Chang[昌育德]
2020-06-23 2:50 ` [PATCH v2 04/29] ARM: dts: rtd1195: " Andreas Färber
` (13 subsequent siblings)
15 siblings, 1 reply; 27+ messages in thread
From: Andreas Färber @ 2020-06-23 2:50 UTC (permalink / raw)
To: linux-realtek-soc
Cc: linux-arm-kernel, linux-kernel,
James Tai [戴志峰],
Stanley Chang [昌育德], Edgar Lee,
Andreas Färber, Rob Herring, devicetree
Add a DT node for chip identification.
Acked-by: James Tai <james.tai@realtek.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
v1 -> v2:
* Rebased onto SB2 syscon
arch/arm64/boot/dts/realtek/rtd129x.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/realtek/rtd129x.dtsi b/arch/arm64/boot/dts/realtek/rtd129x.dtsi
index 93ab6fdd03d4..b5be9df80dae 100644
--- a/arch/arm64/boot/dts/realtek/rtd129x.dtsi
+++ b/arch/arm64/boot/dts/realtek/rtd129x.dtsi
@@ -201,6 +201,11 @@ sb2_hd_sem: hwspinlock@0 {
#hwlock-cells = <0>;
};
+ chip-info@200 {
+ compatible = "realtek,rtd1195-chip";
+ reg = <0x200 0x8>;
+ };
+
sb2_hd_sem_new: hwspinlock@620 {
compatible = "realtek,rtd1195-sb2-sem";
reg = <0x620 0x20>;
--
2.26.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* RE: [PATCH v2 03/29] arm64: dts: realtek: rtd129x: Add chip info node
2020-06-23 2:50 ` [PATCH v2 03/29] arm64: dts: realtek: rtd129x: Add chip info node Andreas Färber
@ 2020-07-10 7:56 ` Stanley Chang[昌育德]
0 siblings, 0 replies; 27+ messages in thread
From: Stanley Chang[昌育德] @ 2020-07-10 7:56 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
James Tai [戴志峰],
Edgar Lee [李承諭], Rob Herring,
devicetree@vger.kernel.org
Hi Andreas,
> -----Original Message-----
> From: Andreas Färber [mailto:afaerber@suse.de]
> Sent: Tuesday, June 23, 2020 10:51 AM
> To: linux-realtek-soc@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; James
> Tai [戴志峰]; Stanley Chang[昌育德]; Edgar Lee [李承諭]; Andreas Färber;
> Rob Herring; devicetree@vger.kernel.org
> Subject: [PATCH v2 03/29] arm64: dts: realtek: rtd129x: Add chip info node
>
> Add a DT node for chip identification.
>
> Acked-by: James Tai <james.tai@realtek.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
Reviewed-by: Stanley Chang <stanley_chang@realtek.com>
Thanks,
Stanley
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 04/29] ARM: dts: rtd1195: Add chip info node
2020-06-23 2:50 [PATCH v2 00/29] ARM: Realtek DHC SoC info Andreas Färber
2020-06-23 2:50 ` [PATCH v2 01/29] dt-bindings: soc: Add Realtek RTD1195 chip info binding Andreas Färber
2020-06-23 2:50 ` [PATCH v2 03/29] arm64: dts: realtek: rtd129x: Add chip info node Andreas Färber
@ 2020-06-23 2:50 ` Andreas Färber
2020-07-10 7:57 ` Stanley Chang[昌育德]
2020-06-23 2:50 ` [PATCH v2 05/29] dt-bindings: soc: realtek: rtd1195-chip: Add iso-syscon property Andreas Färber
` (12 subsequent siblings)
15 siblings, 1 reply; 27+ messages in thread
From: Andreas Färber @ 2020-06-23 2:50 UTC (permalink / raw)
To: linux-realtek-soc
Cc: linux-arm-kernel, linux-kernel,
James Tai [戴志峰],
Stanley Chang [昌育德], Edgar Lee,
Andreas Färber, Rob Herring, devicetree
Add a DT node for chip identification.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
v1 -> v2:
* Rebased onto SB2 syscon
arch/arm/boot/dts/rtd1195.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/rtd1195.dtsi b/arch/arm/boot/dts/rtd1195.dtsi
index 6fd12a2d766e..5ad0e81c37af 100644
--- a/arch/arm/boot/dts/rtd1195.dtsi
+++ b/arch/arm/boot/dts/rtd1195.dtsi
@@ -223,6 +223,11 @@ sb2_hd_sem: hwspinlock@0 {
#hwlock-cells = <0>;
};
+ chip-info@200 {
+ compatible = "realtek,rtd1195-chip";
+ reg = <0x200 0x8>;
+ };
+
sb2_hd_sem_new: hwspinlock@620 {
compatible = "realtek,rtd1195-sb2-sem";
reg = <0x620 0x20>;
--
2.26.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* RE: [PATCH v2 04/29] ARM: dts: rtd1195: Add chip info node
2020-06-23 2:50 ` [PATCH v2 04/29] ARM: dts: rtd1195: " Andreas Färber
@ 2020-07-10 7:57 ` Stanley Chang[昌育德]
0 siblings, 0 replies; 27+ messages in thread
From: Stanley Chang[昌育德] @ 2020-07-10 7:57 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
James Tai [戴志峰],
Edgar Lee [李承諭], Rob Herring,
devicetree@vger.kernel.org
Hi Andreas,
> -----Original Message-----
> From: Andreas Färber [mailto:afaerber@suse.de]
> Sent: Tuesday, June 23, 2020 10:51 AM
> To: linux-realtek-soc@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; James
> Tai [戴志峰]; Stanley Chang[昌育德]; Edgar Lee [李承諭]; Andreas Färber;
> Rob Herring; devicetree@vger.kernel.org
> Subject: [PATCH v2 04/29] ARM: dts: rtd1195: Add chip info node
>
> Add a DT node for chip identification.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Reviewed-by: Stanley Chang <stanley_chang@realtek.com>
Thanks,
Stanley
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 05/29] dt-bindings: soc: realtek: rtd1195-chip: Add iso-syscon property
2020-06-23 2:50 [PATCH v2 00/29] ARM: Realtek DHC SoC info Andreas Färber
` (2 preceding siblings ...)
2020-06-23 2:50 ` [PATCH v2 04/29] ARM: dts: rtd1195: " Andreas Färber
@ 2020-06-23 2:50 ` Andreas Färber
2020-07-14 2:13 ` Rob Herring
2020-06-23 2:50 ` [PATCH v2 07/29] arm64: dts: realtek: rtd129x: Extend chip-info reg with CHIP_INFO1 Andreas Färber
` (11 subsequent siblings)
15 siblings, 1 reply; 27+ messages in thread
From: Andreas Färber @ 2020-06-23 2:50 UTC (permalink / raw)
To: linux-realtek-soc
Cc: linux-arm-kernel, linux-kernel,
James Tai [戴志峰],
Stanley Chang [昌育德], Edgar Lee,
Andreas Färber, Rob Herring, devicetree
Allow to optionally specify a phandle to iso syscon to identify the chip.
RTD1295 family will want to check the ISO_CHIP_INFO1 register.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
A SoC specific binding would defeat the purpose of the generic Linux driver
detecting the SoC based on registers.
Simply allowing it all for SoC families seems the most flexible.
v1 -> v2:
* Instead of extending reg, allow optional iso-syscon property for RTD129x.
Iso syscon currently does not have a compatible, and it may need to differ
across SoC families.
.../bindings/soc/realtek/realtek,rtd1195-chip.yaml | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml b/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
index 86a1de214782..dfe33c95f68d 100644
--- a/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
+++ b/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
@@ -11,6 +11,7 @@ maintainers:
description: |
The Realtek DHC SoCs have some registers to identify the chip and revision.
+ To identify the exact model within a family, further registers are needed.
properties:
compatible:
@@ -19,6 +20,8 @@ properties:
reg:
maxItems: 1
+ iso-syscon: true
+
required:
- compatible
- reg
@@ -31,4 +34,10 @@ examples:
compatible = "realtek,rtd1195-chip";
reg = <0x1801a200 0x8>;
};
+ - |
+ chip-info@9801a200 {
+ compatible = "realtek,rtd1195-chip";
+ reg = <0x9801a200 0x8>;
+ iso-syscon = <&iso>;
+ };
...
--
2.26.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH v2 05/29] dt-bindings: soc: realtek: rtd1195-chip: Add iso-syscon property
2020-06-23 2:50 ` [PATCH v2 05/29] dt-bindings: soc: realtek: rtd1195-chip: Add iso-syscon property Andreas Färber
@ 2020-07-14 2:13 ` Rob Herring
0 siblings, 0 replies; 27+ messages in thread
From: Rob Herring @ 2020-07-14 2:13 UTC (permalink / raw)
To: Andreas Färber
Cc: linux-realtek-soc, linux-arm-kernel, linux-kernel,
James Tai [戴志峰],
Stanley Chang [昌育德], Edgar Lee, devicetree
On Tue, Jun 23, 2020 at 04:50:42AM +0200, Andreas Färber wrote:
> Allow to optionally specify a phandle to iso syscon to identify the chip.
> RTD1295 family will want to check the ISO_CHIP_INFO1 register.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> A SoC specific binding would defeat the purpose of the generic Linux driver
> detecting the SoC based on registers.
> Simply allowing it all for SoC families seems the most flexible.
>
> v1 -> v2:
> * Instead of extending reg, allow optional iso-syscon property for RTD129x.
> Iso syscon currently does not have a compatible, and it may need to differ
> across SoC families.
>
> .../bindings/soc/realtek/realtek,rtd1195-chip.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml b/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
> index 86a1de214782..dfe33c95f68d 100644
> --- a/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
> +++ b/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
> @@ -11,6 +11,7 @@ maintainers:
>
> description: |
> The Realtek DHC SoCs have some registers to identify the chip and revision.
> + To identify the exact model within a family, further registers are needed.
>
> properties:
> compatible:
> @@ -19,6 +20,8 @@ properties:
> reg:
> maxItems: 1
>
> + iso-syscon: true
Needs a type $ref (phandle).
> +
> required:
> - compatible
> - reg
> @@ -31,4 +34,10 @@ examples:
> compatible = "realtek,rtd1195-chip";
> reg = <0x1801a200 0x8>;
> };
> + - |
> + chip-info@9801a200 {
> + compatible = "realtek,rtd1195-chip";
> + reg = <0x9801a200 0x8>;
> + iso-syscon = <&iso>;
> + };
> ...
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 07/29] arm64: dts: realtek: rtd129x: Extend chip-info reg with CHIP_INFO1
2020-06-23 2:50 [PATCH v2 00/29] ARM: Realtek DHC SoC info Andreas Färber
` (3 preceding siblings ...)
2020-06-23 2:50 ` [PATCH v2 05/29] dt-bindings: soc: realtek: rtd1195-chip: Add iso-syscon property Andreas Färber
@ 2020-06-23 2:50 ` Andreas Färber
2020-07-10 7:59 ` Stanley Chang[昌育德]
2020-06-23 2:50 ` [PATCH v2 10/29] arm64: dts: realtek: rtd139x: Add chip info node Andreas Färber
` (10 subsequent siblings)
15 siblings, 1 reply; 27+ messages in thread
From: Andreas Färber @ 2020-06-23 2:50 UTC (permalink / raw)
To: linux-realtek-soc
Cc: linux-arm-kernel, linux-kernel,
James Tai [戴志峰],
Stanley Chang [昌育德], Edgar Lee,
Andreas Färber, Rob Herring, devicetree
This additional register is needed to distinguish RTD1296 from RTD1295.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
v1 -> v2:
* Switched from reg to new iso-syscon phandle
arch/arm64/boot/dts/realtek/rtd129x.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/realtek/rtd129x.dtsi b/arch/arm64/boot/dts/realtek/rtd129x.dtsi
index b5be9df80dae..30a7782aa0d9 100644
--- a/arch/arm64/boot/dts/realtek/rtd129x.dtsi
+++ b/arch/arm64/boot/dts/realtek/rtd129x.dtsi
@@ -204,6 +204,7 @@ sb2_hd_sem: hwspinlock@0 {
chip-info@200 {
compatible = "realtek,rtd1195-chip";
reg = <0x200 0x8>;
+ iso-syscon = <&iso>;
};
sb2_hd_sem_new: hwspinlock@620 {
--
2.26.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* RE: [PATCH v2 07/29] arm64: dts: realtek: rtd129x: Extend chip-info reg with CHIP_INFO1
2020-06-23 2:50 ` [PATCH v2 07/29] arm64: dts: realtek: rtd129x: Extend chip-info reg with CHIP_INFO1 Andreas Färber
@ 2020-07-10 7:59 ` Stanley Chang[昌育德]
0 siblings, 0 replies; 27+ messages in thread
From: Stanley Chang[昌育德] @ 2020-07-10 7:59 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
James Tai [戴志峰],
Edgar Lee [李承諭], Rob Herring,
devicetree@vger.kernel.org
Hi Andreas,
> -----Original Message-----
> From: Andreas Färber [mailto:afaerber@suse.de]
> Sent: Tuesday, June 23, 2020 10:51 AM
> To: linux-realtek-soc@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; James
> Tai [戴志峰]; Stanley Chang[昌育德]; Edgar Lee [李承諭]; Andreas Färber;
> Rob Herring; devicetree@vger.kernel.org
> Subject: [PATCH v2 07/29] arm64: dts: realtek: rtd129x: Extend chip-info reg
> with CHIP_INFO1
>
> This additional register is needed to distinguish RTD1296 from RTD1295.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Reviewed-by: Stanley Chang <stanley_chang@realtek.com>
Thanks,
Stanley
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 10/29] arm64: dts: realtek: rtd139x: Add chip info node
2020-06-23 2:50 [PATCH v2 00/29] ARM: Realtek DHC SoC info Andreas Färber
` (4 preceding siblings ...)
2020-06-23 2:50 ` [PATCH v2 07/29] arm64: dts: realtek: rtd129x: Extend chip-info reg with CHIP_INFO1 Andreas Färber
@ 2020-06-23 2:50 ` Andreas Färber
2020-07-10 8:03 ` Stanley Chang[昌育德]
2020-06-23 2:50 ` [PATCH v2 12/29] arm64: dts: realtek: rtd16xx: " Andreas Färber
` (9 subsequent siblings)
15 siblings, 1 reply; 27+ messages in thread
From: Andreas Färber @ 2020-06-23 2:50 UTC (permalink / raw)
To: linux-realtek-soc
Cc: linux-arm-kernel, linux-kernel,
James Tai [戴志峰],
Stanley Chang [昌育德], Edgar Lee,
Andreas Färber, Rob Herring, devicetree
Add a DT node for chip identification.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
v2: New
arch/arm64/boot/dts/realtek/rtd139x.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/realtek/rtd139x.dtsi b/arch/arm64/boot/dts/realtek/rtd139x.dtsi
index 586b05350274..3d4d2323294b 100644
--- a/arch/arm64/boot/dts/realtek/rtd139x.dtsi
+++ b/arch/arm64/boot/dts/realtek/rtd139x.dtsi
@@ -199,6 +199,11 @@ sb2_hd_sem: hwspinlock@0 {
#hwlock-cells = <0>;
};
+ chip-info@200 {
+ compatible = "realtek,rtd1195-chip";
+ reg = <0x200 0x8>;
+ };
+
sb2_hd_sem_new: hwspinlock@620 {
compatible = "realtek,rtd1195-sb2-sem";
reg = <0x620 0x20>;
--
2.26.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* RE: [PATCH v2 10/29] arm64: dts: realtek: rtd139x: Add chip info node
2020-06-23 2:50 ` [PATCH v2 10/29] arm64: dts: realtek: rtd139x: Add chip info node Andreas Färber
@ 2020-07-10 8:03 ` Stanley Chang[昌育德]
0 siblings, 0 replies; 27+ messages in thread
From: Stanley Chang[昌育德] @ 2020-07-10 8:03 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
James Tai [戴志峰],
Edgar Lee [李承諭], Rob Herring,
devicetree@vger.kernel.org
Hi Andreas,
> -----Original Message-----
> From: Andreas Färber [mailto:afaerber@suse.de]
> Sent: Tuesday, June 23, 2020 10:51 AM
> To: linux-realtek-soc@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; James
> Tai [戴志峰]; Stanley Chang[昌育德]; Edgar Lee [李承諭]; Andreas Färber;
> Rob Herring; devicetree@vger.kernel.org
> Subject: [PATCH v2 10/29] arm64: dts: realtek: rtd139x: Add chip info node
>
> Add a DT node for chip identification.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Tested-by: Stanley Chang <stanley_chang@realtek.com>
Reviewed-by: Stanley Chang <stanley_chang@realtek.com>
Thanks,
Stanley
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 12/29] arm64: dts: realtek: rtd16xx: Add chip info node
2020-06-23 2:50 [PATCH v2 00/29] ARM: Realtek DHC SoC info Andreas Färber
` (5 preceding siblings ...)
2020-06-23 2:50 ` [PATCH v2 10/29] arm64: dts: realtek: rtd139x: Add chip info node Andreas Färber
@ 2020-06-23 2:50 ` Andreas Färber
2020-07-10 8:02 ` Stanley Chang[昌育德]
2020-06-23 2:50 ` [PATCH v2 15/29] arm64: dts: realtek: rtd13xx: " Andreas Färber
` (8 subsequent siblings)
15 siblings, 1 reply; 27+ messages in thread
From: Andreas Färber @ 2020-06-23 2:50 UTC (permalink / raw)
To: linux-realtek-soc
Cc: linux-arm-kernel, linux-kernel,
James Tai [戴志峰],
Stanley Chang [昌育德], Edgar Lee,
Andreas Färber, Rob Herring, devicetree
Add a DT node for chip identification.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
v2: New
arch/arm64/boot/dts/realtek/rtd16xx.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
index afba5f04c8ec..04cb546142a0 100644
--- a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
+++ b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
@@ -227,3 +227,10 @@ uart2: serial2@400 {
status = "disabled";
};
};
+
+&sb2 {
+ chip-info@200 {
+ compatible = "realtek,rtd1195-chip";
+ reg = <0x200 0x8>;
+ };
+};
--
2.26.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* RE: [PATCH v2 12/29] arm64: dts: realtek: rtd16xx: Add chip info node
2020-06-23 2:50 ` [PATCH v2 12/29] arm64: dts: realtek: rtd16xx: " Andreas Färber
@ 2020-07-10 8:02 ` Stanley Chang[昌育德]
0 siblings, 0 replies; 27+ messages in thread
From: Stanley Chang[昌育德] @ 2020-07-10 8:02 UTC (permalink / raw)
To: Andreas Färber, linux-realtek-soc@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
James Tai [戴志峰],
Edgar Lee [李承諭], Rob Herring,
devicetree@vger.kernel.org
Hi Andreas,
> -----Original Message-----
> From: Andreas Färber [mailto:afaerber@suse.de]
> Sent: Tuesday, June 23, 2020 10:51 AM
> To: linux-realtek-soc@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; James
> Tai [戴志峰]; Stanley Chang[昌育德]; Edgar Lee [李承諭]; Andreas Färber;
> Rob Herring; devicetree@vger.kernel.org
> Subject: [PATCH v2 12/29] arm64: dts: realtek: rtd16xx: Add chip info node
>
> Add a DT node for chip identification.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Tested-by: Stanley Chang <stanley_chang@realtek.com>
Reviewed-by: Stanley Chang <stanley_chang@realtek.com>
Thanks,
Stanley
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 15/29] arm64: dts: realtek: rtd13xx: Add chip info node
2020-06-23 2:50 [PATCH v2 00/29] ARM: Realtek DHC SoC info Andreas Färber
` (6 preceding siblings ...)
2020-06-23 2:50 ` [PATCH v2 12/29] arm64: dts: realtek: rtd16xx: " Andreas Färber
@ 2020-06-23 2:50 ` Andreas Färber
2020-07-10 8:06 ` Stanley Chang[昌育德]
2020-06-23 2:50 ` [PATCH v2 17/29] dt-bindings: nvmem: Add Realtek RTD1195 eFuse Andreas Färber
` (7 subsequent siblings)
15 siblings, 1 reply; 27+ messages in thread
From: Andreas Färber @ 2020-06-23 2:50 UTC (permalink / raw)
To: linux-realtek-soc
Cc: linux-arm-kernel, linux-kernel,
James Tai [戴志峰],
Stanley Chang [昌育德], Edgar Lee,
Andreas Färber, Rob Herring, devicetree
Add a DT node for chip identification.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
v2: New
arch/arm64/boot/dts/realtek/rtd13xx.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/realtek/rtd13xx.dtsi b/arch/arm64/boot/dts/realtek/rtd13xx.dtsi
index e41be02f2e3a..e4271ef5cb1e 100644
--- a/arch/arm64/boot/dts/realtek/rtd13xx.dtsi
+++ b/arch/arm64/boot/dts/realtek/rtd13xx.dtsi
@@ -211,3 +211,10 @@ uart2: serial@400 {
status = "disabled";
};
};
+
+&sb2 {
+ chip-info@200 {
+ compatible = "realtek,rtd1195-chip";
+ reg = <0x200 0x8>;
+ };
+};
--
2.26.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH v2 17/29] dt-bindings: nvmem: Add Realtek RTD1195 eFuse
2020-06-23 2:50 [PATCH v2 00/29] ARM: Realtek DHC SoC info Andreas Färber
` (7 preceding siblings ...)
2020-06-23 2:50 ` [PATCH v2 15/29] arm64: dts: realtek: rtd13xx: " Andreas Färber
@ 2020-06-23 2:50 ` Andreas Färber
2020-07-14 2:15 ` Rob Herring
2020-06-23 2:50 ` [PATCH v2 19/29] ARM: dts: rtd1195: Add eFuse node Andreas Färber
` (6 subsequent siblings)
15 siblings, 1 reply; 27+ messages in thread
From: Andreas Färber @ 2020-06-23 2:50 UTC (permalink / raw)
To: linux-realtek-soc
Cc: linux-arm-kernel, linux-kernel,
James Tai [戴志峰],
Stanley Chang [昌育德], Edgar Lee,
Andreas Färber, Srinivas Kandagatla, Rob Herring, devicetree
Add a DT binding for eFuse on Realtek Digital Home Center SoCs.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
v2: New
.../bindings/nvmem/realtek,rtd1195-efuse.yaml | 53 +++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 54 insertions(+)
create mode 100644 Documentation/devicetree/bindings/nvmem/realtek,rtd1195-efuse.yaml
diff --git a/Documentation/devicetree/bindings/nvmem/realtek,rtd1195-efuse.yaml b/Documentation/devicetree/bindings/nvmem/realtek,rtd1195-efuse.yaml
new file mode 100644
index 000000000000..a616cb22673e
--- /dev/null
+++ b/Documentation/devicetree/bindings/nvmem/realtek,rtd1195-efuse.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/nvmem/realtek,rtd1195-efuse.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Realtek Digital Home Center eFuse
+
+maintainers:
+ - Andreas Färber <afaerber@suse.de>
+
+description: |
+ The Realtek DHC SoCs have an eFuse block with non-volatile OTP memory.
+
+allOf:
+ - $ref: "nvmem.yaml#"
+
+properties:
+ compatible:
+ const: realtek,rtd1195-efuse
+
+ reg:
+ maxItems: 1
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 1
+
+required:
+ - compatible
+ - reg
+
+examples:
+ - |
+ efuse@18017000 {
+ compatible = "realtek,rtd1195-efuse";
+ reg = <0x18017000 0x400>;
+ };
+ - |
+ efuse@98017000 {
+ compatible = "realtek,rtd1195-efuse";
+ reg = <0x98017000 0x400>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ efuse_package_id: package-id@1d8 {
+ reg = <0x1d8 0x1>;
+ bits = <0 2>;
+ };
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index ff0ee48fee6f..1d0d6ab20451 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2307,6 +2307,7 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
L: linux-realtek-soc@lists.infradead.org (moderated for non-subscribers)
S: Maintained
F: Documentation/devicetree/bindings/arm/realtek.yaml
+F: Documentation/devicetree/bindings/nvmem/realtek,rtd1195-efuse.yaml
F: Documentation/devicetree/bindings/soc/realtek/
F: arch/arm/boot/dts/rtd*
F: arch/arm/mach-realtek/
--
2.26.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH v2 17/29] dt-bindings: nvmem: Add Realtek RTD1195 eFuse
2020-06-23 2:50 ` [PATCH v2 17/29] dt-bindings: nvmem: Add Realtek RTD1195 eFuse Andreas Färber
@ 2020-07-14 2:15 ` Rob Herring
0 siblings, 0 replies; 27+ messages in thread
From: Rob Herring @ 2020-07-14 2:15 UTC (permalink / raw)
To: Andreas Färber
Cc: Edgar Lee, Stanley Chang [昌育德],
linux-arm-kernel, Srinivas Kandagatla, linux-kernel, Rob Herring,
James Tai [戴志峰], linux-realtek-soc,
devicetree
On Tue, 23 Jun 2020 04:50:54 +0200, Andreas Färber wrote:
> Add a DT binding for eFuse on Realtek Digital Home Center SoCs.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> v2: New
>
> .../bindings/nvmem/realtek,rtd1195-efuse.yaml | 53 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 54 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/nvmem/realtek,rtd1195-efuse.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 19/29] ARM: dts: rtd1195: Add eFuse node
2020-06-23 2:50 [PATCH v2 00/29] ARM: Realtek DHC SoC info Andreas Färber
` (8 preceding siblings ...)
2020-06-23 2:50 ` [PATCH v2 17/29] dt-bindings: nvmem: Add Realtek RTD1195 eFuse Andreas Färber
@ 2020-06-23 2:50 ` Andreas Färber
2020-06-23 2:50 ` [PATCH v2 20/29] arm64: dts: realtek: rtd129x: " Andreas Färber
` (5 subsequent siblings)
15 siblings, 0 replies; 27+ messages in thread
From: Andreas Färber @ 2020-06-23 2:50 UTC (permalink / raw)
To: linux-realtek-soc
Cc: linux-arm-kernel, linux-kernel,
James Tai [戴志峰],
Stanley Chang [昌育德], Edgar Lee,
Andreas Färber, Rob Herring, devicetree
Add a DT node for eFuse.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
v2: New
arch/arm/boot/dts/rtd1195.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/rtd1195.dtsi b/arch/arm/boot/dts/rtd1195.dtsi
index 5ad0e81c37af..2ae08f6da9e8 100644
--- a/arch/arm/boot/dts/rtd1195.dtsi
+++ b/arch/arm/boot/dts/rtd1195.dtsi
@@ -119,6 +119,14 @@ iso: syscon@7000 {
ranges = <0x0 0x7000 0x1000>;
};
+ efuse: efuse@17000 {
+ compatible = "realtek,rtd1195-efuse";
+ reg = <0x17000 0x400>;
+ read-only;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ };
+
sb2: syscon@1a000 {
compatible = "syscon", "simple-mfd";
reg = <0x1a000 0x1000>;
--
2.26.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH v2 20/29] arm64: dts: realtek: rtd129x: Add eFuse node
2020-06-23 2:50 [PATCH v2 00/29] ARM: Realtek DHC SoC info Andreas Färber
` (9 preceding siblings ...)
2020-06-23 2:50 ` [PATCH v2 19/29] ARM: dts: rtd1195: Add eFuse node Andreas Färber
@ 2020-06-23 2:50 ` Andreas Färber
2020-06-23 2:50 ` [PATCH v2 21/29] arm64: dts: realtek: rtd139x: " Andreas Färber
` (4 subsequent siblings)
15 siblings, 0 replies; 27+ messages in thread
From: Andreas Färber @ 2020-06-23 2:50 UTC (permalink / raw)
To: linux-realtek-soc
Cc: linux-arm-kernel, linux-kernel,
James Tai [戴志峰],
Stanley Chang [昌育德], Edgar Lee,
Andreas Färber, Rob Herring, devicetree
Add a DT node for eFuse.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
v2: New
arch/arm64/boot/dts/realtek/rtd129x.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/realtek/rtd129x.dtsi b/arch/arm64/boot/dts/realtek/rtd129x.dtsi
index 30a7782aa0d9..8f96d4e4c46b 100644
--- a/arch/arm64/boot/dts/realtek/rtd129x.dtsi
+++ b/arch/arm64/boot/dts/realtek/rtd129x.dtsi
@@ -81,6 +81,14 @@ iso: syscon@7000 {
ranges = <0x0 0x7000 0x1000>;
};
+ efuse: efuse@17000 {
+ compatible = "realtek,rtd1195-efuse";
+ reg = <0x17000 0x400>;
+ read-only;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ };
+
sb2: syscon@1a000 {
compatible = "syscon", "simple-mfd";
reg = <0x1a000 0x1000>;
@@ -194,6 +202,13 @@ uart2: serial@400 {
};
};
+&otp {
+ otp_package_id: package-id@1d8 {
+ reg = <0x1d8 0x1>;
+ bits = <0 2>;
+ };
+};
+
&sb2 {
sb2_hd_sem: hwspinlock@0 {
compatible = "realtek,rtd1195-sb2-sem";
--
2.26.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH v2 21/29] arm64: dts: realtek: rtd139x: Add eFuse node
2020-06-23 2:50 [PATCH v2 00/29] ARM: Realtek DHC SoC info Andreas Färber
` (10 preceding siblings ...)
2020-06-23 2:50 ` [PATCH v2 20/29] arm64: dts: realtek: rtd129x: " Andreas Färber
@ 2020-06-23 2:50 ` Andreas Färber
2020-06-23 2:50 ` [PATCH v2 22/29] arm64: dts: realtek: rtd16xx: " Andreas Färber
` (3 subsequent siblings)
15 siblings, 0 replies; 27+ messages in thread
From: Andreas Färber @ 2020-06-23 2:50 UTC (permalink / raw)
To: linux-realtek-soc
Cc: linux-arm-kernel, linux-kernel,
James Tai [戴志峰],
Stanley Chang [昌育德], Edgar Lee,
Andreas Färber, Rob Herring, devicetree
Add a DT node for eFuse.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
v2: New
arch/arm64/boot/dts/realtek/rtd139x.dtsi | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/realtek/rtd139x.dtsi b/arch/arm64/boot/dts/realtek/rtd139x.dtsi
index 3d4d2323294b..48746d432328 100644
--- a/arch/arm64/boot/dts/realtek/rtd139x.dtsi
+++ b/arch/arm64/boot/dts/realtek/rtd139x.dtsi
@@ -2,7 +2,7 @@
/*
* Realtek RTD1395 SoC family
*
- * Copyright (c) 2019 Andreas Färber
+ * Copyright (c) 2019-2020 Andreas Färber
*/
/memreserve/ 0x0000000000000000 0x000000000002f000;
@@ -79,6 +79,14 @@ iso: syscon@7000 {
ranges = <0x0 0x7000 0x1000>;
};
+ efuse: efuse@17000 {
+ compatible = "realtek,rtd1195-efuse";
+ reg = <0x17000 0x400>;
+ read-only;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ };
+
sb2: syscon@1a000 {
compatible = "syscon", "simple-mfd";
reg = <0x1a000 0x1000>;
--
2.26.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH v2 22/29] arm64: dts: realtek: rtd16xx: Add eFuse node
2020-06-23 2:50 [PATCH v2 00/29] ARM: Realtek DHC SoC info Andreas Färber
` (11 preceding siblings ...)
2020-06-23 2:50 ` [PATCH v2 21/29] arm64: dts: realtek: rtd139x: " Andreas Färber
@ 2020-06-23 2:50 ` Andreas Färber
2020-06-23 2:51 ` [PATCH v2 23/29] arm64: dts: realtek: rtd13xx: " Andreas Färber
` (2 subsequent siblings)
15 siblings, 0 replies; 27+ messages in thread
From: Andreas Färber @ 2020-06-23 2:50 UTC (permalink / raw)
To: linux-realtek-soc
Cc: linux-arm-kernel, linux-kernel,
James Tai [戴志峰],
Stanley Chang [昌育德], Edgar Lee,
Andreas Färber, Rob Herring, devicetree
Add a DT node for eFuse.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
v2: New
arch/arm64/boot/dts/realtek/rtd16xx.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
index 04cb546142a0..3c955fc7450c 100644
--- a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
+++ b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
@@ -155,6 +155,14 @@ iso: syscon@7000 {
ranges = <0x0 0x7000 0x1000>;
};
+ efuse: efuse@17000 {
+ compatible = "realtek,rtd1195-efuse";
+ reg = <0x17000 0x1000>;
+ read-only;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ };
+
sb2: syscon@1a000 {
compatible = "syscon", "simple-mfd";
reg = <0x1a000 0x1000>;
--
2.26.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH v2 23/29] arm64: dts: realtek: rtd13xx: Add eFuse node
2020-06-23 2:50 [PATCH v2 00/29] ARM: Realtek DHC SoC info Andreas Färber
` (12 preceding siblings ...)
2020-06-23 2:50 ` [PATCH v2 22/29] arm64: dts: realtek: rtd16xx: " Andreas Färber
@ 2020-06-23 2:51 ` Andreas Färber
2020-06-23 2:51 ` [PATCH v2 24/29] dt-bindings: soc: realtek: rtd1195-chip: Allow nvmem-cells property Andreas Färber
2020-06-23 2:51 ` [PATCH v2 25/29] arm64: dts: realtek: rtd129x: Add eFuse package_id to chip-info Andreas Färber
15 siblings, 0 replies; 27+ messages in thread
From: Andreas Färber @ 2020-06-23 2:51 UTC (permalink / raw)
To: linux-realtek-soc
Cc: linux-arm-kernel, linux-kernel,
James Tai [戴志峰],
Stanley Chang [昌育德], Edgar Lee,
Andreas Färber, Rob Herring, devicetree
Add a DT node for eFuse.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
v2: New
arch/arm64/boot/dts/realtek/rtd13xx.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/realtek/rtd13xx.dtsi b/arch/arm64/boot/dts/realtek/rtd13xx.dtsi
index e4271ef5cb1e..ed5ee7cc6a44 100644
--- a/arch/arm64/boot/dts/realtek/rtd13xx.dtsi
+++ b/arch/arm64/boot/dts/realtek/rtd13xx.dtsi
@@ -139,6 +139,14 @@ iso: syscon@7000 {
ranges = <0x0 0x7000 0x1000>;
};
+ efuse: efuse@17000 {
+ compatible = "realtek,rtd1195-efuse";
+ reg = <0x17000 0x1000>;
+ read-only;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ };
+
sb2: syscon@1a000 {
compatible = "syscon", "simple-mfd";
reg = <0x1a000 0x1000>;
--
2.26.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH v2 24/29] dt-bindings: soc: realtek: rtd1195-chip: Allow nvmem-cells property
2020-06-23 2:50 [PATCH v2 00/29] ARM: Realtek DHC SoC info Andreas Färber
` (13 preceding siblings ...)
2020-06-23 2:51 ` [PATCH v2 23/29] arm64: dts: realtek: rtd13xx: " Andreas Färber
@ 2020-06-23 2:51 ` Andreas Färber
2020-07-14 2:15 ` Rob Herring
2020-06-23 2:51 ` [PATCH v2 25/29] arm64: dts: realtek: rtd129x: Add eFuse package_id to chip-info Andreas Färber
15 siblings, 1 reply; 27+ messages in thread
From: Andreas Färber @ 2020-06-23 2:51 UTC (permalink / raw)
To: linux-realtek-soc
Cc: linux-arm-kernel, linux-kernel,
James Tai [戴志峰],
Stanley Chang [昌育德], Edgar Lee,
Andreas Färber, Rob Herring, devicetree
Allow to optionally specify nvmem cells to identify the chip.
RTD1295 family will want the eFuse package_id cell.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
v1 -> v2:
* Instead of extending reg, allow nvmem-cells reference for eFuse
.../bindings/soc/realtek/realtek,rtd1195-chip.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml b/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
index dfe33c95f68d..57a6e0df4494 100644
--- a/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
+++ b/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
@@ -22,6 +22,10 @@ properties:
iso-syscon: true
+ nvmem-cells: true
+
+ nvmem-cell-names: true
+
required:
- compatible
- reg
@@ -40,4 +44,12 @@ examples:
reg = <0x9801a200 0x8>;
iso-syscon = <&iso>;
};
+ - |
+ chip-info@9801a200 {
+ compatible = "realtek,rtd1195-chip";
+ reg = <0x9801a200 0x8>;
+ iso-syscon = <&iso>;
+ nvmem-cells = <&efuse_package_id>;
+ nvmem-cell-names = "efuse_package_id";
+ };
...
--
2.26.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH v2 24/29] dt-bindings: soc: realtek: rtd1195-chip: Allow nvmem-cells property
2020-06-23 2:51 ` [PATCH v2 24/29] dt-bindings: soc: realtek: rtd1195-chip: Allow nvmem-cells property Andreas Färber
@ 2020-07-14 2:15 ` Rob Herring
0 siblings, 0 replies; 27+ messages in thread
From: Rob Herring @ 2020-07-14 2:15 UTC (permalink / raw)
To: Andreas Färber
Cc: James Tai [戴志峰],
Stanley Chang [昌育德], linux-arm-kernel,
Rob Herring, linux-realtek-soc, devicetree, linux-kernel,
Edgar Lee
On Tue, 23 Jun 2020 04:51:01 +0200, Andreas Färber wrote:
> Allow to optionally specify nvmem cells to identify the chip.
> RTD1295 family will want the eFuse package_id cell.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> v1 -> v2:
> * Instead of extending reg, allow nvmem-cells reference for eFuse
>
> .../bindings/soc/realtek/realtek,rtd1195-chip.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 25/29] arm64: dts: realtek: rtd129x: Add eFuse package_id to chip-info
2020-06-23 2:50 [PATCH v2 00/29] ARM: Realtek DHC SoC info Andreas Färber
` (14 preceding siblings ...)
2020-06-23 2:51 ` [PATCH v2 24/29] dt-bindings: soc: realtek: rtd1195-chip: Allow nvmem-cells property Andreas Färber
@ 2020-06-23 2:51 ` Andreas Färber
15 siblings, 0 replies; 27+ messages in thread
From: Andreas Färber @ 2020-06-23 2:51 UTC (permalink / raw)
To: linux-realtek-soc
Cc: linux-arm-kernel, linux-kernel,
James Tai [戴志峰],
Stanley Chang [昌育德], Edgar Lee,
Andreas Färber, Rob Herring, devicetree
Add the package_id field as sub-node to eFuse and reference it for
chip identification.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
v1 -> v2:
* Instead of extending reg, use nvmem-cells reference for eFuse
arch/arm64/boot/dts/realtek/rtd129x.dtsi | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/boot/dts/realtek/rtd129x.dtsi b/arch/arm64/boot/dts/realtek/rtd129x.dtsi
index 8f96d4e4c46b..c35955e915f4 100644
--- a/arch/arm64/boot/dts/realtek/rtd129x.dtsi
+++ b/arch/arm64/boot/dts/realtek/rtd129x.dtsi
@@ -156,6 +156,13 @@ reset4: reset-controller@50 {
};
};
+&efuse {
+ efuse_package_id: package-id@1d8 {
+ reg = <0x1d8 0x1>;
+ bits = <0 2>;
+ };
+};
+
&iso {
iso_reset: reset-controller@88 {
compatible = "snps,dw-low-reset";
@@ -202,13 +209,6 @@ uart2: serial@400 {
};
};
-&otp {
- otp_package_id: package-id@1d8 {
- reg = <0x1d8 0x1>;
- bits = <0 2>;
- };
-};
-
&sb2 {
sb2_hd_sem: hwspinlock@0 {
compatible = "realtek,rtd1195-sb2-sem";
@@ -220,6 +220,8 @@ chip-info@200 {
compatible = "realtek,rtd1195-chip";
reg = <0x200 0x8>;
iso-syscon = <&iso>;
+ nvmem-cells = <&efuse_package_id>;
+ nvmem-cell-names = "efuse_package_id";
};
sb2_hd_sem_new: hwspinlock@620 {
--
2.26.2
^ permalink raw reply related [flat|nested] 27+ messages in thread