Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sherry Sun <sherry.sun@nxp.com>,
	"sashiko-reviews@lists.linux.dev"
	<sashiko-reviews@lists.linux.dev>,
	"manivannan.sadhasivam@oss.qualcomm.com"
	<manivannan.sadhasivam@oss.qualcomm.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"Frank.Li@kernel.org" <Frank.Li@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: Re: [PATCH 1/2] dt-bindings: connector: pcie-m2-e: Add 3.3Vaux supply support
Date: Wed, 10 Jun 2026 10:42:17 +0200	[thread overview]
Message-ID: <10f5d51a-2e0e-477f-8431-9a305d57118c@kernel.org> (raw)
In-Reply-To: <VI0PR04MB121140EFB8E614326D799503A921A2@VI0PR04MB12114.eurprd04.prod.outlook.com>

On 10/06/2026 10:40, Sherry Sun wrote:
>> On Tue, Jun 09, 2026 at 03:44:08AM +0000, sashiko-bot@kernel.org wrote:
>>> Thank you for your contribution! Sashiko AI review found 1 potential
>> issue(s) to consider:
>>> - [Medium] The `vpcie3v3aux-supply` property describes a non-existent
>> hardware feature on the M.2 Key E connector to work around a software
>> policy.
>>
>> Feels valid. Describe which pin on M2 connector are you representing.
>>
> 
> Refer to PCI Express M.2 Specification r5.1 sec3.1.1 Power Sources and
> Grounds.
> 
> PCI Express M.2 Socket 1 utilizes a 3.3 V power source. The voltage
> source, 3.3 V, is expected to be available during the system’s
> stand-by/suspend state to support wake event processing on the
> communications card.

Again:
Describe which pin on M2 connector are you representing.

Best regards,
Krzysztof

  reply	other threads:[~2026-06-10  8:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09  3:38 [PATCH 0/2] power: sequencing: pcie-m2: Add 3.3Vaux supply support Sherry Sun (OSS)
2026-06-09  3:38 ` [PATCH 1/2] dt-bindings: connector: pcie-m2-e: " Sherry Sun (OSS)
2026-06-09  3:44   ` sashiko-bot
2026-06-09  7:35     ` Krzysztof Kozlowski
2026-06-10  8:40       ` Sherry Sun
2026-06-10  8:42         ` Krzysztof Kozlowski [this message]
2026-06-10  9:00           ` Sherry Sun
2026-06-10  9:28         ` Manivannan Sadhasivam
2026-06-10 10:13           ` Sherry Sun
2026-06-10 10:27             ` Manivannan Sadhasivam
2026-06-11  3:59               ` Sherry Sun
2026-06-11  6:10                 ` Manivannan Sadhasivam
2026-06-12 10:52                   ` Sherry Sun
2026-06-30 11:44                     ` Manivannan Sadhasivam
2026-06-09  3:38 ` [PATCH 2/2] power: sequencing: pcie-m2: " Sherry Sun (OSS)
2026-06-09  3:54   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10f5d51a-2e0e-477f-8431-9a305d57118c@kernel.org \
    --to=krzk@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=linux-pci@vger.kernel.org \
    --cc=manivannan.sadhasivam@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sherry.sun@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox