From: Caleb Connolly <caleb.connolly@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, sumit.semwal@linaro.org,
amit.pundir@linaro.org,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH v13 3/9] mfd: qcom-spmi-pmic: read fab id on supported PMICs
Date: Tue, 26 Apr 2022 18:41:54 +0100 [thread overview]
Message-ID: <10f7cb8e-4c2a-0bba-df55-16b56d429147@linaro.org> (raw)
In-Reply-To: <Yma4tXvPQ+U89Whr@google.com>
On 25/04/2022 16:05, Lee Jones wrote:
> On Wed, 23 Mar 2022, Caleb Connolly wrote:
>
>> From: Caleb Connolly <caleb.connolly@linaro.org>
>>
>> The PMI8998 and PM660 expose the fab_id, this is needed by drivers like
>> the RRADC to calibrate ADC values.
>>
>> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>> drivers/mfd/qcom-spmi-pmic.c | 7 +++++++
>> include/soc/qcom/qcom-spmi-pmic.h | 1 +
>> 2 files changed, 8 insertions(+)
>
> Please change the Subject line to match the style of the sub-system?
Hi, sorry if this is a silly question, I don't quite understand what you want me
to change here, the subject line is in the same "mfd: driver:" format as other
patches in the subsystem?
>
> Once changed:
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
>
--
Kind Regards,
Caleb (they/he)
next prev parent reply other threads:[~2022-04-26 17:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 16:28 [PATCH v13 0/9] iio: adc: introduce Qualcomm SPMI Round Robin ADC Caleb Connolly
2022-03-23 16:28 ` [PATCH v13 1/9] spmi: add a helper to look up an SPMI device from a device node Caleb Connolly
2022-03-23 16:28 ` [PATCH v13 2/9] mfd: qcom-spmi-pmic: expose the PMIC revid information to clients Caleb Connolly
2022-04-25 15:03 ` Lee Jones
2022-04-27 22:27 ` Caleb Connolly
2022-04-28 16:14 ` Lee Jones
2022-04-28 16:30 ` Caleb Connolly
2022-04-29 10:06 ` Lee Jones
2022-04-29 12:36 ` Caleb Connolly
2022-03-23 16:28 ` [PATCH v13 3/9] mfd: qcom-spmi-pmic: read fab id on supported PMICs Caleb Connolly
2022-04-25 15:05 ` Lee Jones
2022-04-26 17:41 ` Caleb Connolly [this message]
2022-04-26 18:24 ` Lee Jones
2022-04-27 18:45 ` Caleb Connolly
2022-04-28 16:15 ` Lee Jones
2022-03-23 16:28 ` [PATCH v13 4/9] dt-bindings: iio: adc: document qcom-spmi-rradc Caleb Connolly
2022-03-23 16:36 ` Krzysztof Kozlowski
2022-03-27 15:02 ` Jonathan Cameron
2022-03-23 16:28 ` [PATCH v13 5/9] iio: adc: qcom-spmi-rradc: introduce round robin adc Caleb Connolly
2022-03-27 15:03 ` Jonathan Cameron
2022-04-13 3:08 ` Bjorn Andersson
2022-04-13 13:13 ` Jonathan Cameron
2022-03-23 16:28 ` [PATCH v13 6/9] arm64: dts: qcom: pmi8998: add rradc node Caleb Connolly
2022-03-23 16:28 ` [PATCH v13 7/9] arm64: dts: qcom: sdm845-oneplus: enable rradc Caleb Connolly
2022-03-23 16:28 ` [PATCH v13 8/9] arm64: dts: qcom: sdm845-db845c: " Caleb Connolly
2022-03-23 16:28 ` [PATCH v13 9/9] arm64: dts: qcom: sdm845-xiaomi-beryllium: " Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10f7cb8e-4c2a-0bba-df55-16b56d429147@linaro.org \
--to=caleb.connolly@linaro.org \
--cc=agross@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).