From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E3F3C433EF for ; Tue, 26 Apr 2022 17:42:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353059AbiDZRpH (ORCPT ); Tue, 26 Apr 2022 13:45:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347849AbiDZRpG (ORCPT ); Tue, 26 Apr 2022 13:45:06 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9F521AF2D for ; Tue, 26 Apr 2022 10:41:57 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id k2so6057975wrd.5 for ; Tue, 26 Apr 2022 10:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=QQA23ghBxeAWrg+1pTuG+EIpzKydBoAGm6JxIISmz68=; b=k3ePSYdc/oMFI8zzl1Ck2yhC1E/Jbn9NSPODTh/jCaB75hYUB4RUnVAylJ32pERmyW zShZu08Cwn8JV+Mr2IuxMH0jNdh9h/ipjh+GGkF8fVSgj0uxKNB7RP8vbQkSxIBtDaLs 2YC5xTY1klMyg6x7J01UZFwkT5O/nTYpwZlz9vCY0wRiFg3EhQZ/H506Rl9Kbag0m5hy QULhN8LIr98ALYBHOFJCqr1qaEVSUFWD663pBj4/pnIgGtp6s8HJZFPeBHde2RNXeeo7 Z/wR/ct1JvIkj592CtgaVlnj4MDQT/+D2coCXcSzuqqWfh0E39OQvlb4sVOBvacmv6GA mNEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=QQA23ghBxeAWrg+1pTuG+EIpzKydBoAGm6JxIISmz68=; b=TCAUwiiaNjvFRC5GMkKqlwQYv5JaAsy4Tp2TxhzKznYiIdA3LmpsKmcDsQ241QA6Xj qsOlPViztEc27tcrwf7wOTR9VibM6zsErkKbz4Nl4fARuMgkPcLIBd8+qH08OZyUtUkI Ip9hWs6/jkJBny8UTng2gUogePC48REuvvKkn41m9MWV6WB4FXvoawfe9Ly4lnas0N8J x0CA0HrhAbIFu8DuCHRqvdVxDK5PqFq2I6V7BC9pRj1+Jmjss6EyGe0Q49vp0xK5fD6K 1+wOaF6p/twmo3y3zvxW/F8OVhtZHBVKzEa8FHqO6q6oTjdoyG/MY5vMeRk/IQKdZWYN URlg== X-Gm-Message-State: AOAM531WnwA7D+HqxdIcTSryGOfoWSMy9IPMZYFl0YNTRZ6KuHrQymoZ ujd7qrEeUZv257otMh/2IHCvPw== X-Google-Smtp-Source: ABdhPJwt90fodsf0OiUB4eqoLjLOvhGcW/S/Y1bclGSbPT/V6AE1gAQWmdiwV/0T4GMToMHwE2gluA== X-Received: by 2002:a05:6000:1547:b0:20a:79dd:28bf with SMTP id 7-20020a056000154700b0020a79dd28bfmr18728266wry.505.1650994916368; Tue, 26 Apr 2022 10:41:56 -0700 (PDT) Received: from [192.168.0.33] (cpc78119-cwma10-2-0-cust590.7-3.cable.virginm.net. [81.96.50.79]) by smtp.gmail.com with ESMTPSA id s30-20020adf979e000000b0020adfb1292fsm4374036wrb.16.2022.04.26.10.41.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 10:41:55 -0700 (PDT) Message-ID: <10f7cb8e-4c2a-0bba-df55-16b56d429147@linaro.org> Date: Tue, 26 Apr 2022 18:41:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v13 3/9] mfd: qcom-spmi-pmic: read fab id on supported PMICs Content-Language: en-US To: Lee Jones Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Andy Gross , Bjorn Andersson , Stephen Boyd , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, sumit.semwal@linaro.org, amit.pundir@linaro.org, Krzysztof Kozlowski , Dmitry Baryshkov References: <20220323162820.110806-1-caleb@connolly.tech> <20220323162820.110806-4-caleb@connolly.tech> From: Caleb Connolly In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/04/2022 16:05, Lee Jones wrote: > On Wed, 23 Mar 2022, Caleb Connolly wrote: > >> From: Caleb Connolly >> >> The PMI8998 and PM660 expose the fab_id, this is needed by drivers like >> the RRADC to calibrate ADC values. >> >> Signed-off-by: Caleb Connolly >> Reviewed-by: Dmitry Baryshkov >> Tested-by: Dmitry Baryshkov >> --- >> drivers/mfd/qcom-spmi-pmic.c | 7 +++++++ >> include/soc/qcom/qcom-spmi-pmic.h | 1 + >> 2 files changed, 8 insertions(+) > > Please change the Subject line to match the style of the sub-system? Hi, sorry if this is a silly question, I don't quite understand what you want me to change here, the subject line is in the same "mfd: driver:" format as other patches in the subsystem? > > Once changed: > > Acked-by: Lee Jones > -- Kind Regards, Caleb (they/he)