Re: [PATCH RFC 1/2] Documentation: add Device tree bindings for QCA7000

[Arnd Bergmann <arnd@arndb.de>]

On Tuesday 29 April 2014 08:30:47 Stefan Wahren wrote:
> Am 28.04.2014 21:57, schrieb Arnd Bergmann:
> > On Monday 28 April 2014 19:54:56 Stefan Wahren wrote:
> >> This patch adds the Device tree bindings for the Ethernet over SPI
> >> protocol driver of the Qualcomm QCA7000 HomePlug GreenPHY.
> >>
> >> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> >> ---
> >>  .../devicetree/bindings/net/qca-qca7000-spi.txt    |   51 ++++++++++++++++++++
> >>  1 file changed, 51 insertions(+)
> >>  create mode 100644 Documentation/devicetree/bindings/net/qca-qca7000-spi.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/net/qca-qca7000-spi.txt b/Documentation/devicetree/bindings/net/qca-qca7000-spi.txt
> >> new file mode 100644
> >> index 0000000..132c10f
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/net/qca-qca7000-spi.txt
> >> @@ -0,0 +1,51 @@
> >> +* Qualcomm QCA7000 (Ethernet over SPI protocol)
> >> +
> >> +Note: The QCA7000 is useable as a SPI device. In this case it must be defined
> >> +as a child of a spi master in the device tree.
> >> +
> >> +Required properties:
> >> +- compatible : Should be "qca,qca7000"
> >> +- reg : Should specify the SPI chip select
> >> +- intr-gpios : Should specify the GPIO for SPI interrupt
> >> +- spi-cpha : Must be set
> >> +- spi-cpol: Must be set
> > Why specify the interrupt as a GPIO line, rather than an 'interrupts' property?
> >
> >       Arnd
> >
> 
> i thought the extra interrupt line must be defined as a GPIO. I will fix
> that.

If all you need is an interrupt, it's better to define it that way.

> Is the rest of the bindings ok?

Looks ok to me. Other reviewers may have more comments.

	Arnd