Re: [PATCH 3/3] dt-bindings: mailbox: Add Renesas MFIS Mailbox

[Krzysztof Kozlowski <krzk@kernel.org>]

On 24/10/2025 08:22, Kuninori Morimoto wrote:
> Add device tree bindings for the Renesas Multifunctional Interface
> (MFIS) a mailbox controller.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  .../mailbox/renesas,mfis-mailbox.yaml         | 49 +++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mailbox/renesas,mfis-mailbox.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/renesas,mfis-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/renesas,mfis-mailbox.yaml
> new file mode 100644
> index 0000000000000..b9b6e6d440d79
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/renesas,mfis-mailbox.yaml

Filename must match compatible. See writing bindings.

> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mailbox/renesas,mfis-mailbox.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas MFIS (Multifunctional Interface) Mailbox Driver

Driver as Linux driver? No, please describe hardware.

> +
> +maintainers:
> +  - Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> +
> +description: |

Drop |

> +    The R-Car multifunctional interface (MFIS) provides an interface between
> +    the different CPU Cores, such as AP System Core domain and the Realtime
> +    Core domain, SCP Core domain and AP System Core domain or Realtime Core
> +    domain and AP System Core domain or Realtime Core domain.
> +    The MFIS supports the issuing of interrupts for each CPU core domain.
> +
> +properties:
> +  compatible:
> +    const: renesas,mfis-mbox

You need SoC specific compatibles, unless this is not SoC...

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    description: the irq line

Drop, redundant. Can it be not a irq line?

> +    maxItems: 1
> +
> +  "#mbox-cells":
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - "#mbox-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    mailbox: mfis_mbox@18842000  {


Please follow carefully DTS coding style. Also drop unnecessary label.

> +        compatible = "renesas,mfis-mbox";
> +        reg = <0x18842000 0x8>;
> +        interrupts = <GIC_SPI 4362 IRQ_TYPE_LEVEL_HIGH>;
> +        #mbox-cells = <1>;
> +    };


Best regards,
Krzysztof