From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793224569; b=u1ykDp/I7SOVahCKpVAbTvch2goP2ce5csHq4z9C+ScBFWaJ4n31z9CoGal1N/W643Ih POfXwswdaHDsNvRMhqfDOjiw6gX9hkxi7Z2FadudycJ8dnBhIbMeeqTUGj/fLhf3lZ6RM b0bSNEt1/dmIFWxexwuGO+Ak1qQDKxBiXp/9o5mm8/U7R7ZH+94J7zr8BloEF/UrpEi7R wY7OOUURGGrVkLYszeSRSFV1leIPLmOdX5mILQvyzdT6l6ugn/4dF0ycnV0BHzOjGlE2+ 897cau6ee2G8PStcPh+uyda4Wl6sGhLPBg42PUMoV4Kp4kvw7Z1LcIlMOq13inhBeFg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793224569; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References:From: Content-Language:In-Reply-To:Content-Type:Content-Transfer-Encoding: X-Authority-Analysis:X-Proofpoint-ORIG-GUID:X-Proofpoint-GUID: X-Proofpoint-Spam-Info:X-Proofpoint-Spam-Details-Enc: X-Proofpoint-Virus-Version:X-Proofpoint-Spam-Details; bh=vlZeBbTn4X9bi4Ynurx+tgcFaDtcBUgNgkgkjVTl578=; b=HOGVn3Vz8mNlmNsYiUjkg5vQvYx4NxWn2XzpnHNignj3eZ8iOiuKZXe3jSC8k4F1O+oQ 1zahgjAHsQmM7VXPMuTBbqF93myAOCFt5Rirfh9d/KFYgyi0mD+orJaSdTDJND76cPeI8 X/Rw6zfkm8jmDFjfxLc0Hu2oB7rkfNZjYUSLhpdYxVqIaqeUvnnCNMEJe+i+7LVscXYw8 0rVFTpZkxuStC/wlW1Kg0Ryiw4MWWQHQ7ITpv4Sp4vn7bQI8eq+f8lIB3M3fp4EFA7BQh iSya65F8viw6LR6E0wlRUb/r2vZ6fK5bk/nBGxBx86R2ClyXRHuhm2JExJ6f8MUNtLQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=I6+V08SU; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b="Kb/ZgqIM"; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F46B606A31E for ; Wed, 28 Oct 2026 21:56:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4F46B606A31E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=I6+V08SU; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=Kb/ZgqIM Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69SIPcGq1580024 for ; Wed, 28 Oct 2026 21:56:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vlZeBbTn4X9bi4Ynurx+tgcFaDtcBUgNgkgkjVTl578=; b=I6+V08SUWFn8OrJj /oc980yhRpnBQ54mN3PIWbEuO1FUMEMdNjS6wI+GTpHqI+3erfHUvhl4JPKS6Kyh XhsHfvUi5kNq0lg81sAV56Z83lgeiT6GEiSbLDaybfRwh2ryNGLSRimZuF6aWlY2 A8iBxYUtmYNACwXeCfNOvdcfUEbrXlzoMkHPcPfWRF7RSGM/Pw12Y1dKtxkzhtSf 6uzsI+/W2xjo7qSi0D6IrzX4P5rMmEcCnlFmWAJ9BbPMRp/bNoUwMiCPC7vBnuzC Nyks3CrstZZZvoWl9+kootfOwOkFWsXcXPAgWGuU41nAKgyxrbu2S62G6VbDT98N NquHDw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hknkp8vwh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 28 Oct 2026 21:56:08 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93909014c85so266736885a.0 for ; Wed, 28 Oct 2026 14:56:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793224567; x=1793829367; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=vlZeBbTn4X9bi4Ynurx+tgcFaDtcBUgNgkgkjVTl578=; b=Kb/ZgqIMOFbmJghMIz5wr8TduAUH94lPMO3jGQ4yYylSWZL8hAUUtRhUtyBAuUGAUr BlhK/fzmMHeTt84cIDpNadXx3BXzNZ2vguZhyjJ5eQqVAMJf25ZFm/0JHhKfESsnbwQu HZ5RO6bzBck9XbD2G3gbfMlIzeWPKkp/hVf8o95i1djCkge/Xn/EdPJRx9N8UAtHu05G r9MYyWJKENOjVvGrVm6QiPxiq0yKkJhZ8izo0zqia1d1nNcesbw3kbnOo3sq7KFGAe3O 2iBAv9UZsnki9296U93dO167MA3OkrV8VZhzCOPZdZfspRNKssTrLYa+ar9UuJZQ8mlq lGsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793224567; x=1793829367; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vlZeBbTn4X9bi4Ynurx+tgcFaDtcBUgNgkgkjVTl578=; b=r68+774FTDzMdxH7jrbLnPWlBc7FOR1P5dz6y/tD8CHLrt7JSkg3rHXN0d8NmDuAub hnT9fmmkwyQp72c+Jx2FkOfyJiyFAzGzbt7sgpUFCF8MKNh1y1yi2d/qB7xCzHlMlL9h n3zYt00b5gvuLF2Ipi5cAO06ZEeT3m6oreCW2c+IjeSBQzuTLJTCjMuf4P4KLn2QaCXE XK4cSyG89UxACgg/QyEcQ5Di0xpRO9LwgBwtn3uNSp2N/ZC50csdtYgLTXGVFGxIeEnf liITgf9D/jc9+4+i45dvu0Tgpb2abuBSMEUJdYOnoVKofBEaWW71DEBSygbAG+u8aM7T Pt1Q== X-Forwarded-Encrypted: i=1; AKwUvBysBWBmffC5H2K+/I6ghgRa6OeRr0FajGv1Rtmbhmb0QE/JiNRePOOK/DMzqyqQxVDZITQhJ1NFSR/m@vger.kernel.org X-Gm-Message-State: AFq9FYLjshy7PDA3em9KoSlqOq0nRQ0cmLoW4bjd9eeMwBieB/lhhyxf 0P7lE0CYf3rGfCYEs1u7437mAndsHZYdnZWfdum159aMJ9DdP3qT/vNbw8NICdD2fyuJJ9uBf2P S3x8z3vS/je9hxfdvqVNUbKFyj4TpKTfIcSya0z7x+YlXrxR3U/+Mg6i7sXGP44G6 X-Gm-Gg: AYBFou0a79tlJijH1zt03OiL7XPYeLbkMyX7StVyHyjPX06Yu1BNzM/H5kvyjrjqwYh mpsxvyLNzLH+vc17AVLVCf+z60HrJbxrPAKZbG+MxpB0zZR6HlJGhG8Rj3kx8PaSk3G/vt6UcG6 VBypbHW9FD8iweOkgejsgaXX/l7cGIxHrsxfTF1QhCP15idJYvAo9dzYqz+BajS3J0DDnT+fYQ6 TIoKu5kK5FgnaAfEfcGx1lunWbNxR+VvE/D9SvvUXYLTXvtykbjoYPTCBm58qrH/2f7wxqMZOAt wiqQ+rzpLWfSEjbgVwHe5+k3qXMV3cGcmM6fi5w/FVbt6SnXNWs4xUV0gzGeiHT6CLNExqm5hF0 5ZDYNADlCDBcBMkQfwR0g/w+JDoHY4j0T2Tfx5cVvzwcjJLMxZq5QDBGO9p8cKbpvI5sJBtWXlg 8= X-Received: by 2002:a05:620a:6f03:b0:93c:29b3:3525 with SMTP id af79cd13be357-94408a94fe3mr548789785a.36.1793224567380; Wed, 28 Oct 2026 14:56:07 -0700 (PDT) X-Received: by 2002:a05:620a:6f03:b0:93c:29b3:3525 with SMTP id af79cd13be357-94408a94fe3mr548785385a.36.1793224566702; Wed, 28 Oct 2026 14:56:06 -0700 (PDT) Received: from [192.168.68.120] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-48e64ccc693sm1283103f8f.5.2026.10.28.14.56.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Oct 2026 14:56:05 -0700 (PDT) Message-ID: <110e1d54-347f-4186-bbe1-6aa03aa8ff3f@oss.qualcomm.com> Date: Wed, 28 Oct 2026 21:56:04 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 00/23] ASoC: qcom: AudioReach Active speaker protection for WSA884x To: Fabian Renn-Giles Cc: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Jonathan Corbet , Alexey Klimov , Ravi Hothi , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261023171433.820092-1-srinivas.kandagatla@oss.qualcomm.com> <20261028163152.26892-1-fabian@fielding.dev> From: Srinivas Kandagatla Content-Language: en-US In-Reply-To: <20261028163152.26892-1-fabian@fielding.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Ju9kP84C c=1 sm=1 tr=0 ts=6ae26f78 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=mQyjg09NGKRehI6BM-EA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: ewZopqBNNeXddEDDdHXGHpzNncJa6XOU X-Proofpoint-GUID: ewZopqBNNeXddEDDdHXGHpzNncJa6XOU X-Proofpoint-Spam-Info: AW1haW4tMjYxMDI4MDA4NyBTYWx0ZWRfXz7naVL0/D9Uf Zd9lGG3KIbmT87Ma23xQN/YuzPcj++QWSqwSvSiuxjO3b80x8DpYEkD+GPdaFJE6NVtl+GvJjZP gDCI2yJzWw6nABdg1kTiDyPlhGYuxwg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDI4MDA4NyBTYWx0ZWRfX9OGush3w9Ae0 PSkdsWUDPcqHRujB75Xf7FjlorBZRtT9aqOaxJskojJBh1XwmiAOnd48rxMeoeViCXezMS/0y2V 7FdUZvZQzWp11gv9QifUBl24RkiiEnBcnglol0zsxdYyMXzcgcZbWe619XNIBCNLmMd3q3zwv/I qH7Ho2QxAB5wGm46ULZZvbcun98uIaasZ5WRA9VAr3w8iWrViRA5fH7tCgfR7LKDvmKwdXI24LI TzPelSavQjYqtwtDp1u5jji+P+/FjFbemvyZEk2feB7rCeB1xbY2QVSr/nmsVqEq+GoNgsfuSo0 PHUoNjWpuuLJFn6GtvDCncSQl0+9rIsgFtaGfLPT5Omh778BjFJ5OtK4eimAd3UF2LGHsP5EfXu VFazKmcI8zWPnuZpDqsTuGtS0c8VsucPXPQ/VPgaDB3XyEYjn8dnfmurIQ6wl98HZtCJCUDUC5m 4KbbDvSoJuGRelKKAfw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-28_06,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 adultscore=0 bulkscore=0 clxscore=1015 suspectscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610280087 Hi Fabian, Thanks for trying this out, On 10/28/26 4:31 PM, Fabian Renn-Giles wrote: > Hi Srinivas, > > I tried this series on a Lenovo Yoga Slim 7x (X1E80100/Hamoa, 4x > WSA8845, Linux 7.3.0 based tree). I found one bug and have one open > problem. > > 1. Over-read in audioreach_get_module_priv_data() (oops on topology load) > Have you looked at https://lore.kernel.org/all/20261023171316.819857-1-srinivas.kandagatla@oss.qualcomm.com/ this has fix for the exact issue, along with the VI fixes in codec, please pick them up. My Next target is X1 T14s Gen6 platform, I have not tried it yet, but am hoping that it should work. I will keep you posted. > The function allocates > struct_size(pdata, data, le32_to_cpu(mod_array->size)) and then > memcpy()s from the topology blob. It crashed on the first load of a > topology containing the speaker protection module config blob. The > cause is in the size computation. data[] is __le32, so struct_size() > counts elements while mod_array->size is in bytes. The allocation is > 4x too large and the memcpy runs past the topology data. This is what > I used instead: > > size_t len = sizeof(*pdata) + le32_to_cpu(mod_array->size); > > pdata = kzalloc(len, GFP_KERNEL); > if (!pdata) > return ERR_PTR(-ENOMEM); > > memcpy(pdata, ((u8 *)private->data + sz), len); > return pdata; > > 2. Slim 7x bring-up: V/I feedback never reaches the DSP > > DT changes for the Slim 7x: > - The WSA codec list is extended with the VISENSE ports > <&swr0 10>, <&swr0 11> on the left pair and the mirrored ports on > swr3. The speaker nodes get #sound-dai-cells = <1>. > - The static port-mapping is <1 2 3 7 10 13> / <4 5 6 7 11 13>. On > Hamoa the din ports are 10 and 11, versus 12 and 13 on Glymur. > - I cloned the CRD topology and UCM, using 4 speakers, with the > WSA_CODEC_DMA_TX_0 VI capture at S32_LE/8 kHz. > Speaker tuning data might be different, but overall it should work. I will have to recheck on the port-mapping. > What works: > - The card probes and the SP/VI controls appear. > - Normal playback through the SP graph runs without errors. > > What doesn't: > - Calibration (Operation Mode set to Calibration, then silence > played) times out waiting for V/I. R0/T0 stay 0. > - I read back the SoundWire master and slave port registers, the WSA > macro SPKR_PROT TX path enables, and the DSP module config. They > all looked as intended. > - With the SP graph active, the amp stays gated and playback is > silent. This matches the calibration never completing. > > Question: is there anything Hamoa-specific on the VISENSE path (din > port numbers or channel masks, the macro TX decimator routing, > multi_direction_codecs handling) that I should check? I can run any > debug patches you want on this machine. > > Unrelated noise: SoundWire parity errors/clash messages appear in the > logs, but they also show up without the series applied, so I don't > think they relate to it. I did hit some soundwire issue related to runtime pm, which was triggering the timeout too, Can you try to disable runtime pm and give it a spin. --srini > > Regards, > Fabian