From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] ARM: dts: rockchip: setup DMA-channels for mmc0 and emmc for rk3188 Date: Wed, 22 Mar 2017 16:54:33 +0100 Message-ID: <11123239.Wc863F7R2R@phil> References: <1490109227-4006-1-git-send-email-al.kochet@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1490109227-4006-1-git-send-email-al.kochet@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Alexander Kochetkov Cc: Mark Rutland , devicetree@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hi Alexander, Am Dienstag, 21. M=E4rz 2017, 18:13:47 CET schrieb Alexander Kochetkov: > This commit enable DMA-based transfers for SD/eMMC card adapters > and reduce number of interrupts produced by SD-card/eMMC-card > adapters. > = > Sometimes interrupts from SD-card/eMMC-card adapters running in > PIO mode blocks execution of hrtimers and I2S DMA callbacks for > a long periods (100 ms or more). > = > Signed-off-by: Alexander Kochetkov I've applied a slightly different variant in [0] with your commit message a= nd moved the dma properties to the mmc/emmc nodes in rk3xxx.dtsi - as the dma channels are the same on both rk3188 and rk3066. While at it, I've also added the sdio dma as there is no need to leave it o= ut. Also when changing the devicetree, please do not append stuff at the bottom but instead sort new nodes (the &mmc &emmc in this case) and properties alphabetically. Thanks Heiko [0] https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.gi= t/commit/?id=3D94bbdd77247d8c16eed5f55dddcf1cbc38d06cc4