From: Kukjin Kim <kgene@kernel.org>
To: 'Rahul Sharma' <rahul.sharma@samsung.com>,
linux-samsung-soc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Cc: sw0312.kim@samsung.com, inki.dae@samsung.com,
seanpaul@chromium.org, l.stach@pengutronix.de,
tomasz.figa@gmail.com, rob.herring@calxeda.com,
s.nawrocki@samsung.com, grant.likely@linaro.org,
joshi@samsung.com, r.sh.open@gmail.com
Subject: RE: [PATCH v3 3/9] ARM: dts: exynos5250: move common i2c properties to exynos5 dtsi
Date: Wed, 14 Aug 2013 19:01:42 +0900 [thread overview]
Message-ID: <111d01ce98d5$46b5d220$d4217660$@org> (raw)
In-Reply-To: <1374737677-3215-4-git-send-email-rahul.sharma@samsung.com>
Rahul Sharma wrote:
>
> I2C nodes shares many properties across exynos5 SoCs (exynos5250
> and exyno5420). Common code is moved to exynos5.dtsi which is
> included in exyno5250 and exynos5420 SoC files.
>
> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
> ---
> arch/arm/boot/dts/exynos5.dtsi | 36
> +++++++++++++++++++++++++++++
> arch/arm/boot/dts/exynos5250-arndale.dts | 1 +
> arch/arm/boot/dts/exynos5250-smdk5250.dts | 3 +++
> arch/arm/boot/dts/exynos5250.dtsi | 20 ----------------
> 4 files changed, 40 insertions(+), 20 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5.dtsi
> b/arch/arm/boot/dts/exynos5.dtsi
> index f65e124..1ae179e 100644
> --- a/arch/arm/boot/dts/exynos5.dtsi
> +++ b/arch/arm/boot/dts/exynos5.dtsi
> @@ -108,4 +108,40 @@
> interrupts = <0 42 0>;
> status = "disabled";
> };
> +
> + i2c_0: i2c@12C60000 {
> + compatible = "samsung,s3c2440-i2c";
> + reg = <0x12C60000 0x100>;
> + interrupts = <0 56 0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + i2c_1: i2c@12C70000 {
> + compatible = "samsung,s3c2440-i2c";
> + reg = <0x12C70000 0x100>;
> + interrupts = <0 57 0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + i2c_2: i2c@12C80000 {
> + compatible = "samsung,s3c2440-i2c";
> + reg = <0x12C80000 0x100>;
> + interrupts = <0 58 0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + i2c_3: i2c@12C90000 {
> + compatible = "samsung,s3c2440-i2c";
> + reg = <0x12C90000 0x100>;
> + interrupts = <0 59 0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> };
> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
> b/arch/arm/boot/dts/exynos5250-arndale.dts
> index 96d528d..83ab780 100644
> --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> @@ -31,6 +31,7 @@
> };
>
> i2c@12C60000 {
> + status = "okay";
> samsung,i2c-sda-delay = <100>;
> samsung,i2c-max-bus-freq = <20000>;
> samsung,i2c-slave-addr = <0x66>;
> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> index 49f18c2..945e6cc 100644
> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> @@ -28,6 +28,7 @@
> };
>
> i2c@12C60000 {
> + status = "okay";
> samsung,i2c-sda-delay = <100>;
> samsung,i2c-max-bus-freq = <20000>;
>
> @@ -62,6 +63,7 @@
> };
>
> i2c@12C70000 {
> + status = "okay";
> samsung,i2c-sda-delay = <100>;
> samsung,i2c-max-bus-freq = <20000>;
>
> @@ -101,6 +103,7 @@
> };
>
> i2c@12C80000 {
> + status = "okay";
> samsung,i2c-sda-delay = <100>;
> samsung,i2c-max-bus-freq = <66000>;
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index 93d6cc5..de54b38 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -217,11 +217,6 @@
> };
>
> i2c_0: i2c@12C60000 {
> - compatible = "samsung,s3c2440-i2c";
> - reg = <0x12C60000 0x100>;
> - interrupts = <0 56 0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> clocks = <&clock 294>;
> clock-names = "i2c";
> pinctrl-names = "default";
> @@ -229,11 +224,6 @@
> };
>
> i2c_1: i2c@12C70000 {
> - compatible = "samsung,s3c2440-i2c";
> - reg = <0x12C70000 0x100>;
> - interrupts = <0 57 0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> clocks = <&clock 295>;
> clock-names = "i2c";
> pinctrl-names = "default";
> @@ -241,11 +231,6 @@
> };
>
> i2c_2: i2c@12C80000 {
> - compatible = "samsung,s3c2440-i2c";
> - reg = <0x12C80000 0x100>;
> - interrupts = <0 58 0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> clocks = <&clock 296>;
> clock-names = "i2c";
> pinctrl-names = "default";
> @@ -253,11 +238,6 @@
> };
>
> i2c_3: i2c@12C90000 {
> - compatible = "samsung,s3c2440-i2c";
> - reg = <0x12C90000 0x100>;
> - interrupts = <0 59 0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> clocks = <&clock 297>;
> clock-names = "i2c";
> pinctrl-names = "default";
> --
> 1.7.10.4
NAK, there are 8 I2C channels with different address on upcoming exynos5 so
this change is not acceptable. Note please check at least upcoming SoC
before making common something if possible.
- Kukjin
next prev parent reply other threads:[~2013-08-14 10:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 7:34 [PATCH v3 0/9] ARM: dts: exynos: add support for hdmi subsystem Rahul Sharma
2013-07-25 7:34 ` [PATCH v3 1/9] ARM: dts: exynos5250: add mixer clocks to mixer node Rahul Sharma
2013-07-25 7:34 ` [PATCH v3 2/9] ARM: dts: exynos5250: add clocks to hdmi dt node Rahul Sharma
2013-07-25 7:34 ` [PATCH v3 3/9] ARM: dts: exynos5250: move common i2c properties to exynos5 dtsi Rahul Sharma
2013-08-14 10:01 ` Kukjin Kim [this message]
2013-07-25 7:34 ` [PATCH v3 4/9] ARM: dts: exynos5420: add i2c device nodes Rahul Sharma
2013-07-25 7:34 ` [PATCH v3 5/9] ARM: dts: exynos5250: move common hdmi properties to exynos5 dtsi Rahul Sharma
2013-08-14 10:05 ` Kukjin Kim
2013-07-25 7:34 ` [PATCH v3 6/9] ARM: dts: exynos5420: add dt nodes for hdmi subsystem Rahul Sharma
2013-07-25 7:34 ` [PATCH v3 7/9] ARM: dts: exynos5420: add clocks " Rahul Sharma
2013-07-25 7:34 ` [PATCH v3 8/9] ARM: dts: exynos5420: add hdmi hpd gpio pinctrl node Rahul Sharma
2013-07-25 7:34 ` [PATCH v3 9/9] of/documentation: update with clock information for exynos hdmi subsystem Rahul Sharma
2013-08-14 10:11 ` [PATCH v3 0/9] ARM: dts: exynos: add support for " Kukjin Kim
2013-08-14 11:26 ` Tomasz Figa
2013-08-18 19:16 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='111d01ce98d5$46b5d220$d4217660$@org' \
--to=kgene@kernel.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=inki.dae@samsung.com \
--cc=joshi@samsung.com \
--cc=l.stach@pengutronix.de \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=r.sh.open@gmail.com \
--cc=rahul.sharma@samsung.com \
--cc=rob.herring@calxeda.com \
--cc=s.nawrocki@samsung.com \
--cc=seanpaul@chromium.org \
--cc=sw0312.kim@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).