From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C863ECCA47E for ; Fri, 10 Jun 2022 09:59:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347561AbiFJJ7J (ORCPT ); Fri, 10 Jun 2022 05:59:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348094AbiFJJ7I (ORCPT ); Fri, 10 Jun 2022 05:59:08 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08618B041B for ; Fri, 10 Jun 2022 02:59:04 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id h19so34606988edj.0 for ; Fri, 10 Jun 2022 02:59:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Wq9gVVdD1/J4q1/EmaJv8aMnFa3KHaLmU1Qz7ppGNhE=; b=sESAYG8k3Sf9OIqWLT4EVVR1tdBRPzoeATKW1Bbr2Qec6XgtDTd0dLvf3JxpbsdtiN haM4S5D0p35YqjS96SRhlhV9PmgIBeJZRFmqLI2mTKsHDeogxhZjOgQrxOnzy+1/2XtD 0eX4ckZuGDw9VkCsjWhZCr46CF8UjrkgRy6bgK/5g382J+YFtdU43gWuOYUyzULLe/G5 0oLO+Ocf8dUlYZC2cquCijGI6UDKjYA4U3w5eOjWMvkknznKAeuz19JOqsRhoOxhN3jy C83YXicE7j8ja6i/EwLN5oSrZBoRFP5A1cJViH3BlNc9kFVxMxQaduFcPkr6w8n090DN bvhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Wq9gVVdD1/J4q1/EmaJv8aMnFa3KHaLmU1Qz7ppGNhE=; b=p4QfDjkIKpqbtx0D7p3Hc3sStjbbzGzpLI2fBNG3xcWnTGpw3O1YKDVhAtUghpL7T5 bxFPGnGatvx1a1UklhUTqBFLK8W6DeP8A9b+VYU8neBCiFB1TDejhdJ9+230Gm/ShUMr E5QZgoOVQaVEdpTwWhb0mPtMGT/qBISu988Lv1eUx4u04DTUSKTu6nAduYRHCcwf4uY+ YA5cPz6/46V8jEYJ1jpNTTGCSwDuTA50kxR6rrw4GYWZ9CZD75iFO9aS3GgQl9JQzcYF NpcG97p054F0lvAepEZSakPsvs8SeHYzOkq1XRUGxVAU04+Ja9+dU1F1OjCJtOwuZISr f5kA== X-Gm-Message-State: AOAM533Wpx8ghEmZUycFWLjsaS/JBq7b7M/5182CbTJ2P1R5yW04b6/P 5qHwujNWGs9njb+fMnlnnwXd3A== X-Google-Smtp-Source: ABdhPJznPfBVrxm6drYBka7ZGOrt2dIG3zy2ti6SB08YUWNwJwfIafeTfcbr7B/2U8M4buh900aY3w== X-Received: by 2002:a05:6402:500b:b0:431:78d0:bf9d with SMTP id p11-20020a056402500b00b0043178d0bf9dmr22935174eda.184.1654855143357; Fri, 10 Jun 2022 02:59:03 -0700 (PDT) Received: from [192.168.0.201] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id l15-20020a17090615cf00b006f3ef214dd9sm11969760ejd.63.2022.06.10.02.59.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jun 2022 02:59:02 -0700 (PDT) Message-ID: <11245d23-76a2-1008-eac6-f396954857c7@linaro.org> Date: Fri, 10 Jun 2022 11:59:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 18/20] arm64: dts: nuvoton: Add initial NPCM8XX device tree Content-Language: en-US To: Tomer Maimon Cc: Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Philipp Zabel , Greg KH , Daniel Lezcano , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Catalin Marinas , Will Deacon , Arnd Bergmann , Olof Johansson , Jiri Slaby , Shawn Guo , Bjorn Andersson , Geert Uytterhoeven , Marcel Ziswiler , Vinod Koul , Biju Das , Nobuhiro Iwamatsu , Robert Hancock , =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= , Lubomir Rintel , devicetree , Linux Kernel Mailing List , linux-clk , "open list:SERIAL DRIVERS" , LINUXWATCHDOG , Linux ARM References: <20220608095623.22327-1-tmaimon77@gmail.com> <20220608095623.22327-19-tmaimon77@gmail.com> <24ad8ba0-4244-1159-328d-12d0e67951e1@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/06/2022 00:29, Tomer Maimon wrote: >>> + clk_refclk: clk-refclk { >>> + compatible = "fixed-clock"; >>> + #clock-cells = <0>; >>> + clock-frequency = <25000000>; >> >> Ignored comment. > Could we use it as a default clock-frequency? In DTS? If my assumption, that this clock is not on SoC itself, is correct, then the answer is no, you cannot. The clock physically sits on the board, so it is defined by board DTS. Feel free to embed in SoC DTSI most of the clock properties, but the core property - frequency - must be outside. >> >>> + clock-output-names = "refclk"; >>> + }; >>> + >>> + /* external reference clock for cpu. float in normal operation */ >>> + clk_sysbypck: clk-sysbypck { >>> + compatible = "fixed-clock"; >>> + #clock-cells = <0>; >>> + clock-frequency = <1000000000>; >> >> Ignored comment. > same as above >> >>> + clock-output-names = "sysbypck"; >>> + }; >>> + >>> + /* external reference clock for MC. float in normal operation */ >>> + clk_mcbypck: clk-mcbypck { >>> + compatible = "fixed-clock"; >>> + #clock-cells = <0>; >>> + clock-frequency = <1050000000>; > same as above >>> + clock-output-names = "mcbypck"; >>> + }; >>> + >>> + soc { >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + compatible = "simple-bus"; >>> + interrupt-parent = <&gic>; >>> + ranges; >>> + >>> + gcr: gcr@f0800000 { > I understand it sounds generic but I try to be as much compatible with NPCM7XX > https://elixir.bootlin.com/linux/v5.19-rc1/source/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi#L91 Then fix NPCM7XX. Please do not multiple bad choices because it looks similar. Fix the other wrong one. >> >> Ignored comment. >> >>> + compatible = "nuvoton,npcm845-gcr", "syscon", >>> + "simple-mfd"; >> >> This is not a simple-mfd... I see original bindings defined it that way, >> but why? I think they should be corrected - remove simple-mfd from the >> bindings and DTS. > will remove in both places in V3 >> >> >>> + reg = <0x0 0xf0800000 0x0 0x1000>; >>> + }; >>> + >>> + gic: interrupt-controller@dfff9000 { >>> + compatible = "arm,gic-400"; >>> + reg = <0x0 0xdfff9000 0x0 0x1000>, >>> + <0x0 0xdfffa000 0x0 0x2000>, >>> + <0x0 0xdfffc000 0x0 0x2000>, >>> + <0x0 0xdfffe000 0x0 0x2000>; >>> + interrupts = ; >>> + #interrupt-cells = <3>; >>> + interrupt-controller; >>> + #address-cells = <0>; >>> + ppi-partitions { >>> + ppi_cluster0: interrupt-partition-0 { >>> + affinity = <&cpu0 &cpu1 &cpu2 &cpu3>; >>> + }; >>> + }; >>> + }; >>> + }; >>> + >>> + ahb { >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + compatible = "simple-bus"; >>> + interrupt-parent = <&gic>; > >>> + ranges; >>> + >>> + rstc: rstc@f0801000 { >> >> Ignored comment. >> > I understand it sounds generic but I try to be as much compatible with NPCM7XX > https://elixir.bootlin.com/linux/v5.19-rc1/source/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi#L109 Fix 7xx. Best regards, Krzysztof