* [PATCH 0/2] Devicetree for board AN400 based Amlogic T7 SoC
@ 2023-07-04 3:16 Xianwei Zhao
2023-07-04 3:16 ` [PATCH 1/2] dt-bindings: arm: amlogic: add board AN400 Xianwei Zhao
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Xianwei Zhao @ 2023-07-04 3:16 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, linux-amlogic, devicetree
Cc: Catalin Marinas, Will Deacon, Neil Armstrong, Kevin Hilman,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Xianwei Zhao
Add the board AN400 tree bindings based Amloigc T7 SoC.
Add devicetree support for Amlogic AN400 board based T7 SoC.
Xianwei Zhao (2):
dt-bindings: arm: amlogic: add board AN400
arm64: dts: add board AN400
.../devicetree/bindings/arm/amlogic.yaml | 1 +
arch/arm64/boot/dts/amlogic/Makefile | 1 +
.../dts/amlogic/amlogic-t7-a311d2-an400.dts | 39 +++++++++++++++++++
3 files changed, 41 insertions(+)
create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
base-commit: 76483eaf2109fc3d94f29c68ff9dee6579e95ccf
--
2.37.1
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/2] dt-bindings: arm: amlogic: add board AN400 2023-07-04 3:16 [PATCH 0/2] Devicetree for board AN400 based Amlogic T7 SoC Xianwei Zhao @ 2023-07-04 3:16 ` Xianwei Zhao 2023-07-04 5:48 ` Krzysztof Kozlowski 2023-07-04 3:16 ` [PATCH 2/2] arm64: dts: " Xianwei Zhao 2023-07-31 9:46 ` [PATCH 0/2] Devicetree for board AN400 based Amlogic T7 SoC Neil Armstrong 2 siblings, 1 reply; 7+ messages in thread From: Xianwei Zhao @ 2023-07-04 3:16 UTC (permalink / raw) To: linux-arm-kernel, linux-kernel, linux-amlogic, devicetree Cc: Catalin Marinas, Will Deacon, Neil Armstrong, Kevin Hilman, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Xianwei Zhao Add the board AN400 tree bindings based Amloigc T7 SoC. Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com> --- Documentation/devicetree/bindings/arm/amlogic.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml index 45f179c72129..1c1094cd6b77 100644 --- a/Documentation/devicetree/bindings/arm/amlogic.yaml +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml @@ -221,6 +221,7 @@ properties: - description: Boards with the Amlogic T7 A311D2 SoC items: - enum: + - amlogic,an400 - khadas,vim4 - const: amlogic,a311d2 - const: amlogic,t7 -- 2.37.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: amlogic: add board AN400 2023-07-04 3:16 ` [PATCH 1/2] dt-bindings: arm: amlogic: add board AN400 Xianwei Zhao @ 2023-07-04 5:48 ` Krzysztof Kozlowski 0 siblings, 0 replies; 7+ messages in thread From: Krzysztof Kozlowski @ 2023-07-04 5:48 UTC (permalink / raw) To: Xianwei Zhao, linux-arm-kernel, linux-kernel, linux-amlogic, devicetree Cc: Catalin Marinas, Will Deacon, Neil Armstrong, Kevin Hilman, Rob Herring, Krzysztof Kozlowski, Conor Dooley On 04/07/2023 05:16, Xianwei Zhao wrote: > Add the board AN400 tree bindings based Amloigc T7 SoC. > > Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] arm64: dts: add board AN400 2023-07-04 3:16 [PATCH 0/2] Devicetree for board AN400 based Amlogic T7 SoC Xianwei Zhao 2023-07-04 3:16 ` [PATCH 1/2] dt-bindings: arm: amlogic: add board AN400 Xianwei Zhao @ 2023-07-04 3:16 ` Xianwei Zhao 2023-07-04 8:09 ` Neil Armstrong 2023-07-31 9:46 ` [PATCH 0/2] Devicetree for board AN400 based Amlogic T7 SoC Neil Armstrong 2 siblings, 1 reply; 7+ messages in thread From: Xianwei Zhao @ 2023-07-04 3:16 UTC (permalink / raw) To: linux-arm-kernel, linux-kernel, linux-amlogic, devicetree Cc: Catalin Marinas, Will Deacon, Neil Armstrong, Kevin Hilman, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Xianwei Zhao Add devicetree support for Amlogic AN400 board based T7 SoC. Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com> --- arch/arm64/boot/dts/amlogic/Makefile | 1 + .../dts/amlogic/amlogic-t7-a311d2-an400.dts | 39 +++++++++++++++++++ 2 files changed, 40 insertions(+) create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile index 91fa425116ea..8b6f57a94863 100644 --- a/arch/arm64/boot/dts/amlogic/Makefile +++ b/arch/arm64/boot/dts/amlogic/Makefile @@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 dtb-$(CONFIG_ARCH_MESON) += amlogic-c3-c302x-aw409.dtb +dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-an400.dtb dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-khadas-vim4.dtb dtb-$(CONFIG_ARCH_MESON) += meson-a1-ad401.dtb dtb-$(CONFIG_ARCH_MESON) += meson-axg-jethome-jethub-j100.dtb diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts new file mode 100644 index 000000000000..d755e1ee108a --- /dev/null +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts @@ -0,0 +1,39 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2023 Amlogic, Inc. All rights reserved. + */ + +/dts-v1/; + +#include "amlogic-t7.dtsi" + +/ { + model = "Amlogic A311D2 AN400 Development Board"; + compatible = "amlogic,an400", "amlogic,a311d2", "amlogic,t7"; + interrupt-parent = <&gic>; + #address-cells = <2>; + #size-cells = <2>; + + aliases { + serial0 = &uart_a; + }; + + memory@0 { + device_type = "memory"; + linux,usable-memory = <0x00000000 0x00000000 0x00000000 0xE0000000 + 0x00000001 0x00000000 0x00000000 0x20000000>; + }; + + xtal: xtal-clk { + compatible = "fixed-clock"; + clock-frequency = <24000000>; + clock-output-names = "xtal"; + #clock-cells = <0>; + }; +}; + +&uart_a { + clocks = <&xtal>, <&xtal>, <&xtal>; + clock-names = "xtal", "pclk", "baud"; + status = "okay"; +}; -- 2.37.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] arm64: dts: add board AN400 2023-07-04 3:16 ` [PATCH 2/2] arm64: dts: " Xianwei Zhao @ 2023-07-04 8:09 ` Neil Armstrong 2023-07-06 8:44 ` Xianwei Zhao 0 siblings, 1 reply; 7+ messages in thread From: Neil Armstrong @ 2023-07-04 8:09 UTC (permalink / raw) To: Xianwei Zhao, linux-arm-kernel, linux-kernel, linux-amlogic, devicetree Cc: Catalin Marinas, Will Deacon, Kevin Hilman, Rob Herring, Krzysztof Kozlowski, Conor Dooley Hi, On 04/07/2023 05:16, Xianwei Zhao wrote: > Add devicetree support for Amlogic AN400 board based T7 SoC. > > Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com> > --- > arch/arm64/boot/dts/amlogic/Makefile | 1 + > .../dts/amlogic/amlogic-t7-a311d2-an400.dts | 39 +++++++++++++++++++ > 2 files changed, 40 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile > index 91fa425116ea..8b6f57a94863 100644 > --- a/arch/arm64/boot/dts/amlogic/Makefile > +++ b/arch/arm64/boot/dts/amlogic/Makefile > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > dtb-$(CONFIG_ARCH_MESON) += amlogic-c3-c302x-aw409.dtb > +dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-an400.dtb > dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-khadas-vim4.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-a1-ad401.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-axg-jethome-jethub-j100.dtb > diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts > new file mode 100644 > index 000000000000..d755e1ee108a > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts > @@ -0,0 +1,39 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2023 Amlogic, Inc. All rights reserved. > + */ > + > +/dts-v1/; > + > +#include "amlogic-t7.dtsi" > + > +/ { > + model = "Amlogic A311D2 AN400 Development Board"; > + compatible = "amlogic,an400", "amlogic,a311d2", "amlogic,t7"; > + interrupt-parent = <&gic>; > + #address-cells = <2>; > + #size-cells = <2>; > + > + aliases { > + serial0 = &uart_a; > + }; > + > + memory@0 { > + device_type = "memory"; > + linux,usable-memory = <0x00000000 0x00000000 0x00000000 0xE0000000 > + 0x00000001 0x00000000 0x00000000 0x20000000>; Please use "reg =" instead of linux,usable-memory, which is not a documented property Please use `make CHECK_DTBS=yes amlogic/amlogic-t7-a311d2-an400.dtb` before posting DT patches, and make sure there's no errors except already in-review bindings like here the UART compatible. The result here is: arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dtb: /: memory@0: 'anyOf' conditional failed, one must be fixed: 'reg' is a required property 'ranges' is a required property From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/root-node.yaml arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dtb: /: memory@0: 'linux,usable-memory' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/memory.yaml arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dtb: /: memory@0: 'reg' is a required property From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/memory.yaml Please fix this one. arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dtb: serial@78000: compatible: 'oneOf' conditional failed, one must be fixed: ['amlogic,t7-uart', 'amlogic,meson-s4-uart'] is too short ['amlogic,t7-uart', 'amlogic,meson-s4-uart'] is too long 'amlogic,t7-uart' is not one of ['amlogic,meson6-uart', 'amlogic,meson8-uart', 'amlogic,meson8b-uart', 'amlogic,meson-gx-uart', 'amlogic,meson-s4-uart'] 'amlogic,meson-g12a-uart' was expected 'amlogic,meson-ao-uart' was expected 'amlogic,meson-gx-uart' was expected From schema: Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dtb: serial@78000: Unevaluated properties are not allowed ('compatible' was unexpected) From schema: Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dtb: /soc/bus@fe000000/serial@78000: failed to match any schema with compatible: ['amlogic,t7-uart', 'amlogic,meson-s4-uart'] This one is OK, the UART bindings is reviewed and should be picked up for v6.6 Neil > + }; > + > + xtal: xtal-clk { > + compatible = "fixed-clock"; > + clock-frequency = <24000000>; > + clock-output-names = "xtal"; > + #clock-cells = <0>; > + }; > +}; > + > +&uart_a { > + clocks = <&xtal>, <&xtal>, <&xtal>; > + clock-names = "xtal", "pclk", "baud"; > + status = "okay"; > +}; ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] arm64: dts: add board AN400 2023-07-04 8:09 ` Neil Armstrong @ 2023-07-06 8:44 ` Xianwei Zhao 0 siblings, 0 replies; 7+ messages in thread From: Xianwei Zhao @ 2023-07-06 8:44 UTC (permalink / raw) To: neil.armstrong, linux-arm-kernel, linux-kernel, linux-amlogic, devicetree Cc: Catalin Marinas, Will Deacon, Kevin Hilman, Rob Herring, Krzysztof Kozlowski, Conor Dooley Hi Neil, Thanks. On 2023/7/4 16:09, Neil Armstrong wrote: > [ EXTERNAL EMAIL ] > > Hi, > > On 04/07/2023 05:16, Xianwei Zhao wrote: >> Add devicetree support for Amlogic AN400 board based T7 SoC. >> >> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com> >> --- >> arch/arm64/boot/dts/amlogic/Makefile | 1 + >> .../dts/amlogic/amlogic-t7-a311d2-an400.dts | 39 +++++++++++++++++++ >> 2 files changed, 40 insertions(+) >> create mode 100644 >> arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts >> >> diff --git a/arch/arm64/boot/dts/amlogic/Makefile >> b/arch/arm64/boot/dts/amlogic/Makefile >> index 91fa425116ea..8b6f57a94863 100644 >> --- a/arch/arm64/boot/dts/amlogic/Makefile >> +++ b/arch/arm64/boot/dts/amlogic/Makefile >> @@ -1,5 +1,6 @@ >> # SPDX-License-Identifier: GPL-2.0 >> dtb-$(CONFIG_ARCH_MESON) += amlogic-c3-c302x-aw409.dtb >> +dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-an400.dtb >> dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-khadas-vim4.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-a1-ad401.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-axg-jethome-jethub-j100.dtb >> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts >> b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts >> new file mode 100644 >> index 000000000000..d755e1ee108a >> --- /dev/null >> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts >> @@ -0,0 +1,39 @@ >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> +/* >> + * Copyright (c) 2023 Amlogic, Inc. All rights reserved. >> + */ >> + >> +/dts-v1/; >> + >> +#include "amlogic-t7.dtsi" >> + >> +/ { >> + model = "Amlogic A311D2 AN400 Development Board"; >> + compatible = "amlogic,an400", "amlogic,a311d2", "amlogic,t7"; >> + interrupt-parent = <&gic>; >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> + aliases { >> + serial0 = &uart_a; >> + }; >> + >> + memory@0 { >> + device_type = "memory"; >> + linux,usable-memory = <0x00000000 0x00000000 0x00000000 >> 0xE0000000 >> + 0x00000001 0x00000000 0x00000000 >> 0x20000000>; > > Please use "reg =" instead of linux,usable-memory, which is not a > documented property > > Please use `make CHECK_DTBS=yes amlogic/amlogic-t7-a311d2-an400.dtb` > before posting DT patches, > and make sure there's no errors except already in-review bindings like > here the UART compatible. > > The result here is: > arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dtb: /: memory@0: > 'anyOf' conditional failed, one must be fixed: > 'reg' is a required property > 'ranges' is a required property > From schema: > /usr/local/lib/python3.10/dist-packages/dtschema/schemas/root-node.yaml > arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dtb: /: memory@0: > 'linux,usable-memory' does not match any of the regexes: 'pinctrl-[0-9]+' > From schema: > /usr/local/lib/python3.10/dist-packages/dtschema/schemas/memory.yaml > arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dtb: /: memory@0: > 'reg' is a required property > From schema: > /usr/local/lib/python3.10/dist-packages/dtschema/schemas/memory.yaml > > Please fix this one. > Will do > arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dtb: serial@78000: > compatible: 'oneOf' conditional failed, one must be fixed: > ['amlogic,t7-uart', 'amlogic,meson-s4-uart'] is too short > ['amlogic,t7-uart', 'amlogic,meson-s4-uart'] is too long > 'amlogic,t7-uart' is not one of ['amlogic,meson6-uart', > 'amlogic,meson8-uart', 'amlogic,meson8b-uart', 'amlogic,meson-gx-uart', > 'amlogic,meson-s4-uart'] > 'amlogic,meson-g12a-uart' was expected > 'amlogic,meson-ao-uart' was expected > 'amlogic,meson-gx-uart' was expected > From schema: > Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml > arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dtb: serial@78000: > Unevaluated properties are not allowed ('compatible' was unexpected) > From schema: > Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml > arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dtb: > /soc/bus@fe000000/serial@78000: failed to match any schema with > compatible: ['amlogic,t7-uart', 'amlogic,meson-s4-uart'] > > This one is OK, the UART bindings is reviewed and should be picked up > for v6.6 > > Neil > >> + }; >> + >> + xtal: xtal-clk { >> + compatible = "fixed-clock"; >> + clock-frequency = <24000000>; >> + clock-output-names = "xtal"; >> + #clock-cells = <0>; >> + }; >> +}; >> + >> +&uart_a { >> + clocks = <&xtal>, <&xtal>, <&xtal>; >> + clock-names = "xtal", "pclk", "baud"; >> + status = "okay"; >> +}; > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] Devicetree for board AN400 based Amlogic T7 SoC 2023-07-04 3:16 [PATCH 0/2] Devicetree for board AN400 based Amlogic T7 SoC Xianwei Zhao 2023-07-04 3:16 ` [PATCH 1/2] dt-bindings: arm: amlogic: add board AN400 Xianwei Zhao 2023-07-04 3:16 ` [PATCH 2/2] arm64: dts: " Xianwei Zhao @ 2023-07-31 9:46 ` Neil Armstrong 2 siblings, 0 replies; 7+ messages in thread From: Neil Armstrong @ 2023-07-31 9:46 UTC (permalink / raw) To: linux-arm-kernel, linux-kernel, linux-amlogic, devicetree, Xianwei Zhao Cc: Catalin Marinas, Will Deacon, Kevin Hilman, Rob Herring, Krzysztof Kozlowski, Conor Dooley Hi, On Tue, 04 Jul 2023 11:16:34 +0800, Xianwei Zhao wrote: > Add the board AN400 tree bindings based Amloigc T7 SoC. > > Add devicetree support for Amlogic AN400 board based T7 SoC. > > Xianwei Zhao (2): > dt-bindings: arm: amlogic: add board AN400 > arm64: dts: add board AN400 > > [...] Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.6/arm64-dt) [1/2] dt-bindings: arm: amlogic: add board AN400 https://git.kernel.org/amlogic/c/015623ec05f96b1614ec2753d25f36743c17c530 [2/2] arm64: dts: add board AN400 https://git.kernel.org/amlogic/c/6f048cc7a635b8736b4c7ae0e5230a92e3e648eb These changes has been applied on the intermediate git tree [1]. The v6.6/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers for inclusion in their intermediate git branches in order to be sent to Linus during the next merge window, or sooner if it's a set of fixes. In the cases of fixes, those will be merged in the current release candidate kernel and as soon they appear on the Linux master branch they will be backported to the previous Stable and Long-Stable kernels [2]. The intermediate git branches are merged daily in the linux-next tree [3], people are encouraged testing these pre-release kernels and report issues on the relevant mailing-lists. If problems are discovered on those changes, please submit a signed-off-by revert patch followed by a corrective changeset. [1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git [2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git [3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git -- Neil ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-07-31 9:48 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-07-04 3:16 [PATCH 0/2] Devicetree for board AN400 based Amlogic T7 SoC Xianwei Zhao 2023-07-04 3:16 ` [PATCH 1/2] dt-bindings: arm: amlogic: add board AN400 Xianwei Zhao 2023-07-04 5:48 ` Krzysztof Kozlowski 2023-07-04 3:16 ` [PATCH 2/2] arm64: dts: " Xianwei Zhao 2023-07-04 8:09 ` Neil Armstrong 2023-07-06 8:44 ` Xianwei Zhao 2023-07-31 9:46 ` [PATCH 0/2] Devicetree for board AN400 based Amlogic T7 SoC Neil Armstrong
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).