Re: [PATCH 1/5] dt-bindings: arm: coresight: Limit static replicator to atclk

[Michal Simek <michal.simek@amd.com>]

On 10/2/26 17:07, Leo Yan wrote:
> Static replicators have no programmable registers and need no APB
> programming clock.
> 
> The Zynq clock controller registers dbg_trc and dbg_apb and calls
> clk_prepare_enable() for each gate the bootloader left on. 

That's one bootloader behavior. If there is another bootloader that clocks can 
be simply disabled. I don't think there is any reason to depends on bootloader 
behavior. If there are clocks which has to be ON I can't see any reason not to 
drive them.

TRM page 741

Trace Port Clock The trace port clock is used to clock the TPIU and trace buffer 
when the MIO interface is chosen and must be twice the frequency of the desired 
TPIU clock. The TPIU clock frequency must be chosen to be fast enough to allow 
the trace port to keep up with the amount of data being traced, but slow enough 
to meet the dynamic characteristics of the data output buffers of the TPIU.

It means even Linux drivers are not handling that clocks that clocks should be 
handled hence described.

That's why I don't think the patch is correct.

Thanks,
Michal