From: Kaustabh Chakraborty <kauschluss@disroot.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org,
Kaustabh Chakraborty <kauschluss@disroot.org>
Subject: Re: [PATCH v2 2/3] mfd: sec: add support for S2MPU05 PMIC
Date: Mon, 24 Feb 2025 23:07:35 +0530 [thread overview]
Message-ID: <11387d3d0478d7fa1899ee3d0409541b@disroot.org> (raw)
In-Reply-To: <20250223-outrageous-bizarre-hedgehog-8a3bbd@krzk-bin>
On 2025-02-23 16:10, Krzysztof Kozlowski wrote:
> Please run scripts/checkpatch.pl and fix reported warnings. After that,
> run also 'scripts/checkpatch.pl --strict' and (probably) fix more
> warnings. Some warnings can be ignored, especially from --strict run,
> but the code here looks like it needs a fix. Feel free to get in touch
> if the warning is not clear.
>
> Missing bindings.
Bindings have been applied in v1.
> BTW, don't combine independent patches from different subsystems into
> one patchset. It's not helping anyone especially without explaining
> dependencies/merging in the cover letter or here in changelog.
Alright I'm a bit lost here. The binding patch (the one you enquired
for above) referenced the regulator bindings, whereas the regulator
driver is including the S2MU005 PMIC header which defines the
register addresses, etc.
So it seems like patches from both subsystems are inter-dependent
on each other, and hence both are put together in a single series.
What should I do then? Should I explicitly mention this in the cover
letter? Or split into two? Or...?
next prev parent reply other threads:[~2025-02-24 17:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 18:49 [PATCH v2 0/3] Introduce support for Exynos7870's S2MPU05 PMIC and its regulators Kaustabh Chakraborty
2025-02-18 18:49 ` [PATCH v2 1/3] regulator: dt-bindings: add documentation for s2mpu05-pmic regulators Kaustabh Chakraborty
2025-02-23 10:38 ` Krzysztof Kozlowski
2025-02-18 18:49 ` [PATCH v2 2/3] mfd: sec: add support for S2MPU05 PMIC Kaustabh Chakraborty
2025-02-23 10:40 ` Krzysztof Kozlowski
2025-02-24 17:37 ` Kaustabh Chakraborty [this message]
2025-02-24 19:18 ` Krzysztof Kozlowski
2025-02-25 18:14 ` Kaustabh Chakraborty
2025-02-25 18:44 ` Krzysztof Kozlowski
2025-02-25 20:06 ` Kaustabh Chakraborty
2025-02-18 18:49 ` [PATCH v2 3/3] regulator: s2mps11: Add support for S2MPU05 regulators Kaustabh Chakraborty
2025-02-23 10:42 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11387d3d0478d7fa1899ee3d0409541b@disroot.org \
--to=kauschluss@disroot.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox