From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCHv3 2/3] ARM: dts: exynos4212: Add missing clock for multi core timer Date: Sun, 10 Nov 2013 19:15:21 +0100 Message-ID: <11439632.EJeOOmBkrd@flatron> References: <1383530161-24080-1-git-send-email-cw00.choi@samsung.com> <1383530161-24080-3-git-send-email-cw00.choi@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1383530161-24080-3-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chanwoo Choi Cc: kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, Marek Szyprowski List-Id: devicetree@vger.kernel.org Hi Chanwoo, Marek, On Monday 04 of November 2013 10:56:00 Chanwoo Choi wrote: > From: Marek Szyprowski > No patch description? > Signed-off-by: Marek Szyprowski > Signed-off-by: Kyungmin Park > --- > arch/arm/boot/dts/exynos4212.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi > index 3081bae..d7a3fbc 100644 > --- a/arch/arm/boot/dts/exynos4212.dtsi > +++ b/arch/arm/boot/dts/exynos4212.dtsi > @@ -43,6 +43,8 @@ > interrupt-parent = <&mct_map>; > interrupts = <0 0>, <1 0>, <2 0>, <3 0>, > <4 0>, <5 0>; > + clocks = <&clock 3>, <&clock 344>; > + clock-names = "fin_pll", "mct"; > > mct_map: mct-map { > #interrupt-cells = <2>; > Otherwise the patch is technically correct, but I have already sent a series[1] that moves MCT node one level up to exynos4x12.dtsi, which also solves this problem. [1] http://thread.gmane.org/gmane.linux.kernel.samsung-soc/22207/focus=22208 Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html