[PATCHv3 0/3] ARM: dts: exynos: Add missing dt data to bring up kernel featurea

[PATCHv3 0/3] ARM: dts: exynos: Add missing dt data to bring up kernel featurea

[Chanwoo Choi]

This patchset add missing dt data to bring up kernel feature
- GPS_ALIVE power domain
- PMU
- Clock data for Multi core timer

Changes since v2:
- Delete MAUDIO power domain

Changes since v1:
- Fix wrong address of GPS_ALIVE power domain

Chanwoo Choi (2):
  ARM: dts: exynos4212: Add PMU dt data for pmu-irq
  ARM: dts: exynos4x12: Add gps_alive power domain for exynos4x12

Marek Szyprowski (1):
  ARM: dts: exynos4212: Add missing clock for multi core timer

 arch/arm/boot/dts/exynos4212.dtsi | 8 ++++++++
 arch/arm/boot/dts/exynos4x12.dtsi | 5 +++++
 2 files changed, 13 insertions(+)

-- 
1.8.0

[PATCHv3 1/3] ARM: dts: exynos4212: Add PMU dt data for pmu-irq

[Chanwoo Choi]

Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 arch/arm/boot/dts/exynos4212.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi
index 6f34d7f..3081bae 100644
--- a/arch/arm/boot/dts/exynos4212.dtsi
+++ b/arch/arm/boot/dts/exynos4212.dtsi
@@ -56,4 +56,10 @@
 					<0x5 0 &gic 1 12 0>;
 		};
 	};
+
+	pmu {
+		compatible = "arm,cortex-a9-pmu";
+		interrupt-parent = <&combiner>;
+		interrupts = <2 2>, <3 2>;
+	};
 };
-- 
1.8.0

Re: [PATCHv3 1/3] ARM: dts: exynos4212: Add PMU dt data for pmu-irq

[Tomasz Figa]

Hi Chanwoo,

Please add a patch description. Even if trivial, it is good to have one.

On Monday 04 of November 2013 10:55:59 Chanwoo Choi wrote:
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4212.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi
> index 6f34d7f..3081bae 100644
> --- a/arch/arm/boot/dts/exynos4212.dtsi
> +++ b/arch/arm/boot/dts/exynos4212.dtsi
> @@ -56,4 +56,10 @@
>  					<0x5 0 &gic 1 12 0>;
>  		};
>  	};
> +
> +	pmu {
> +		compatible = "arm,cortex-a9-pmu";
> +		interrupt-parent = <&combiner>;
> +		interrupts = <2 2>, <3 2>;
> +	};

I believe it would be better to put this in exynos4x12.dtsi, specifying
all four interrupts for possible four cores in Exynos4412. It would be
fine, since the interrupt layout is the same on all Exynos4x12 SoCs, just
some interrupts are not used.

Best regards,
Tomasz

[PATCHv3 2/3] ARM: dts: exynos4212: Add missing clock for multi core timer

[Chanwoo Choi]

From: Marek Szyprowski <m.szyprowski@samsung.com>

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 arch/arm/boot/dts/exynos4212.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi
index 3081bae..d7a3fbc 100644
--- a/arch/arm/boot/dts/exynos4212.dtsi
+++ b/arch/arm/boot/dts/exynos4212.dtsi
@@ -43,6 +43,8 @@
 		interrupt-parent = <&mct_map>;
 		interrupts = <0 0>, <1 0>, <2 0>, <3 0>,
 			     <4 0>, <5 0>;
+		clocks = <&clock 3>, <&clock 344>;
+		clock-names = "fin_pll", "mct";
 
 		mct_map: mct-map {
 			#interrupt-cells = <2>;
-- 
1.8.0

Re: [PATCHv3 2/3] ARM: dts: exynos4212: Add missing clock for multi core timer

[Tomasz Figa]

Hi Chanwoo, Marek,

On Monday 04 of November 2013 10:56:00 Chanwoo Choi wrote:
> From: Marek Szyprowski <m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> 

No patch description?

> Signed-off-by: Marek Szyprowski <m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>  arch/arm/boot/dts/exynos4212.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi
> index 3081bae..d7a3fbc 100644
> --- a/arch/arm/boot/dts/exynos4212.dtsi
> +++ b/arch/arm/boot/dts/exynos4212.dtsi
> @@ -43,6 +43,8 @@
>  		interrupt-parent = <&mct_map>;
>  		interrupts = <0 0>, <1 0>, <2 0>, <3 0>,
>  			     <4 0>, <5 0>;
> +		clocks = <&clock 3>, <&clock 344>;
> +		clock-names = "fin_pll", "mct";
>  
>  		mct_map: mct-map {
>  			#interrupt-cells = <2>;
> 

Otherwise the patch is technically correct, but I have already sent
a series[1] that moves MCT node one level up to exynos4x12.dtsi, which
also solves this problem.

[1] http://thread.gmane.org/gmane.linux.kernel.samsung-soc/22207/focus=22208

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHv3 3/3] ARM: dts: exynos4x12: Add gps_alive power domain for exynos4x12

[Chanwoo Choi]

This patch gps_alive power domain to exynos4x12.dtsi.

Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 arch/arm/boot/dts/exynos4x12.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
index ad531fe..3f5b416 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -35,6 +35,11 @@
 		reg = <0x10023CA0 0x20>;
 	};
 
+	pd_gps_alive: gps-alive-power-domain@10023D00 {
+		compatible = "samsung,exynos4210-pd";
+		reg = <0x10023D00 0x20>;
+	};
+
 	clock: clock-controller@10030000 {
 		compatible = "samsung,exynos4412-clock";
 		reg = <0x10030000 0x20000>;
-- 
1.8.0

Re: [PATCHv3 3/3] ARM: dts: exynos4x12: Add gps_alive power domain for exynos4x12

[Tomasz Figa]

Hi Chanwoo,

On Monday 04 of November 2013 10:56:01 Chanwoo Choi wrote:
> This patch gps_alive power domain to exynos4x12.dtsi.

Patch description lacks rationale behind the change.

> 
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4x12.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
> index ad531fe..3f5b416 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -35,6 +35,11 @@
>  		reg = <0x10023CA0 0x20>;
>  	};
>  
> +	pd_gps_alive: gps-alive-power-domain@10023D00 {
> +		compatible = "samsung,exynos4210-pd";
> +		reg = <0x10023D00 0x20>;
> +	};
> +
>  	clock: clock-controller@10030000 {
>  		compatible = "samsung,exynos4412-clock";
>  		reg = <0x10030000 0x20000>;
> 

Otherwise the patch looks good.

Best regards,
Tomasz