Re: [PATCH v6] MIPS: NI 169445 board support

[Paul Burton <paul.burton-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

Hi Ralf,

On Monday, 7 August 2017 08:26:48 PDT Ralf Baechle wrote:
> On Tue, Jul 18, 2017 at 01:29:09PM -0500, Nathan Sullivan wrote:
> > diff --git a/arch/mips/generic/vmlinux.its.S
> > b/arch/mips/generic/vmlinux.its.S index f67fbf1..de851f7 100644
> > --- a/arch/mips/generic/vmlinux.its.S
> > +++ b/arch/mips/generic/vmlinux.its.S
> > @@ -29,3 +29,28 @@
> > 
> >  		};
> >  	
> >  	};
> >  
> >  };
> > 
> > +
> > +#ifdef CONFIG_FIT_IMAGE_FDT_NI169445
> > +/ {
> > +	images {
> 
> [...]
> 
> > +	};
> > +};
> > +#endif
> 
> There's been a reject on this file because of a Boston #ifdefed section.
> I've fixed that up but we need a cleaner solution.  Paul, any suggestions?
> 
>   Ralf

One possibility would be for us to split the board portions of vmlinux.its.S 
out into a file per-board, perhaps board-boston.its.S, board-ni169445.its.S 
etc. The build process would then have to concatenate the right files to 
generate the full image tree source.

Does that sound good to you?

Thanks,
    Paul

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]