From: Matthias Brugger <matthias.bgg@gmail.com>
To: Eugen Hristev <eugen.hristev@collabora.com>,
Rob Herring <robh@kernel.org>
Cc: bin.liu@mediatek.com, angelogioacchino.delregno@collabora.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: media: mediatek-jpeg-encoder: change max ioomus count
Date: Mon, 22 Jan 2024 08:54:34 +0100 [thread overview]
Message-ID: <115ec234-64b8-4dc0-8db2-aa1e81b4f3db@gmail.com> (raw)
In-Reply-To: <94beea2a-c4b9-4241-bbfe-8c57ca50fbf7@collabora.com>
On 15/01/2024 04:57, Eugen Hristev wrote:
> On 1/9/24 05:27, Rob Herring wrote:
>> On Wed, Dec 27, 2023 at 03:08:11PM +0200, Eugen Hristev wrote:
>>> MT8186 has 4 iommus in the list, to cope with this situation, adjust
>>> the maxItems to 4 (instead of previous 2).
>>> Add also minItems as 1 since iommus are mandatory, to avoid warning
>>> on the example.
>>
>> maxItems alone means minItems is the same size. If IOMMU is required,
>> then 'required' is where that is defined. Is there a case where 1 IOMMU
>> is valid? If so, what h/w has this case.
>>
>> Rob
>>
>>
>
> Hello Rob,
>
> Without setting a minItems , the example in the binding fails, because it has just
> 2 items, while the maxItems is now 4.
> I set minItems as 1 to avoid restricting any kind of hardware to have at least 2
> items, but if you claim that previously, maxItems=minItems=2 , I will change this to 2.
> Is that fine with you ?
>
I think that's what you should do yes. If in the future there shows up a
platform with just one iommu, then we can fix that.
Regards,
Matthias
prev parent reply other threads:[~2024-01-22 7:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 13:08 [PATCH 1/2] dt-bindings: media: mediatek-jpeg-encoder: change max ioomus count Eugen Hristev
2023-12-27 13:08 ` [PATCH 2/2] arm64: dts: mediatek: mt8186: Add jpgenc node Eugen Hristev
2024-01-02 9:28 ` AngeloGioacchino Del Regno
2024-01-02 9:29 ` [PATCH 1/2] dt-bindings: media: mediatek-jpeg-encoder: change max ioomus count AngeloGioacchino Del Regno
2024-01-09 3:27 ` Rob Herring
2024-01-15 3:57 ` Eugen Hristev
2024-01-22 7:54 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=115ec234-64b8-4dc0-8db2-aa1e81b4f3db@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bin.liu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).