From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: andriy.shevchenko@linux.intel.com,
mika.westerberg@linux.intel.com, robh+dt@kernel.org,
krzk+dt@kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCHv6 1/2] i2c: designware: introduce a custom scl recovery for SoCFPGA platforms
Date: Tue, 21 Jun 2022 17:14:56 +0300 [thread overview]
Message-ID: <116511f7-2d05-acf6-e421-a89797abb7a0@linux.intel.com> (raw)
In-Reply-To: <20220620230109.986298-1-dinguyen@kernel.org>
On 6/21/22 02:01, Dinh Nguyen wrote:
> The I2C pins on the SoCFPGA platforms do not go through a GPIO module,
> thus cannot be recovered by the default method of by doing a GPIO access.
> Only a reset of the I2C IP block can a recovery be successful, so this
> change effectively resets the I2C controller, NOT any attached clients.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
> ---
> v6: Updated commit log to emphasize this change only resets the I2C
> controller and not any attached clients.
> v5: removed strayed nextline
> v4: re-arrange code per Andy Shevchenko's recommendation
> v3: simplify the function
> update commit message
> v2: remove change to MODEL_MASK
> s/i2c_custom_scl_recovery/i2c_socfpga_scl_recovery
> ---
> drivers/i2c/busses/i2c-designware-core.h | 1 +
> drivers/i2c/busses/i2c-designware-master.c | 49 ++++++++++++++++++---
> drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
> 3 files changed, 45 insertions(+), 6 deletions(-)
>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2022-06-21 14:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 23:01 [PATCHv6 1/2] i2c: designware: introduce a custom scl recovery for SoCFPGA platforms Dinh Nguyen
2022-06-20 23:01 ` [PATCHv6 2/2] dt-bindings: i2c: dw: Add Intel's SoCFPGA I2C controller Dinh Nguyen
2022-06-21 14:14 ` Jarkko Nikula [this message]
2022-06-21 21:37 ` [PATCHv6 1/2] i2c: designware: introduce a custom scl recovery for SoCFPGA platforms Wolfram Sang
2022-06-22 13:45 ` Dinh Nguyen
2022-06-22 20:07 ` Wolfram Sang
2022-07-12 12:41 ` Dinh Nguyen
2022-07-12 12:52 ` Dinh Nguyen
2022-07-12 13:29 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=116511f7-2d05-acf6-e421-a89797abb7a0@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).