From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29618C433E6 for ; Mon, 25 Jan 2021 23:43:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA90F207D0 for ; Mon, 25 Jan 2021 23:43:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732370AbhAYXnp (ORCPT ); Mon, 25 Jan 2021 18:43:45 -0500 Received: from gloria.sntech.de ([185.11.138.130]:33838 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732962AbhAYXlx (ORCPT ); Mon, 25 Jan 2021 18:41:53 -0500 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l4BTA-00060r-Kk; Tue, 26 Jan 2021 00:40:28 +0100 From: Heiko Stuebner To: Johan Jonker , Guenter Roeck Cc: robh+dt@kernel.org, wim@linux-watchdog.org, jamie@jamieiles.com, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml Date: Tue, 26 Jan 2021 00:40:27 +0100 Message-ID: <11680602.O9o76ZdvQC@phil> In-Reply-To: <20210123173401.GA57343@roeck-us.net> References: <20201218120534.13788-1-jbx6244@gmail.com> <20210123173401.GA57343@roeck-us.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Guenter, Am Samstag, 23. Januar 2021, 18:34:01 CET schrieb Guenter Roeck: > On Fri, Dec 18, 2020 at 01:05:27PM +0100, Johan Jonker wrote: > > The watchdog compatible strings are suppose to be SoC orientated. > > In the more recently added Rockchip SoC dtsi files only > > the fallback string "snps,dw-wdt" is used, so add the following > > compatible strings: > > > > "rockchip,px30-wdt", "snps,dw-wdt" > > "rockchip,rk3228-wdt", "snps,dw-wdt" > > "rockchip,rk3308-wdt", "snps,dw-wdt" > > "rockchip,rk3328-wdt", "snps,dw-wdt" > > "rockchip,rk3399-wdt", "snps,dw-wdt" > > "rockchip,rv1108-wdt", "snps,dw-wdt" > > > > make ARCH=arm dtbs_check > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml > > > > make ARCH=arm64 dtbs_check > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml > > > > Signed-off-by: Johan Jonker > > Acked-by: Rob Herring > > Reviewed-by: Heiko Stuebner > > Reviewed-by: Guenter Roeck just to clarify, do you expect me to pick up the dt-binding patch with the devicetree patches or do you want to take this individual patch through the watchdog tree instead? Thanks Heiko > > --- > > Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml > > index f7ee9229c..b58596b18 100644 > > --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml > > +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml > > @@ -18,10 +18,16 @@ properties: > > - const: snps,dw-wdt > > - items: > > - enum: > > + - rockchip,px30-wdt > > - rockchip,rk3066-wdt > > - rockchip,rk3188-wdt > > + - rockchip,rk3228-wdt > > - rockchip,rk3288-wdt > > + - rockchip,rk3308-wdt > > + - rockchip,rk3328-wdt > > - rockchip,rk3368-wdt > > + - rockchip,rk3399-wdt > > + - rockchip,rv1108-wdt > > - const: snps,dw-wdt > > > > reg: >