From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: Qii Wang <qii.wang@mediatek.com>
Cc: Joe Perches <joe@perches.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Wolfram Sang <wsa@the-dreams.de>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
srv_heupstream@mediatek.com, leilk.liu@mediatek.com,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-mediatek@lists.infradead.org,
Linux I2C <linux-i2c@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] i2c: mediatek: Add i2c ac-timing adjust support
Date: Tue, 19 May 2020 07:17:41 -0400 [thread overview]
Message-ID: <116825.1589887061@turing-police> (raw)
In-Reply-To: <1589857073.25512.34.camel@mhfsdcap03>
[-- Attachment #1: Type: text/plain, Size: 599 bytes --]
On Tue, 19 May 2020 10:57:53 +0800, Qii Wang said:
> (1000000000 * (sample_cnt + 1)) / clk_src value is a 32-bit, (1000000000
> * (sample_cnt + 1)) will over 32-bit if sample_cnt is 7.
>
> I think 1000000000 and clk_src is too big, maybe I can reduce then with
> be divided all by 1000.
Yes, it's definitely too big, the 3 DIV_ROUND_UP calls in mtk_i2c_check_ac_timing()
end up causing a build issue during modpost on a 32-bit RPi4:
ERROR: modpost: "__aeabi_uldivmod" [drivers/i2c/busses/i2c-mt65xx.ko] undefined!
ERROR: modpost: "__aeabi_ldivmod" [drivers/i2c/busses/i2c-mt65xx.ko] undefined!
[-- Attachment #2: Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-05-19 11:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 13:09 [PATCH v2 0/2] Add i2c ac-timing adjust support Qii Wang
2020-05-14 13:09 ` [PATCH v2 1/2] MAINTAINERS: add maintainer for mediatek i2c controller driver Qii Wang
2020-05-15 9:40 ` Wolfram Sang
2020-05-14 13:09 ` [PATCH v2 2/2] i2c: mediatek: Add i2c ac-timing adjust support Qii Wang
2020-05-15 9:40 ` Wolfram Sang
2020-05-18 15:44 ` Geert Uytterhoeven
2020-05-19 2:57 ` Qii Wang
2020-05-19 7:14 ` Geert Uytterhoeven
2020-05-20 8:41 ` Qii Wang
2020-05-20 8:58 ` Geert Uytterhoeven
2020-05-20 9:14 ` Qii Wang
2020-05-19 11:17 ` Valdis Klētnieks [this message]
2020-06-20 7:45 ` Yingjoe Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=116825.1589887061@turing-police \
--to=valdis.kletnieks@vt.edu \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=joe@perches.com \
--cc=leilk.liu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=qii.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).