From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Michael Walle <michael@walle.cc>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: UNGLinuxDriver@microchip.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 4/4] ARM: dts: lan966x: use new microchip,lan9668-switch compatible
Date: Thu, 30 Jun 2022 21:18:51 +0200 [thread overview]
Message-ID: <116f0087-17d1-652f-23f5-b114e6082273@linaro.org> (raw)
In-Reply-To: <20220630140237.692986-5-michael@walle.cc>
On 30/06/2022 16:02, Michael Walle wrote:
> The old generic microchip,lan966x-switch compatible string was
> deprecated. Use the new one.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> arch/arm/boot/dts/lan966x.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
> index 48971d80c82c..da0657c57cdf 100644
> --- a/arch/arm/boot/dts/lan966x.dtsi
> +++ b/arch/arm/boot/dts/lan966x.dtsi
> @@ -85,7 +85,7 @@ soc {
> ranges;
>
> switch: switch@e0000000 {
> - compatible = "microchip,lan966x-switch";
> + compatible = "microchip,lan9668-switch";
While technically correct, the change cannot go via independent trees
and may break out-of-tree users of this DTS.
Usually the nicer way is to use two compatibles (the old as fallback).
Anyway, this one is fine with me - up to subarch maintainer.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-30 19:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 14:02 [PATCH net-next 0/4] net: lan966x: hardcode port count Michael Walle
2022-06-30 14:02 ` [PATCH net-next 1/4] net: lan966x: hardcode the number of external ports Michael Walle
2022-06-30 14:02 ` [PATCH net-next 2/4] dt-bindings: net: lan966x: add specific compatible string Michael Walle
2022-06-30 14:02 ` [PATCH net-next 3/4] net: lan966x: add new compatible microchip,lan9668-switch Michael Walle
2022-06-30 14:02 ` [PATCH net-next 4/4] ARM: dts: lan966x: use new microchip,lan9668-switch compatible Michael Walle
2022-06-30 19:18 ` Krzysztof Kozlowski [this message]
2022-06-30 20:44 ` [PATCH net-next 0/4] net: lan966x: hardcode port count Horatiu Vultur
2022-06-30 20:56 ` Michael Walle
2022-06-30 21:21 ` Horatiu Vultur
2022-06-30 21:08 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=116f0087-17d1-652f-23f5-b114e6082273@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=horatiu.vultur@microchip.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox