From: Tomasz Figa <tomasz.figa@gmail.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: kgene.kim@samsung.com, t.figa@samsung.com,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, myungjoo.ham@samsung.com,
m.szyprowski@samsung.com, phil.carmody@partner.samsung.com,
j.anaszewski@samsung.com, kyungmin.park@samsung.com,
devicetree-discuss@lists.ozlabs.org,
Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [PATCH v3 12/13] ARM: dts: Add S5K5BA sensor regulator definitions for Trats board
Date: Sat, 06 Jul 2013 01:26:03 +0200 [thread overview]
Message-ID: <11736061.3CXfgF4Q9h@flatron> (raw)
In-Reply-To: <1372692155-17653-13-git-send-email-s.nawrocki@samsung.com>
Hi Sylwester, Andrzej,
On Monday 01 of July 2013 17:22:34 Sylwester Nawrocki wrote:
> From: Andrzej Hajda <a.hajda@samsung.com>
>
> Add MAX8998 LDO12 and fixed voltage regulator nodes. While at it,
> all fixed voltage regulator nodes are grouped in a 'regulators' node.
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/boot/dts/exynos4210-trats.dts | 80
> +++++++++++++++++++++++++------- 1 file changed, 64 insertions(+), 16
> deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4210-trats.dts
> b/arch/arm/boot/dts/exynos4210-trats.dts index 6b1568e..f62e299 100644
> --- a/arch/arm/boot/dts/exynos4210-trats.dts
> +++ b/arch/arm/boot/dts/exynos4210-trats.dts
> @@ -30,13 +30,64 @@
> bootargs = "console=ttySAC2,115200N8 root=/dev/mmcblk0p5
rootwait
> earlyprintk panic=5"; };
>
> - vemmc_reg: voltage-regulator@0 {
> - compatible = "regulator-fixed";
> - regulator-name = "VMEM_VDD_2.8V";
> - regulator-min-microvolt = <2800000>;
> - regulator-max-microvolt = <2800000>;
> - gpio = <&gpk0 2 0>;
> - enable-active-high;
> + regulators {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <0>;
I don't think any addressing is needed for these regulators, so I'd
suggest removing those #properties and replacing @N with -N suffix.
Otherwise looks good.
Best regards,
Tomasz
> +
> + vemmc_reg: regulator@0 {
> + compatible = "regulator-fixed";
> + regulator-name = "VMEM_VDD_2.8V";
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> + gpio = <&gpk0 2 0>;
> + enable-active-high;
> + };
> +
> + tsp_reg: regulator@1 {
> + compatible = "regulator-fixed";
> + regulator-name = "TSP_FIXED_VOLTAGES";
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> + gpio = <&gpl0 3 0>;
> + enable-active-high;
> + };
> +
> + cam_af_28v_reg: regulator@2 {
> + compatible = "regulator-fixed";
> + regulator-name = "8M_AF_2.8V_EN";
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> + gpio = <&gpk1 1 0>;
> + enable-active-high;
> + };
> +
> + cam_io_en_reg: regulator@3 {
> + compatible = "regulator-fixed";
> + regulator-name = "CAM_IO_EN";
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> + gpio = <&gpe2 1 0>;
> + enable-active-high;
> + };
> +
> + cam_io_12v_reg: regulator@4 {
> + compatible = "regulator-fixed";
> + regulator-name = "8M_1.2V_EN";
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + gpio = <&gpe2 5 0>;
> + enable-active-high;
> + };
> +
> + vt_core_15v_reg: regulator@5 {
> + compatible = "regulator-fixed";
> + regulator-name = "VT_CORE_1.5V";
> + regulator-min-microvolt = <1500000>;
> + regulator-max-microvolt = <1500000>;
> + gpio = <&gpe2 2 0>;
> + enable-active-high;
> + };
> };
>
> sdhci_emmc: sdhci@12510000 {
> @@ -97,15 +148,6 @@
> };
> };
>
> - tsp_reg: voltage-regulator {
> - compatible = "regulator-fixed";
> - regulator-name = "TSP_FIXED_VOLTAGES";
> - regulator-min-microvolt = <2800000>;
> - regulator-max-microvolt = <2800000>;
> - gpio = <&gpl0 3 0>;
> - enable-active-high;
> - };
> -
> i2c@13890000 {
> samsung,i2c-sda-delay = <100>;
> samsung,i2c-slave-addr = <0x10>;
> @@ -218,6 +260,12 @@
> regulator-always-on;
> };
>
> + vtcam_reg: LDO12 {
> + regulator-name = "VT_CAM_1.8V";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> +
> vcclcd_reg: LDO13 {
> regulator-name = "VCC_3.3V_LCD";
> regulator-min-microvolt = <3300000>;
next prev parent reply other threads:[~2013-07-05 23:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 15:22 [PATCH v3 00/13] ARM: dts: Add camera and magnetometer support for TRATS(2) board Sylwester Nawrocki
2013-07-01 15:22 ` [PATCH v3 01/13] ARM: dts: Correct camera pinctrl nodes for Exynos4x12 SoCs Sylwester Nawrocki
2013-07-01 15:22 ` [PATCH v3 02/13] ARM: dts: Add pinctrl entries for Exynos4x12 FIMC-IS peripherals Sylwester Nawrocki
2013-07-01 15:22 ` [PATCH v3 03/13] ARM: dts: Add ISP power domain node for Exynos4x12 Sylwester Nawrocki
2013-07-01 15:22 ` [PATCH v3 04/13] ARM: dts: Use generic DMA bindings for Exynos4 SPI devices Sylwester Nawrocki
2013-07-01 15:22 ` [PATCH v3 05/13] ARM: dts: Add camera subsystem device nodes to exynos4.dtsi Sylwester Nawrocki
2013-07-01 15:22 ` [PATCH v3 06/13] ARM: dts: Add camera subsystem nodes to exynos4x12.dtsi Sylwester Nawrocki
2013-07-01 15:22 ` [PATCH v3 07/13] ARM: dts: Add AK8975 device node for Exynos4412 TRATS2 board Sylwester Nawrocki
2013-07-05 23:18 ` Tomasz Figa
2013-07-08 12:52 ` Sylwester Nawrocki
2013-07-01 15:22 ` [PATCH v3 08/13] ARM: dts: Add camera device nodes " Sylwester Nawrocki
2013-07-05 23:23 ` Tomasz Figa
2013-07-08 13:13 ` Sylwester Nawrocki
2013-07-01 15:22 ` [PATCH v3 09/13] ARM: dts: Add camera device nodes for Exynos4210 SoCs Sylwester Nawrocki
2013-07-01 15:22 ` [PATCH v3 10/13] ARM: dts: Add FIMC nodes for Exynos4210 Trats board Sylwester Nawrocki
2013-07-01 15:22 ` [PATCH v3 11/13] ARM: dts: Add Exynos4210 SoC camera port pinctrl nodes Sylwester Nawrocki
2013-07-01 15:22 ` [PATCH v3 12/13] ARM: dts: Add S5K5BA sensor regulator definitions for Trats board Sylwester Nawrocki
2013-07-05 23:26 ` Tomasz Figa [this message]
2013-07-08 14:12 ` Sylwester Nawrocki
2013-07-08 14:19 ` Tomasz Figa
2013-07-01 15:22 ` [PATCH v3 13/13] ARM: dts: Add MIPI PHY node to exynos4.dtsi Sylwester Nawrocki
2013-07-05 23:27 ` [PATCH v3 00/13] ARM: dts: Add camera and magnetometer support for TRATS(2) board Tomasz Figa
2013-07-24 13:00 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11736061.3CXfgF4Q9h@flatron \
--to=tomasz.figa@gmail.com \
--cc=a.hajda@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=j.anaszewski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=myungjoo.ham@samsung.com \
--cc=phil.carmody@partner.samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).