[PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute

[PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute

[Heinrich Schuchardt]

Downstream packages like Debian flash-kernel rely on
/proc/device-tree/model
to determine how to install an updated kernel image.

Most dts files provide this property.
It is suggested by IEEE Std 1275-1994.

This patch adds a model attribute for Octeon CPUs.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts | 1 +
 arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
index 9c48e05..a746678 100644
--- a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
+++ b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
@@ -8,6 +8,7 @@
  */
 / {
 	compatible = "cavium,octeon-3860";
+	model = "Cavium Octeon 3XXX";
 	#address-cells = <2>;
 	#size-cells = <2>;
 	interrupt-parent = <&ciu>;
diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
index 79b46fc..c8a292a 100644
--- a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
+++ b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
@@ -8,6 +8,7 @@
  */
 / {
 	compatible = "cavium,octeon-6880";
+	model = "Cavium Octeon 68XX";
 	#address-cells = <2>;
 	#size-cells = <2>;
 	interrupt-parent = <&ciu2>;
-- 
2.1.4

Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute

[Sergei Shtylyov]

Hello.

On 2/15/2016 8:26 AM, Heinrich Schuchardt wrote:

> Downstream packages like Debian flash-kernel rely on
> /proc/device-tree/model
> to determine how to install an updated kernel image.
>
> Most dts files provide this property.
> It is suggested by IEEE Std 1275-1994.
>
> This patch adds a model attribute for Octeon CPUs.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>   arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts | 1 +
>   arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
> index 9c48e05..a746678 100644
> --- a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
> +++ b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
> @@ -8,6 +8,7 @@
>    */
>   / {
>   	compatible = "cavium,octeon-3860";
> +	model = "Cavium Octeon 3XXX";
>   	#address-cells = <2>;
>   	#size-cells = <2>;
>   	interrupt-parent = <&ciu>;
> diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
> index 79b46fc..c8a292a 100644
> --- a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
> +++ b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
> @@ -8,6 +8,7 @@
>    */
>   / {
>   	compatible = "cavium,octeon-6880";
> +	model = "Cavium Octeon 68XX";
>   	#address-cells = <2>;
>   	#size-cells = <2>;
>   	interrupt-parent = <&ciu2>;

     The ePAPR 1.1 standard says:

2.3.2 model

Property: model
Value type: <string>
Description:
	The model property value is a <string> that specifies the
  	manufacturer’s model number of the device.

	The recommended format is: “manufacturer,model”, where manufacturer
	is a string describing the name of the manufacturer (such as a stock
	ticker symbol), and model specifies the model number.

Example:
	model = “fsl,MPC8349EMITX”;

MBR, Sergei

Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute

[Arnd Bergmann]

On Monday 15 February 2016 14:16:48 Sergei Shtylyov wrote:
> 
> Property: model
> Value type: <string>
> Description:
>         The model property value is a <string> that specifies the
>         manufacturer’s model number of the device.
> 
>         The recommended format is: “manufacturer,model”, where manufacturer
>         is a string describing the name of the manufacturer (such as a stock
>         ticker symbol), and model specifies the model number.
> 
> 

This also means that you absolutely cannot have wildcards in there (same
rule as for the compatible strings) and that the property should be in the
.dts file, not .dtsi.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute

[Heinrich Schuchardt]

On 02/15/2016 12:16 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 2/15/2016 8:26 AM, Heinrich Schuchardt wrote:
> 
>> Downstream packages like Debian flash-kernel rely on
>> /proc/device-tree/model
>> to determine how to install an updated kernel image.
>>
>> Most dts files provide this property.
>> It is suggested by IEEE Std 1275-1994.
>>
>> This patch adds a model attribute for Octeon CPUs.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> ---
>>   arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts | 1 +
>>   arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
>> b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
>> index 9c48e05..a746678 100644
>> --- a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
>> +++ b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
>> @@ -8,6 +8,7 @@
>>    */
>>   / {
>>       compatible = "cavium,octeon-3860";
>> +    model = "Cavium Octeon 3XXX";
>>       #address-cells = <2>;
>>       #size-cells = <2>;
>>       interrupt-parent = <&ciu>;
>> diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
>> b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
>> index 79b46fc..c8a292a 100644
>> --- a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
>> +++ b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
>> @@ -8,6 +8,7 @@
>>    */
>>   / {
>>       compatible = "cavium,octeon-6880";
>> +    model = "Cavium Octeon 68XX";
>>       #address-cells = <2>;
>>       #size-cells = <2>;
>>       interrupt-parent = <&ciu2>;
> 
>     The ePAPR 1.1 standard says:
> 
> 2.3.2 model
> 
> Property: model
> Value type: <string>
> Description:
>     The model property value is a <string> that specifies the
>      manufacturer’s model number of the device.
> 
>     The recommended format is: “manufacturer,model”, where manufacturer
>     is a string describing the name of the manufacturer (such as a stock
>     ticker symbol), and model specifies the model number.
> 
> Example:
>     model = “fsl,MPC8349EMITX”;
> 
> MBR, Sergei
> 
> 

Hello Sergei, hello Arnd,

thank you for reviewing.

IEEE Std 1275-1994 says stock symbols should be in upper case.

I guess international standards should have precedence over papers valid
for a single architecture (power.org).

Would you support a patch having the following strings?

model = "CAVM, Octeon 3860";
model = "CAVM, Octeon 6880";

Otherwise, please, make a suggestion.

Best regards

Heinrich Schuchardt

Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute

[Sergei Shtylyov]

On 02/15/2016 08:52 PM, Heinrich Schuchardt wrote:

>>> Downstream packages like Debian flash-kernel rely on
>>> /proc/device-tree/model
>>> to determine how to install an updated kernel image.
>>>
>>> Most dts files provide this property.
>>> It is suggested by IEEE Std 1275-1994.
>>>
>>> This patch adds a model attribute for Octeon CPUs.
>>>
>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>>> ---
>>>    arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts | 1 +
>>>    arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts | 1 +
>>>    2 files changed, 2 insertions(+)
>>>
>>> diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
>>> b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
>>> index 9c48e05..a746678 100644
>>> --- a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
>>> +++ b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
>>> @@ -8,6 +8,7 @@
>>>     */
>>>    / {
>>>        compatible = "cavium,octeon-3860";
>>> +    model = "Cavium Octeon 3XXX";
>>>        #address-cells = <2>;
>>>        #size-cells = <2>;
>>>        interrupt-parent = <&ciu>;
>>> diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
>>> b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
>>> index 79b46fc..c8a292a 100644
>>> --- a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
>>> +++ b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
>>> @@ -8,6 +8,7 @@
>>>     */
>>>    / {
>>>        compatible = "cavium,octeon-6880";
>>> +    model = "Cavium Octeon 68XX";
>>>        #address-cells = <2>;
>>>        #size-cells = <2>;
>>>        interrupt-parent = <&ciu2>;
>>
>>      The ePAPR 1.1 standard says:
>>
>> 2.3.2 model
>>
>> Property: model
>> Value type: <string>
>> Description:
>>      The model property value is a <string> that specifies the
>>       manufacturer’s model number of the device.
>>
>>      The recommended format is: “manufacturer,model”, where manufacturer
>>      is a string describing the name of the manufacturer (such as a stock
>>      ticker symbol), and model specifies the model number.
>>
>> Example:
>>      model = “fsl,MPC8349EMITX”;
[...]

> Hello Sergei, hello Arnd,
>
> thank you for reviewing.
>
> IEEE Std 1275-1994 says stock symbols should be in upper case.
>
> I guess international standards should have precedence over papers valid
> for a single architecture (power.org).
>
> Would you support a patch having the following strings?
>
> model = "CAVM, Octeon 3860";
> model = "CAVM, Octeon 6880";
>
> Otherwise, please, make a suggestion.

    Documentation/devicetree/bindings/vendor-prefixes.txt already has the 
vendor prefix for Cavium, and it's (surprise!) "cavium".
    Otherwise, the names look much better -- just remove space after comma please.

> Best regards
>
> Heinrich Schuchardt

MBR, Sergei

[PATCH 1/1 v2] MIPS: DTS: cavium-octeon: provide model attribute

[Heinrich Schuchardt]

Downstream packages like Debian flash-kernel rely on
/proc/device-tree/model
to determine how to install an updated kernel image.

Most dts files provide this property.

This patch adds a model attribute Octeon CPUs.

v2:
	Use vendor prefix defined in vendor-prefixes.txt.
	Separate model from vendor by comma.
	Avoid wildcards.

Cc: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
Cc: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Signed-off-by: Heinrich Schuchardt <xypron.glpk-Mmb7MZpHnFY@public.gmane.org>
---
 arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts | 1 +
 arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
index 9c48e05..f70cd58 100644
--- a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
+++ b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
@@ -8,6 +8,7 @@
  */
 / {
 	compatible = "cavium,octeon-3860";
+	model = "cavium,Octeon 3860";
 	#address-cells = <2>;
 	#size-cells = <2>;
 	interrupt-parent = <&ciu>;
diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
index 79b46fc..0b40899 100644
--- a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
+++ b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
@@ -8,6 +8,7 @@
  */
 / {
 	compatible = "cavium,octeon-6880";
+	model = "cavium,Octeon 6880";
 	#address-cells = <2>;
 	#size-cells = <2>;
 	interrupt-parent = <&ciu2>;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute

[Aaro Koskinen]

Hi,

On Mon, Feb 15, 2016 at 06:52:20PM +0100, Heinrich Schuchardt wrote:
> On 02/15/2016 12:16 PM, Sergei Shtylyov wrote:
> > On 2/15/2016 8:26 AM, Heinrich Schuchardt wrote:
> >> Downstream packages like Debian flash-kernel rely on
> >> /proc/device-tree/model
> >> to determine how to install an updated kernel image.
> 
> Would you support a patch having the following strings?
> 
> model = "CAVM, Octeon 3860";
> model = "CAVM, Octeon 6880";

The built-in DTBs are shared by multiple completely different boards
(from multiple different manufacturers). How would those strings help
for cases like flash-kernel?

A.

Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute

[Heinrich Schuchardt]

On 02/15/2016 07:38 PM, Aaro Koskinen wrote:
> Hi,
> 
> On Mon, Feb 15, 2016 at 06:52:20PM +0100, Heinrich Schuchardt wrote:
>> On 02/15/2016 12:16 PM, Sergei Shtylyov wrote:
>>> On 2/15/2016 8:26 AM, Heinrich Schuchardt wrote:
>>>> Downstream packages like Debian flash-kernel rely on
>>>> /proc/device-tree/model
>>>> to determine how to install an updated kernel image.
>>
>> Would you support a patch having the following strings?
>>
>> model = "CAVM, Octeon 3860";
>> model = "CAVM, Octeon 6880";
> 
> The built-in DTBs are shared by multiple completely different boards
> (from multiple different manufacturers). How would those strings help
> for cases like flash-kernel?
> 
> A.
> 
Hello Aaro,

flash-kernel has a database /usr/share/flash-kernel/db/all.db with
entries like:

Machine: LeMaker Banana Pi
Kernel-Flavors: armmp armmp-lpae
Boot-Script-Path: /boot/boot.scr
DTB-Id: sun7i-a20-bananapi.dtb
U-Boot-Script-Name: bootscr.sunxi
Required-Packages: u-boot-tools

Machine refers to the value of /proc/device-tree/model.
DTB-Id is the dtb to be installed.

So what flash-kernel does is:
- look up value of /proc/device-tree/model
- retrieve correlated dtb file name from database
- install dtb with this name
- create symbolic links for the dtb

If multiple boards use the the same dtb that is fine with flash-kernel
as long as the value of model is unique per dtb.

Best regards

Heinrich Schuchardt
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute

[Aaro Koskinen]

Hi,

On Mon, Feb 15, 2016 at 08:21:33PM +0100, Heinrich Schuchardt wrote:
> flash-kernel has a database /usr/share/flash-kernel/db/all.db with
> entries like:
> 
> Machine: LeMaker Banana Pi
> Kernel-Flavors: armmp armmp-lpae
> Boot-Script-Path: /boot/boot.scr
> DTB-Id: sun7i-a20-bananapi.dtb
> U-Boot-Script-Name: bootscr.sunxi
> Required-Packages: u-boot-tools
> 
> Machine refers to the value of /proc/device-tree/model.
> DTB-Id is the dtb to be installed.
> 
> So what flash-kernel does is:
> - look up value of /proc/device-tree/model
> - retrieve correlated dtb file name from database
> - install dtb with this name
> - create symbolic links for the dtb
> 
> If multiple boards use the the same dtb that is fine with flash-kernel
> as long as the value of model is unique per dtb.

OCTEON does not work like this. The file you are modifying
(octeon_3xxx.dts) is compiled into the kernel, and there is no external
DTB file. So the model string will be always the same regardless on
which board you have booted the kernel.

A.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute

[Heinrich Schuchardt]

On 02/15/2016 08:40 PM, Aaro Koskinen wrote:
> Hi,
> 
> On Mon, Feb 15, 2016 at 08:21:33PM +0100, Heinrich Schuchardt wrote:
>> flash-kernel has a database /usr/share/flash-kernel/db/all.db with
>> entries like:
>>
>> Machine: LeMaker Banana Pi
>> Kernel-Flavors: armmp armmp-lpae
>> Boot-Script-Path: /boot/boot.scr
>> DTB-Id: sun7i-a20-bananapi.dtb
>> U-Boot-Script-Name: bootscr.sunxi
>> Required-Packages: u-boot-tools
>>
>> Machine refers to the value of /proc/device-tree/model.
>> DTB-Id is the dtb to be installed.
>>
>> So what flash-kernel does is:
>> - look up value of /proc/device-tree/model
>> - retrieve correlated dtb file name from database
>> - install dtb with this name
>> - create symbolic links for the dtb
>>
>> If multiple boards use the the same dtb that is fine with flash-kernel
>> as long as the value of model is unique per dtb.
> 
> OCTEON does not work like this. The file you are modifying
> (octeon_3xxx.dts) is compiled into the kernel, and there is no external
> DTB file. So the model string will be always the same regardless on
> which board you have booted the kernel.
> 
> A.
>
Hello Aaro,

you are right DTBs are built in for MIPS systems.

Still it would be useful to be able to use the same property 'model' to
determine which u-boot script (boot.scr) to install.

Best regards

Heinrich Schuchardt

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute

[Aaro Koskinen]

Hi,

On Mon, Feb 15, 2016 at 08:50:48PM +0100, Heinrich Schuchardt wrote:
> On 02/15/2016 08:40 PM, Aaro Koskinen wrote:
> > On Mon, Feb 15, 2016 at 08:21:33PM +0100, Heinrich Schuchardt wrote:
> >> flash-kernel has a database /usr/share/flash-kernel/db/all.db with
> >> entries like:
> >>
> >> Machine: LeMaker Banana Pi
> >> Kernel-Flavors: armmp armmp-lpae
> >> Boot-Script-Path: /boot/boot.scr
> >> DTB-Id: sun7i-a20-bananapi.dtb
> >> U-Boot-Script-Name: bootscr.sunxi
> >> Required-Packages: u-boot-tools
> >>
> >> Machine refers to the value of /proc/device-tree/model.
> >> DTB-Id is the dtb to be installed.
> >>
> >> So what flash-kernel does is:
> >> - look up value of /proc/device-tree/model
> >> - retrieve correlated dtb file name from database
> >> - install dtb with this name
> >> - create symbolic links for the dtb
> >>
> >> If multiple boards use the the same dtb that is fine with flash-kernel
> >> as long as the value of model is unique per dtb.
> > 
> > OCTEON does not work like this. The file you are modifying
> > (octeon_3xxx.dts) is compiled into the kernel, and there is no external
> > DTB file. So the model string will be always the same regardless on
> > which board you have booted the kernel.
> 
> you are right DTBs are built in for MIPS systems.
> 
> Still it would be useful to be able to use the same property 'model' to
> determine which u-boot script (boot.scr) to install.

But that cannot be solved by adding a static model string to
octeon_3xxx.dts, because different OCTEON boards need different u-boot
commands (some boot from flash, some from mmc, some from USB, etc.).

A.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1 v2] MIPS: DTS: cavium-octeon: provide model attribute

[David Daney]

On 02/15/2016 10:35 AM, Heinrich Schuchardt wrote:
> Downstream packages like Debian flash-kernel rely on
> /proc/device-tree/model
> to determine how to install an updated kernel image.
>
> Most dts files provide this property.
>
> This patch adds a model attribute Octeon CPUs.
>
> v2:
> 	Use vendor prefix defined in vendor-prefixes.txt.
> 	Separate model from vendor by comma.
> 	Avoid wildcards.
>
> Cc: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> Cc: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk-Mmb7MZpHnFY@public.gmane.org>


NAK.

These device tree templates are only used on systems with archaic 
versions of u-boot.  For all modern OCTEON systems, the device tree is 
provided by the firmware and is not under the control of the authors of 
the Linux kernel.

Whatever problem you are attempting to solve, almost by definition, 
cannot be solved by modifying these files.

We are worse off changing these, and giving people false hope that you 
are fixing something, than doing nothing.

David Daney



> ---
>   arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts | 1 +
>   arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
> index 9c48e05..f70cd58 100644
> --- a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
> +++ b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
> @@ -8,6 +8,7 @@
>    */
>   / {
>   	compatible = "cavium,octeon-3860";
> +	model = "cavium,Octeon 3860";
>   	#address-cells = <2>;
>   	#size-cells = <2>;
>   	interrupt-parent = <&ciu>;
> diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
> index 79b46fc..0b40899 100644
> --- a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
> +++ b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
> @@ -8,6 +8,7 @@
>    */
>   / {
>   	compatible = "cavium,octeon-6880";
> +	model = "cavium,Octeon 6880";
>   	#address-cells = <2>;
>   	#size-cells = <2>;
>   	interrupt-parent = <&ciu2>;
>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html