From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 1/3 v2] net: smsc911x: augment device tree bindings Date: Wed, 24 Aug 2016 17:55:41 +0200 Message-ID: <11789209.AN7vYDaEbx@wuerfel> References: <1472043582-7653-1-git-send-email-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1472043582-7653-1-git-send-email-linus.walleij@linaro.org> Sender: netdev-owner@vger.kernel.org To: Linus Walleij Cc: netdev@vger.kernel.org, "David S . Miller" , Steve Glendinning , Guenter Roeck , Jeremy Linton , Kamlakant Patel , Pavel Fedin , devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On Wednesday, August 24, 2016 2:59:40 PM CEST Linus Walleij wrote: > +- interrupts : Should contain the SMSC LAN > + interrupt line as cell 0, cell 1 is an OPTIONAL PME (power > + management event) interrupt that is able to wake up the host > + system with a 50ms pulse on network activity > + For generic bindings for interrupt controller parents, refer to > + interrupt-controller/interrupts.txt I think you should (slightly) reword this to avoid using the term "cell", which refers to a 32-bit word in the property, not the interrupt specifier that is often made up of two or three cells. Maybe something like - interrupts: one or two interrupt specifiers: - The first interrupt is the SMSC LAN interrupt line. - The second interrupt (if present) is the power management event ... Arnd